From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB8CEB64D8 for ; Wed, 21 Jun 2023 11:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 976CF8D0003; Wed, 21 Jun 2023 07:38:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 926818D0001; Wed, 21 Jun 2023 07:38:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C7C88D0003; Wed, 21 Jun 2023 07:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C1EA8D0001 for ; Wed, 21 Jun 2023 07:38:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 410FD1A09A1 for ; Wed, 21 Jun 2023 11:38:46 +0000 (UTC) X-FDA: 80926557852.22.9C5E236 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2070.outbound.protection.outlook.com [40.107.95.70]) by imf28.hostedemail.com (Postfix) with ESMTP id 78AF9C000F for ; Wed, 21 Jun 2023 11:38:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=UZ7er8Oi; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.95.70 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687347523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IX7Ahg5UBy/S63Dei+vKeP8NsVx3rHrbfVvnBdBQX6w=; b=tSqhQtTU6l15h7aBQ0ssEvnqvvtbcwnBGhoOlS4R4Y5Q4/aLQp9uMiBNDVFPimsb1HhMHK Y9QI/rOukwS5IhS06R7Zfq+Lwiic9/6OvwOKEQnQnl31bZpqq1YjvEsyy1jzjaK/WDSWvO 5KATq1CNKLxe809s7i76DilLI7fgFbA= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1687347523; a=rsa-sha256; cv=pass; b=D5uk4F5D+nkripD7Mf5uhiTfOHXz/v6+/9n+RbgbjZkismU4vFsQZHw3qdsqrhn8Mcekmr P70VmwUMXSo8ElCe33K6/aLUYPtQs0rtgnjgcg8BHufqoRr/5Ot3z2NtVbVy733JmOuvKH VkkD8Aie5/dujLxGu+6EdIX2Dz13t+s= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=UZ7er8Oi; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf28.hostedemail.com: domain of jgg@nvidia.com designates 40.107.95.70 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0y5T2UZwjA87EdQeuCB1lautZZ4FNyICZNddA2tq6TBoRfKmDiRuvJxg+A34+NZbtdzahhjaqpcEQJMhfM8mchA3g+cDnvwh6ZcSNIEoVfKZWCwQyTc3FbLVPIA1vBzhbjZViobubFsY+D33NTVR4RVWvLTND+SebKjxa5l9jPRHX4ZlkPHNriA5o6AMU/8dOYsVXDQ+joCoLiark1GegzHsuObeQ/huZuaiUrzjw46dV0iimNQ6lVKzu7JtQ0NnNlXW+lTFC6/HuAeg13l2jRhXfsWbiDzN93hJ9UxrmDWLvaMtzelmHL56irDW9Yo1NacGhjylZS68WvE+8L+ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IX7Ahg5UBy/S63Dei+vKeP8NsVx3rHrbfVvnBdBQX6w=; b=T5znofXp2UBKvp42aY4Nul5J7fHE7IglbblIW8aqKt+1k2ge/aowN1NW9FccDIu9c0Q/p8jyBsRn1xYgMYCqR7TVULHhpiKZWmjkIhnw4iGsp1EIoRYClJJTqCX/38ujqbGzxl4irkF2hdY+i3MMSKYqBPABORC16B2MTRjMfhW43a1dCStTP+m45FcQT8XyyWEU077c2y40tq4DB+FU/e2Fm66bKXAOkOfhYyeZ+nqotd6mVbTmqQ4KuFsVmMPloC+qirzaZv0bKMm3fh/4X0r8YY7EMk8ZwqZpqBAgFd4SFC301jeQ5dm3ykiaKnekxPRnhwMoHcPWIfw2dpt35g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IX7Ahg5UBy/S63Dei+vKeP8NsVx3rHrbfVvnBdBQX6w=; b=UZ7er8OitlHHRiPMFKIwOzg092EfsB3byi+2ZEcW2zHUIyidFuAhEAPsM8qiNrTAVEE3+506kgrUBFG0TfsIM9wKSijT9aXwjAd9WleCn5YfeGiJLjf+cDqhsfpjMtBrwX92xS1IWH33reMymGY3DGeK9GrpDw6jNqdXexjFVTQnY3iPKHCAtDiKsiQz7bTNSjlNWYJIuzOt8QpRtnZtEWOiX3Y+O6MxIvDXTYD9V12Oep2DS8QVIhO64jKeK/5I25yQOhi7ag8UxoTG5Ql8Cs7WtoGAwULoKTB6zwJR2jdZzKfiYXziH5E840xOwZPli7s88q5ra9oFq4VU8hxJJQ== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by CH3PR12MB9027.namprd12.prod.outlook.com (2603:10b6:610:120::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Wed, 21 Jun 2023 11:38:41 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::f7a7:a561:87e9:5fab%7]) with mapi id 15.20.6500.031; Wed, 21 Jun 2023 11:38:40 +0000 Date: Wed, 21 Jun 2023 08:38:37 -0300 From: Jason Gunthorpe To: David Hildenbrand Cc: Andrew Morton , John Hubbard , linux-mm@kvack.org, Lorenzo Stoakes , syzbot+353c7be4964c6253f24a@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/gup: Do not return 0 from pin_user_pages_fast() for bad args Message-ID: References: <0-v1-3d5ed1f20d50+104-gup_overflow_jgg@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SJ0P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::33) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|CH3PR12MB9027:EE_ X-MS-Office365-Filtering-Correlation-Id: d4480a44-c6c5-4c60-4ec2-08db724c0f7c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KKCi59kjHHKfuD9rOfUJgyMHq1usit2kmreLUJohm6E/HfCy9v/IMVivZI5qOuB756UWH74wEARmEHKO9HAxo1p1CgjbWjD6bfCt+dFyn/6vZpmTbilPThiz9Q4IxuGTGQ1loVMpvZeT/3eE9SsoK0GdRl+yFATtoToZJrCmnNhWiffV/8492au4tVsM26mej7TvxoOY2TitzdaQq0gz9OaPVW1aHrmg4r9SPh4opIh1REqAMHWTs+11v0klcqLfuv0C2uwEnnHDqE0tv08riezRMNFUr/bw9IiWc8AtKIYtkh5E35zeZH9HOEPvXQZNd9ruQWkbQGNiGZbqZUlCvWP6yeSFhHQkWLwJeJhg4rY7EjsG6kBAvtk+fzaNHscxsb7cxtOwg1Meid7mlHiPZIcERWN7LHR7HfjCFcnEnk0kF+SHmjVy8FhdOOcYZqawx71rsuSlLhCAmIF3oZWmSd8JbfRtOzBp7YhxediDpTtWKCTQiXerNLcXdwYTZD9oRcozJgQLq/eYzExGgMeu3ySCaJtIRm0AXWSfPjaytVihDy2LEUku8WiudUKbRT45 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199021)(4326008)(66556008)(66946007)(66476007)(186003)(6916009)(2616005)(38100700002)(86362001)(6512007)(6506007)(26005)(36756003)(478600001)(54906003)(6486002)(6666004)(2906002)(4744005)(8936002)(8676002)(5660300002)(316002)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jMLPcFmwm8LFTUx/Ap9pqs0WpCKxOHwAiCws7BuEVnKIPqstSNnImEKGcUDO?= =?us-ascii?Q?n5kz7r9UhZgRxl1D3OeMlP5bDRInQqn34d+/jIJSzEp9zXhDZ1MqyV8msi8X?= =?us-ascii?Q?0H1Be0dbMbZ/W9LV8ysftQ/g3xY6n299QSffyc36tXUAf8KZxv2akt5dk3J2?= =?us-ascii?Q?dVjEV5cXU0VdBrguz+e2mqUAJGvlCNsLtDw8MzkeY8oBLW2OmIx1OwWOLW/v?= =?us-ascii?Q?SAfxLXoUsIPHcC7W3A8H7DEw+T6ORSvhECL9lV0pXQ6jnrpMmB9hzIUkfgIL?= =?us-ascii?Q?DRS1EMWo9l9D/fn/9C6JWGklI6lHJLQnFuLyeuXy8dz1HcKoQfUh3GpRQMrv?= =?us-ascii?Q?HGmvQ62mx5wM5PvPPAocS3e5TMvI3t6uXVxDs6l22tIxggo8MNnVpcX1s9n2?= =?us-ascii?Q?WyPtRNnQ6xW75RsQ61/CcJ0SFHGTZDguKkx12i37erD7JxCst1p3kpZppTSH?= =?us-ascii?Q?nwenZb/ODxPXT7IEJGx+lJsdT2H6IRzP5u/bcka8Dd2JH02oNJhlWkzyYnij?= =?us-ascii?Q?Cg8yg5cmnhE39t4ovZa+v5biJBylVNps66GElvUBk/3GFF/mKBrjm0V/pMnc?= =?us-ascii?Q?CzQ6E+70MmBhld600RjfDFtX8+W+l45CuFO+J5Zk39JUfPQLf2VOJ6O4tjig?= =?us-ascii?Q?xuLE1z2y/ZgrCrLsaP3TxwNgEu8cqrDxpb0KSRicrX18nT4BhZXE5/5vnsEY?= =?us-ascii?Q?Cqjl3Pm4j5g75FRfymRYQTWDle17bDFtovjo4kovpgZL3GxvTrst1F5mUmyy?= =?us-ascii?Q?HQ1rOEP0sWNiNr1TVxcSIz1X7jI0nlblQcOnm5puWTtijkjz7+dOAcrU1SiZ?= =?us-ascii?Q?C8aZ8pSY5G2RiH1tuK0OddsnPZInITixIUdSQ6dNAKQaF0n47S1X1HuNM8z1?= =?us-ascii?Q?ZwLk2GW3ajhmggtMgxJ4LuL8LqKUBg14hRkfZQ8CjPlMTyjFxfH9vQohOUAP?= =?us-ascii?Q?sihekRPvJkC7RgU0MBIEbzVMaKu7rboWyA4QwggCIuP+peKEaMSark2Eo6P0?= =?us-ascii?Q?J/afGOXGr8yGfQQCWo5x8OvCGHmTX+Ox7zjo2XwYZGp20k0xO/z/Yw2dyZV1?= =?us-ascii?Q?2dhwx8BL2Od8ijeUTsBrP3UGjAQGUZvrqalzWViYh/uXo2bS0bEZFVjCkksc?= =?us-ascii?Q?Y1AAqsZBZAYh1FeCeOtb78iQBJ7upePYjuC9l6pM3ElJXZeJ2rtSbBgDrfQN?= =?us-ascii?Q?65tnnSjKfS/+gplO4Y7JxJCqENSPAJR4uYG8uKeyS95lBIFRHvt8UBsvgkGV?= =?us-ascii?Q?NyCWdA1Ve9FUAS+U9m0ev4A6o059/i2UJce5FJnv16W8pUCC1oM7wjqVRm+8?= =?us-ascii?Q?50wqojK8JmCOp/Nzb9R0Lkemh/FlRFFxLjp0WOQ9+kaBPBABJ8wf5EUrlAQT?= =?us-ascii?Q?EWjUV5fnnDq7ddhTQry/AtbGAkF6vYMLi06KrjxLHKoqivKiXMq3yDcUjSQU?= =?us-ascii?Q?SwjehD9A/7Wrvpxaff/sv+Y0YtaZdJdWLSFrLgdkF0qW5nNq22wqVtXe6c67?= =?us-ascii?Q?aAZql1oBF06GYfYsUXY1ERpiRRvJfZaajMnbti6q1+7nzKtRxH+mz2+YaY5f?= =?us-ascii?Q?kij9dJjH4dH8KIlPgxAamGsRL1ZwvccZ1xjPXdjg?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4480a44-c6c5-4c60-4ec2-08db724c0f7c X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 11:38:40.7197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x5/My20/h2oPKOWAPWKWhqIlxW2J4yKSY0B4GvxspWQHmZ6ZniOkc8XP5995tQCm X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9027 X-Stat-Signature: 8wx66bqotuxb4giyfq6mpnw976dxngps X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 78AF9C000F X-Rspam-User: X-HE-Tag: 1687347523-892100 X-HE-Meta: U2FsdGVkX1/+aHVZbG14rW9mZl/Jmn7fQjODtiQIAKuF5nNT3RI1Q70AcHZBW/Wvg+E7t5D3aHn3sq5fJggKcCRB7VXl2RpfExpeIPO4ln5f2ipUeV0fc8aATOr+ZUQJVXgweZ/y5TwI832jkEnl2/Ob9NefGbiFovyVs67HoGPKlt8Dj0lkxFHsUpxuKfqFS4YLZ+yWw/GippINiWH85QBi2GXV8UwHsti+zPhTvnR33bzD5mP9PNoO8cm5wXOxDlKa/BtLAo939WnK1ot0JbXmyUIKzWVH+q5+WxRk9A4aDslHcqYVPOO4iVV24B2kGAeYqFALff7CQiQtEYmdSkCYW2L9qHCroi/dIrIaWr6UxntdpHkg64b6Ly1UCBLosKgYW240LjsrFj8R93t/Fz3UbTXO7uYg2CuZ4T2WlYzeQ+qoMCFGiZHRD1R+A/2Bw8dEN8rj/E/7wVLOPlcrs0xKcNJte2bW7Sr4t/q6tfWrQJs+LHUc3cys32BxVJ6xEWMpOBXIvV1KWfpkDzfTByMNAs7VEIwmKx/qW3jYUg2jJSzSpa1nYqO7/dSJFDV7JKGaitiDoiVCdoVN3ftpvYM41x3iCmD1cRUsIZ3QQckiX+7bDzuoOlPpgsF6LUMfjMOQDDDn0wLkyR/pTvK4V3QIxybBPdYp95zONn5KEr5Qsxo75h0Lzu+VbzIOZmjr39qgwGcdZad4/EPBuhzKqOdIl2zTmuE28lwHEzJ34vw85xqViTef8WyaC3XiYbhdDDKPfXNysI7eaSMjcNe9xydfP5JcVSU5alpW4XnKPTI2Ya56vxC3bSwEIDY+K5O11bOityZ43k8JoNDNjd2REEVWa/l+/Y7ehrgj2KUVnnwtJ4U5bAUjjj/BKaaj5eN4D/Sa1RomQ7Bbjg6qXW2BLrrol5K9QF6zEHbS8PNE9zEu5jLL8RAmHN4ag8eK/Aoy7tDSumWykLbawU5W9Jp fvqwv8K0 hC+IK4oH/thCRQ8TnrD1T+JcK3Sw1gqzISAbt/l2XfjbqmCiB+1oahfXqxKkY4hO20L8AHmE4apawPeO2WCRlTncQKa2XH22OsVV0reiIcj+o2WaebijH/IVGh6lplhKGwfu27Y6viz2czkAu9jrLfQH2s6EnSQdMAcvwtocOEBIbsqQMeaHjs53+6M4UXkTRYpOCFepBkNPf/A/zpsxJ0EzfoH8I9xTEfdp96n+DxhzQaLA5odjrHKWKEE+fDOrZL39m8LyY77I0XyBSYMUym8XDZCytSieJRGSy83Wfe5gMSjDULEtuW9qn7YKw+qWql7i8Ej0TR4NXp581aX01XwsI1Q8aTCNrwZaaLNurs3xpHwzHGxzfmZNZ9NiRCEozMekbBJfirvKcUa3XNmH0TEtZzl7q5lTuj169 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 21, 2023 at 01:24:14PM +0200, David Hildenbrand wrote: > > diff --git a/mm/gup.c b/mm/gup.c > > index bbe4162365933e..36c587fec574fd 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -2969,7 +2969,7 @@ static int internal_get_user_pages_fast(unsigned long start, > > start = untagged_addr(start) & PAGE_MASK; > > len = nr_pages << PAGE_SHIFT; > > if (check_add_overflow(start, len, &end)) > > - return 0; > > + return -EOVERFLOW; > > I'm curious if there is any sane use case where that could actually trigger. > Smells like something that should be a WARN_ON_ONCE(), but maybe some > callers simply pass through what user-space gave them. Yes, that is pretty common to just pass through. Thanks, Jason