From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D67FEB64D8 for ; Wed, 21 Jun 2023 11:36:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 274228D0001; Wed, 21 Jun 2023 07:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FBB38D0005; Wed, 21 Jun 2023 07:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04D718D0001; Wed, 21 Jun 2023 07:36:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E5D968D0005 for ; Wed, 21 Jun 2023 07:36:56 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 89FDE809CD for ; Wed, 21 Jun 2023 11:36:56 +0000 (UTC) X-FDA: 80926553232.27.1EC242F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf01.hostedemail.com (Postfix) with ESMTP id 80F4840009; Wed, 21 Jun 2023 11:36:53 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=iwyLnEK1; spf=pass (imf01.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687347414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/FQApQPgb/S6VB9crvo39szrL+RZ0B9Iq9K2WpGCiTo=; b=Pv6xJSQqfgjH5zM7xEgtw4WQcVeiml/80ctxalbadI9Y0ZpsOfoZYXHOsM+XWsjTufah+c +mWQzax/71J6ubau16PR04+okbs4QPAejbqmwHildKP5YBjsa8ZiYi0+asPgnp1Hen3Fgq 38Vb2E0RqpZGcrJ0gF4RolfSVvyNWyw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=iwyLnEK1; spf=pass (imf01.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687347414; a=rsa-sha256; cv=none; b=POokYTVPp4+52ghG6dTFomT/1LWG7piy5c5bxx2EWp23SMmsmHYbeEJee1j+EaqyUUAZWj 4VweaCX9ewXxG8wJYZv27xcQ1hoUU/Xk8jzrS0eG05MsrLv9H5oDhJ6e+HEUZB81CrmC9K rG4TxzCLUXnvc7aydL/E6FnvJdOir34= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C596A21BFF; Wed, 21 Jun 2023 11:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1687347411; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/FQApQPgb/S6VB9crvo39szrL+RZ0B9Iq9K2WpGCiTo=; b=iwyLnEK1VeUWv/tmm/Nm6Cx5NbYxgFmj0mH+P5/gDg9l9WiFHQ1aqfL3EEa87DHfpr/aUI PhCVJRawNs68LlACkkSmFEImXna0QGgLP5xUaED+wkuZFJn4wrg4DCWfOxgJw3/ea1pY1O C9tLa1Flx054EBbIvKK/ApG8ncbzfFo= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 144972C141; Wed, 21 Jun 2023 11:36:46 +0000 (UTC) Date: Wed, 21 Jun 2023 13:36:46 +0200 From: Petr Mladek To: Joel Granados Cc: mcgrof@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Jiri Slaby , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init Message-ID: References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621091000.424843-9-j.granados@samsung.com> X-Rspamd-Queue-Id: 80F4840009 X-Rspam-User: X-Stat-Signature: i54ram7wiff7mmoxik3o67sdizm3uaej X-Rspamd-Server: rspam01 X-HE-Tag: 1687347413-366034 X-HE-Meta: U2FsdGVkX1++37a/hXpSxuagctU1fc47F8AdmOPKcCJc7T/oTqRPaFPAohQNJLFU1iyJF9XjqlLKRsptMQieUCVIscbiM0+48aAEplu+H4xTqqK+KbmMmaaOds+w1q/tN2mmtQ6tGY7+N3QpkagPJvAR9luNjAM6e+u6oMeArMeW5fUp3jONNWZ71twsN41H9tEnh/47gKIqNNqnkyA8Xb7Yxh1VGr2WcsLbJa4Kw6gODARQ1SgVmSN6f1IH2TvIkYSAuJqDmyPFGGUXu5UUZPF4dWTkAdUOEPo0zBJNAHZIuXaDgrJrsAEyxNKMnlKekE8AZAczIzGRb4sPkTJgfjn0WKe1w1QoaidHGPrHL3cQgpiOEVL0A9NGjoe1wfB3eF4Np8IKS0LYGvoe2tcmyRlijYJ0QEqeSS+0LRUXa7sFFmbQnlUu5X29px84p/8YssVcGgLovfS2s3tlFAe97qUP9aIBqOnBf74LH/TXLUYc98oVab+3UPTTZ1OVjLDRIWOpuXKNiFeA6ey03ZkgIVtrzERxVFv4iTHpiQNd5f6gAeLhd8hqKnoPEWOMleGTn4yN7wbpK2MqtcOtTFJohHkmSdunq562qs1cV6rBV/JeWPoZKgQUiMLtiVkhJYk9s0Zuf25oFogRjlR4NpHkWmxtiskq0JgqNr4OW2UdYfWDy3eknfqpyiRLpLuZMUaFMS/UpQXKuRLUivv3AND3OqbWFhbOrmhGY8XlJyOV0BCB+WWLOYZtoHaRGAza0f37k+8V2Y96yEfPBfsaIaNPkqT70a+qe9TH/d73emIUBkKVt3MRSfxHbhLGigD6SbJRuVTJvssPzxIY6BkJmf+Ujy3NuALc0b0P/fwDIoa+C4E+3ujHE0kr94tELq2/Y+iBmTV0uEnH7pMvVwgcCLo3RqBpdGpy1hth8banFbz2yPBisbYLOxpq7hE3REvqPiwfkLlTwUR8K4bz7UHS448 uoDEEvKI ZHYuLdlgoKzpB1ydDW+ndNixPkCHp6U/IidwKIQi+XGOctjOJWF8clOoXgV5z1gaWA/SPsDaRRNNMsEthNjG+hHVcqiFabDa7buGIg176Da8br/V1DShwxrUp94m0uj9DT3ub8FUkwAuYHrWvejbPGzY3ajXXo8mCtOi4LEEuaFh81Xzq5JKEs8bhb5yNZtuOaOCwMsJuPSrKVII7DBiIiQNIhdSBo1+cVsGCNeb7VzZM5wahekV1dSK+FwbmSv0RsKfIf+d/CDSOBzA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 2023-06-21 11:09:57, Joel Granados wrote: > In order to remove the end element from the ctl_table struct arrays, we > explicitly define the size when registering the targes. We add a size > argument to the register_sysctl_init call and pass an ARRAY_SIZE for all > the callers. This does not explain the motivatin why the end element is removed. I agree with Jiri that saving 9k is a questionable gain. According to the cover letter it saved 0,00%. It is because it saved 9k with allyes config which produces huge kernel. IMHO, the 9k might be interesting only for a tiny kernel. But I guess that it would safe much less bytes there. And the code with the added ARRAY_SIZE() parameter looks worse than before. > diff --git a/kernel/printk/sysctl.c b/kernel/printk/sysctl.c > index c228343eeb97..28f37b86414e 100644 > --- a/kernel/printk/sysctl.c > +++ b/kernel/printk/sysctl.c > @@ -81,5 +81,6 @@ static struct ctl_table printk_sysctls[] = { > > void __init printk_sysctl_init(void) > { > - register_sysctl_init("kernel", printk_sysctls); > + register_sysctl_init("kernel", printk_sysctls, > + ARRAY_SIZE(printk_sysctls)); > } Is register_sysctl_init() still ready to handle the last empty element, please? I am not in Cc on the related patches. Best Regards, Petr