From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D8B4EB64D7 for ; Tue, 20 Jun 2023 17:23:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 629998D0002; Tue, 20 Jun 2023 13:23:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DA468D0001; Tue, 20 Jun 2023 13:23:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A2998D0002; Tue, 20 Jun 2023 13:23:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 38F468D0001 for ; Tue, 20 Jun 2023 13:23:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04723C01B1 for ; Tue, 20 Jun 2023 17:23:41 +0000 (UTC) X-FDA: 80923798284.03.0177854 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf19.hostedemail.com (Postfix) with ESMTP id D9B0F1A0005 for ; Tue, 20 Jun 2023 17:23:39 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sjjrqJuC; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687281820; a=rsa-sha256; cv=none; b=Hp34FbY7hCs8TRihUbFCFnz+HJB3x2o4f8G/nYZ0INWhVYTJehD0WkKegOFpSFHc6W5A0L hi70APFnOQhaBcCEaEcmI3lwVG5dJf+FPtOdWVMubuwxnCvlmGjHUAkEoeZX/zWFmJiUVl zDkmfoelB98seYzj4Zj7MlgmZfrKpV8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sjjrqJuC; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687281820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s9mWYfGROnySR6uue4WG7vLMYCpdaHNd7ovm5oIrCjM=; b=Wl1o4EAks4ZtUHnAOanV88k6TgE3Yjh43nFCableet0NCFUB+NpD25a+/SSjX+RpY8Tv3e TsWJVdVtT555aB2Dp0W5306qeOj87SUN7+6t8HWH3GlnkJ4twNvSchOrSo3KeXT14n1W87 Hnptbpe+gWqE9U50XktkLS+keAfqp2s= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-312863a983fso40789f8f.2 for ; Tue, 20 Jun 2023 10:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687281818; x=1689873818; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s9mWYfGROnySR6uue4WG7vLMYCpdaHNd7ovm5oIrCjM=; b=sjjrqJuC8PtXRZT+5ho8yuTY2RZb87MRMx42D91FylA8zy7UMk2YpWvEyJCAJal1b6 Y0kRm37nwj9f+T/Cwqsz7krNQ+i18PGH0LOxj66r7TJDy5pxVw26z/VEwlKYSSx+XGE8 wz52XXQJ0/e2DhlkqGFyt3J/IpFe3JqZYjQcDPuAl2kKymDu/0qNz8mtv8eQcxpW5zG8 24z2T+nHBY7ld2xxKWJ8JG1i8kE8bhe3wVd8Qz2ZrjdA3E6JYa3r8DJWfpR+pS6tyiNy lrx7viRfFKHW0VGpHt0RRHaVrX3ZOI5wjftMsTv0O6/Y0YpVNMX6yElyJK2957vFOC4M qxTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687281818; x=1689873818; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s9mWYfGROnySR6uue4WG7vLMYCpdaHNd7ovm5oIrCjM=; b=kNy1W0FqeHaWwWaTTsMkvznqcdl6iOgAtEViYKcN5DCY2/4qLuiKXYy2P2eqgy3WUV kqBuoJKsjm/epaQTRZSvB9smi28Ty1h4KfI8hlMWD7lK85vDHnguqSQ6M5f9vjuFVdIx 5jcXKVnknZjd0D/oH1z6uP5Z+IEF6CGtFq7Emhorx8y6VV1XhmgPh5u0Ti+83Ok3Ahmm tF+g/XQHaQF1JCBTN9cScT4iJ4inVHSpGz1Sfe1lI8Jk5jSBcGVCfNl+LcT56yy0QTJX Ut7+TCQeeh34LHTFnheFZVSfuGhUvELjBLinZS6ltH3fQSTJ5oU0Hvs7XlvGJtkZac12 9kfw== X-Gm-Message-State: AC+VfDwYjOWYUZuvzxeB+yWmzQjPYTdv2lWTwJXhY3J+Nb02Z7+xVLkd Vn3nqvCmyblceiOBCZN28a6IwQ== X-Google-Smtp-Source: ACHHUZ6wW1/zMPhc3JJbi6ECRYVjtyECOJO389GeUQGew9ZCiR6IuKO24ckak353ubn1mfb8xc+nNA== X-Received: by 2002:adf:f004:0:b0:311:1df7:3e05 with SMTP id j4-20020adff004000000b003111df73e05mr9335340wro.22.1687281818234; Tue, 20 Jun 2023 10:23:38 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:8530:a6a3:373f:683c]) by smtp.gmail.com with ESMTPSA id g18-20020a7bc4d2000000b003f8d0308604sm14028860wmk.9.2023.06.20.10.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 10:23:37 -0700 (PDT) Date: Tue, 20 Jun 2023 19:23:31 +0200 From: Marco Elver To: Andrey Konovalov , Andrew Morton Cc: Alexander Potapenko , Dmitry Vyukov , Taras Madan , Aleksandr Nogikh , Andrey Ryabinin , Vincenzo Frascino , Jonathan Corbet , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Catalin Marinas Subject: Re: [PATCH] kasan: add support for kasan.fault=panic_on_write Message-ID: References: <20230614095158.1133673-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D9B0F1A0005 X-Stat-Signature: rn1zpbsrgzdhs3otyyrrabczzs8zuu9t X-Rspam-User: X-HE-Tag: 1687281819-858548 X-HE-Meta: U2FsdGVkX18j7XwRelzHAvRqS9/Tg9WXsJJTrsHY6LOBsTanp5+uQ/CKF7ZdlFI+8uaLKelPs6zg1iHPIEZTkmLbNHGMb9TrBMv7+WFzyPOzMujzqdIfuwcqYa7rCl3DAactjgj+8kwM9SmWX2IjVY8BJ2ILwzJBN4khW5XFa64lfNRR6+yZqZ7Eqb8ZgKm+JiOXcYW776cC1OuwGs8HbNIpPrB7DcQbRE6kB8rNtdWx62WN5FJKSwcOULtTSBmVtMFIZfEijltlyT2KQJFPHk65M9orYxsu8wQDY8Og8KuUw0Dw05naGJfXb9emP4cTLsTyewN5PTB+ucZC22aFQn86VIhq5gw0olE0JIkAxi80P3hx1hso0yDmL5DCK8glwspFTOP1y2IsHv67An06exssF6yxzPusXMhcUjYkwOVcqBSwaytuku86bQs8yv8w4Rwjf5EtDznuQgtCOnJR2AG6lIcFFWmQCmrBr+8rn+zCm0ZRkuhIB3c8qGwGZYxYq4nMeaeG405MkFXYupDzh78zc7coRwRs+EWyscHb7tSwus7hndkj3ifHlurQrnzJBpzvC1j+HN5HsmxeVHG9mi3ykuNP6/fTZthxYccWcfRXXaAX7QyHWuMflHGLOHs23Sw1DZrm/0AOk1LDK28sBWSe4HCKz0+pOr1eKlT5J+zZLmCOhrlHi7wtZ6UETHASI0Tp1XQe3Kw+s8N1PsPF3Ydj2LK2jdOdaqsGwnXOrpTVrNMWtjjoJL1/2O5+ghrRzfuwxtnSj8GV35jX7eq8Nh9dpSqRgaMKYfSdYlp9meAZBYQNUxj4FCC+KVIsL1xZT6rasOdFWDtvW+FTwFzYugdmc62Qt/WFRRzFlhOkHUK33K3D9IYe8fyS0bVdKSbAHmy1BaeXZzyDln2gMu3T81XusVSE0YderFjYOFdRMRVs3g/jvd1Q1WXieslXgiXt/Cv7XM9+9xtxZnDWUHu x2iqBdm8 urNvgm7igvDH5NGgy6IG31s3RUqAk8ghX/oml7hULZ3cQkw/jnnUxsE5a8rmP0nQKbtx5JgS4jfWnPHjIMlyv9kOc6LY8a91mErm5/MFB0MlUOuiz7Cbibe0vXqHS0UwnB6hcosZcgDINxhgCwNIbjYRaUZqS7Gf4ngdET5v08bWSIJYuqHZxecaxCOb8da43qxq8PUUMmkujUCS0LNwabFJzqsFevWVxgQynx1H5PLKl1D+PaPgW9xn+/99p91M8wk4wSM8xxb8WkEZq8mXQr9l/VE3KTo1OacvqlStT4ixSJJgyhze8alZLtuK0hQ9WUgVxD+XIqWtIuufaZuZcDukIpBt3fhQZMmJzi0tS/5ZABjN6mCR25WUfs+pK1UVZXi/h8UuSHmKv/YOUm13bSYcnoliqje3jvT9nbCOFVz0+bG1ug+hTk+5uxyLwNqmTDBw8Cu0PGwPsp/Mi8QebWUJFSgcd8MV6UowdPJfnoP/NamowWeboJUMqAaSthUm9psZQB+0T5XYjEf0XNch5GNvibdHxFNIVQWEv3eG9ElStTr4t50mvnWuO+CBos2mYaTLH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 06:27PM +0200, Andrey Konovalov wrote: > On Tue, Jun 20, 2023 at 4:49 PM Marco Elver wrote: > > > > On Tue, Jun 20, 2023 at 03:56PM +0200, Andrey Konovalov wrote: > > ... > > > Could you move this to the section that describes the kasan.fault > > > flag? This seems more consistent. > > > > Like this? > > > > > > diff --git a/Documentation/dev-tools/kasan.rst b/Documentation/dev-tools/kasan.rst > > index 7f37a46af574..f4acf9c2e90f 100644 > > --- a/Documentation/dev-tools/kasan.rst > > +++ b/Documentation/dev-tools/kasan.rst > > @@ -110,7 +110,9 @@ parameter can be used to control panic and reporting behaviour: > > - ``kasan.fault=report``, ``=panic``, or ``=panic_on_write`` controls whether > > to only print a KASAN report, panic the kernel, or panic the kernel on > > invalid writes only (default: ``report``). The panic happens even if > > - ``kasan_multi_shot`` is enabled. > > + ``kasan_multi_shot`` is enabled. Note that when using asynchronous mode of > > + Hardware Tag-Based KASAN, ``kasan.fault=panic_on_write`` always panics on > > + asynchronously checked accesses (including reads). > > > > Software and Hardware Tag-Based KASAN modes (see the section about various > > modes below) support altering stack trace collection behavior: > > Yes, this looks great! Thanks! The patch here is already in mm-stable (which I recall doesn't do rebases?), so I sent https://lkml.kernel.org/r/ZJHfL6vavKUZ3Yd8@elver.google.com to be used as a fixup or just added to mm-stable by Andrew at one point or another as well. Thanks, -- Marco