From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC1EEB64D7 for ; Tue, 20 Jun 2023 14:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0DC98D0005; Tue, 20 Jun 2023 10:49:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBE0D8D0001; Tue, 20 Jun 2023 10:49:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87498D0005; Tue, 20 Jun 2023 10:49:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9438B8D0001 for ; Tue, 20 Jun 2023 10:49:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6CB791A113E for ; Tue, 20 Jun 2023 14:49:07 +0000 (UTC) X-FDA: 80923408734.09.F5EA7BE Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf17.hostedemail.com (Postfix) with ESMTP id 4393A4001A for ; Tue, 20 Jun 2023 14:49:04 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="u/nNunrJ"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of elver@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687272545; a=rsa-sha256; cv=none; b=5rVFc1cereqcEmLbEN0ZrRYgEZI+80LO07Dm3XlvsmGeL2/1sEPnhLPWKGDkRdh8WLyCs2 mfWwz5NI7EP16bRJEbQD9QDp2x7p4uhx1ANhi4TctMxwQBuiow8z+qIsQFbypLbYT73JrT pbYCRioh8pHggaOMrMzdkKMjaJL3Lsg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="u/nNunrJ"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of elver@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687272545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFBJCFv89ibLGDxP64+KT5RKVRcJ4ABThqZOUh/7S8U=; b=biv2IqfE8lcOtgIVSSIW1QrWqyCeLC3CpNdxs/u0Ok2ylSfp+4SA1IZOZMXxkgdoMV5ITa DR1GMV0+L4jLw17QGPBeMzraWjaMODz8mqQeyELufMCCquUnwHt1/+3pnZqSHqg9mg8s7h PX0Riueq00uRPam4+wIwZN7KiUQQdtg= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f8fa2cf847so46306315e9.1 for ; Tue, 20 Jun 2023 07:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687272544; x=1689864544; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tFBJCFv89ibLGDxP64+KT5RKVRcJ4ABThqZOUh/7S8U=; b=u/nNunrJJa6/pTEdqFGYPAhtOAsS9D0F0Anp3vZDPkfxNCw2tMiHHZcg6GSyR8nblh CNboKm+SxYJjYaFoXBPLi7zB10yrVnRTrlx+KejPLgk9SlKVgzkg9MlbIvtSsvURzXlf 6/8H1AsUpPrUWvtYsLb6Uz3IQ0FqOD8+Nvyk8FempvIx7zVA5tMD4XJ0wQvB/ziNDViK vyZISyFCCkt5AC9InX2i8JjC6kDmpphGiiaJN8blfT9IYQCbL4eeQ38tTNKebViEPuo+ D9mJkOCfxfhU0sjTaiw1603JgWXxKT5DGz77RpQVXdGXeUm8h6ALOhXtetH/FNZCT4ZZ zMAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687272544; x=1689864544; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tFBJCFv89ibLGDxP64+KT5RKVRcJ4ABThqZOUh/7S8U=; b=BD8gYU596Z3O71pf6PAZvsd5611aM0KZ0z4v/OmRGWeL9e1bfpComb9IFIbrar7J3u eqjUB2vplZWiiMCt234X1wWTIiIiH3D351bIQSehbA2/RrFrC7HrVyAwXp9IaN8F39Aa 1PvOjASSZ78yBj2OMrvvwHBfbsAqdrvqLTTp4QvPYqKgE4QDA861aq5qL2wPM9jjjJF8 UVshXn0nUWUNMdCZxYc20ph/kjaqG5ecbmHOOyGFU+5PSN8J7u79AO/vSvdDosPiGdNV x8YeIGo/cy88+JCwA0DhDbhn6q9758Mt6TCoTNvt83AhsS0UfThE8YTzL6BNaeo1ZH7/ 1iWA== X-Gm-Message-State: AC+VfDx0O1uZHxjo7X1vAec6EiA2pUlJ+IGQbYcZXh5JhtTgxbsmWz/t YGpQRKwQnMOZtf6xutQayZDwOw== X-Google-Smtp-Source: ACHHUZ7LDr1h7a0YR+y1QSbkuQ+nwXK7muhEZDUzjJ87F1Pyf+gCx4EV1rE49ZD6t+JhlLe/MGCHXQ== X-Received: by 2002:a05:600c:231a:b0:3f9:b430:199b with SMTP id 26-20020a05600c231a00b003f9b430199bmr3194468wmo.15.1687272543652; Tue, 20 Jun 2023 07:49:03 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:8530:a6a3:373f:683c]) by smtp.gmail.com with ESMTPSA id i2-20020a05600c290200b003f42d8dd7d1sm13668387wmd.7.2023.06.20.07.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 07:49:03 -0700 (PDT) Date: Tue, 20 Jun 2023 16:48:58 +0200 From: Marco Elver To: Andrey Konovalov Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Taras Madan , Aleksandr Nogikh , Andrey Ryabinin , Vincenzo Frascino , Jonathan Corbet , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Catalin Marinas Subject: Re: [PATCH] kasan: add support for kasan.fault=panic_on_write Message-ID: References: <20230614095158.1133673-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4393A4001A X-Stat-Signature: ei1j881f48wtj17yf173z8ec6wo5fjrt X-HE-Tag: 1687272544-270509 X-HE-Meta: U2FsdGVkX1964BIRNNwnJnO57f6HgWr7qswHGb52pr/vclxPSheZWyowcLAs0yRt+MekY1NU18i683KiZIb177sSq/5l+DfseV5eaVtHrjlc9yew0c9QUukX6z3VGyyTdyQ34tWS/lPFjrlSBUMDuH2exdv2/hyFD5C8nynop0LJLFlSSH5tf8+OThnzrWQepump4cy02dNINlesOex6pKMKYTSmFT3p/hW344y0wf9NF/TUC5AZULeaDzezHp4YNV6rz1iwRjgpjoI2Njp9B2H0jntnfRfw8/BLBEdK1spKNesOmdSNfcXYvg/Gj9DWwKryNdBIXr4n4A475TTwQU0poNJKeutcm4oKAHfPFIiukdTW/kkaGel1xhBO21M+U5WnB//rhErnlTbrh87pSgBbSbiK5wb8JrjFJx6NGtOauphTIB2MNR14k8TdWQ3l9rI2TW9SVPcFRldmSptZuB83/9uVsWZHRFA6N8ZD5/75EXfijFt2+XITc7VlS01nS1G+9zaICwevHuAAX6VDq1ycJkvQ3ifGqGlgBmlCLra4E/a5nVQbh1tli4tt3aMcfk3W3/zoUboQmfU3CIBvBqXDIzDOyVqm9Su1nIsfBofOlmlF4Rs5FgK7zlhcJHL3RLLlDFnNJmy39+sNpbl8gv3lVjYqwGhvnY9rIxqkIq7Hxwn41ryBa9s6PO1Yq3sj50a4M1tZHwMVPQfxj5NhRJPxfhEqEF45TcS76pI3FweKgBMTqhrriYz8veIGvoZOv5vBeiOZSfOo2n53i9++xXknq/je1fq+7As1i6riliHf8+ESGPVFxseEeixmTIcoEB3p2MbgwzM7a4kfQD1uSOia14bosxxK4TuoqVQgPwHxGXta3GZOWjZbI3Ccsiys4YEI3aKA7XW6ztNPZHDqUJt+UpHkEM09SSo/Mti9gf7WPRzHf3wO8oK41nBSV2z+KFp/oU3E8u/tJw5u9+k EwAZOqbc 1Jmj69Cayw0GADMfNs+nnfm/vm/1p5FTHgK4C2I6uCJCj2eU3bQgr97ZHm201rMWflNW/0eoESgNevXAJ/q6/tWTJI83HRbHybnuPvp3XZ4ins7vWyDN1Jwf0ZwyKcrPbAPbgopBKFxegaFRoNo3dhTNMKSS3Wk3cWh0YUiR4GWcdtYNBwsbQc3NR023vj8j4SfeDhKjr5DdZLikUOC5v/NoK4Ltzyer21QF01ynvKLQDuyWs4GYdd0eP8+QxggUCMwq/gIh6HGn+eAdxXH/z5mJoOqLkGKT/NGlOOCBBN0MxFdRCjTqboyxhSBfMCbLcyft4pBd0/1IGUwkNVgabSbAVIuRuTPl+VMs5W6HDQmmZUhko+21auZR3WAj7OmLECpNpNO+ScdySqDBGmhy4PC+2MsPRm6pDpWxwIv88ge0K1SeFY6HcLLQV/uvXG/Vnl/iSZuZB2aU/7h2DOFg8MldsFUr8l+NSb0+iqlf3eecsYu3fII9afoiOAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 03:56PM +0200, Andrey Konovalov wrote: ... > Could you move this to the section that describes the kasan.fault > flag? This seems more consistent. Like this? diff --git a/Documentation/dev-tools/kasan.rst b/Documentation/dev-tools/kasan.rst index 7f37a46af574..f4acf9c2e90f 100644 --- a/Documentation/dev-tools/kasan.rst +++ b/Documentation/dev-tools/kasan.rst @@ -110,7 +110,9 @@ parameter can be used to control panic and reporting behaviour: - ``kasan.fault=report``, ``=panic``, or ``=panic_on_write`` controls whether to only print a KASAN report, panic the kernel, or panic the kernel on invalid writes only (default: ``report``). The panic happens even if - ``kasan_multi_shot`` is enabled. + ``kasan_multi_shot`` is enabled. Note that when using asynchronous mode of + Hardware Tag-Based KASAN, ``kasan.fault=panic_on_write`` always panics on + asynchronously checked accesses (including reads). Software and Hardware Tag-Based KASAN modes (see the section about various modes below) support altering stack trace collection behavior: