From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9396EB64DB for ; Tue, 20 Jun 2023 14:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 163A58D0005; Tue, 20 Jun 2023 10:41:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 114688D0001; Tue, 20 Jun 2023 10:41:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF5A18D0005; Tue, 20 Jun 2023 10:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DF0528D0001 for ; Tue, 20 Jun 2023 10:41:14 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 936811A1129 for ; Tue, 20 Jun 2023 14:41:14 +0000 (UTC) X-FDA: 80923388868.29.AB1EDC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 48F7F20017 for ; Tue, 20 Jun 2023 14:41:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aHkcOAu2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687272072; a=rsa-sha256; cv=none; b=SJ+rdLI2nNtdNS7t0/pbJf61Ekcy9hY1YI/h112fSxvpMfVQ1w0ZUtF89MiWlb7dMNqozg R2DZkMt3bcfZLX6ZqzzFjAweP83cmpXQ+aonYp95QIll5wT6D/VDZnX9zoT21QI3Vy9Lwz lSSf9s0yQkkJg3VTJzeuXCYZNaA+Td8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aHkcOAu2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687272072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WB8Vx98WvIjwMvhjoGyjOvYXmiTaWo9Rv7qQZH0kMH0=; b=6c/4gTPX1cexSW1txUYwn23UCB+4ofPfgjrz6MjHSuJm8fC3DH8h359F+PoBJtaMdMjz2U CG20OorCNkIvfV1qo4MxhGrJzYNKplILA8MpxtTFj+GJM1ckZYtP7LAgJTMcptgh0SVSGT mDmARYmWRdf0k3nfr3EszJIe8ZGpGiA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687272071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WB8Vx98WvIjwMvhjoGyjOvYXmiTaWo9Rv7qQZH0kMH0=; b=aHkcOAu2M1FdLMOyzZBD8+c8+vk/MH9qbrpD75GbgDev4qorOQ3PG2Xw9YKoMmtiizBbL3 f2b206n97orInV+5rP4XzQRXCPPqdpRcZEYZE8UhrY/C63Yo09OcWdzrP6QOf8r/1ZwPBd phKxEPYTrl5p2dFzXRJ8atxv0YFslkw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-wDrl9HLhMpGa3IDNk3es1g-1; Tue, 20 Jun 2023 10:41:05 -0400 X-MC-Unique: wDrl9HLhMpGa3IDNk3es1g-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-631e9a9e92bso3225826d6.1 for ; Tue, 20 Jun 2023 07:40:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687272059; x=1689864059; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WB8Vx98WvIjwMvhjoGyjOvYXmiTaWo9Rv7qQZH0kMH0=; b=B9C7IxfrsQ5m09ouzQ1xzXTHfRXwxqZlEwOiz0up2KNL5mzZVoTsNJEGOuTB+RTA+4 RqniD9DAxctul94C3ZiukbXAykU6oa+/ORB0UPToNSx/pFOYXCZvfjfWa9ZJX/KetvAz yiuhruRnz94eqd43ytKIFkO82MVb6+NddySRYDuSuX8OMJFSJKgS7tNcv77sex6d/fuu oUSLKk/Fo1Wc360LZJIN84RRdHi26eREhehFcpR1V3krL4DE5oem4lzBFYc3CSpuJtb/ Tsi9xTTEzhthBTVkROKNktQ1gCssN+oW8iL7O75saBcf4tFMz1OjyRFoTjehbCGQqfpg epfQ== X-Gm-Message-State: AC+VfDziqlIZwO0rHsePmmUGaMSvtskxZgIS0gorLbPA9vleJTZc3VG1 1b4PWQ8MksbU3VJ2QPAizBvaYTuNGtmkRBdZwIxQ9vivH/Tmpn2bCAt9V4qbJGHrCRbD4CwQo/+ YBCS2SOtgiRE= X-Received: by 2002:a05:6214:4111:b0:62a:cc88:1d44 with SMTP id kc17-20020a056214411100b0062acc881d44mr15480072qvb.4.1687272058927; Tue, 20 Jun 2023 07:40:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5MQslOGdENtUV83YCcbGTXm2X2WKuRXg/EMIbpWXEy8JVVimj/zHdBOW33duoyJqF+au08aA== X-Received: by 2002:a05:6214:4111:b0:62a:cc88:1d44 with SMTP id kc17-20020a056214411100b0062acc881d44mr15480045qvb.4.1687272058612; Tue, 20 Jun 2023 07:40:58 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id d5-20020ad450a5000000b0062ffcda34c6sm1267657qvq.137.2023.06.20.07.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 07:40:58 -0700 (PDT) Date: Tue, 20 Jun 2023 10:40:56 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 3/7] mm/hugetlb: Add page_mask for hugetlb_follow_page_mask() Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-4-peterx@redhat.com> <24f4a22e-7d3b-544b-320f-bba5abb92285@redhat.com> MIME-Version: 1.0 In-Reply-To: <24f4a22e-7d3b-544b-320f-bba5abb92285@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 48F7F20017 X-Stat-Signature: 7unyq1umqa8ojafspxuqpbi7jy44cini X-HE-Tag: 1687272072-261605 X-HE-Meta: U2FsdGVkX1+Uvk63lu5intBoP5BLk7nMM2r2YdBLie4OZ6SCNYJ8Lo0gPVtXeDXNNPA6Komh/6sVj9dqZlGrGdG4pBJEWXqhgV4qV1DMBpx/fIo6CBZ2cDtpA35Dg6/vhC4w7QLgjRalP86JzhwZPWUktnbwJKk1q2xriPBoc8X5xoA4ItWjv4aj/R93jdVrABo7BV5vozT0k4KxhoEfLlbr76micNCxd+Tm6RJGexEHopWF5d3eRHeUifGasFX2ANr2X3yxpH5ntOnirMi93ykNG3EswJlzjxuFOXKYUmAJFNrKRCF7wWbsNXo3TSnZmXVwJsiEFSLhbJTHYB92tP0b+Ig97EGYHa6+UQKVohWzo2EuTbM0UapZ2KZMJAkfCJ3SkBTs79sDiZaPb78+twJI27Qyxx+fPF++YKnJpgK8KriLxhMY78a4uMp5JFxWqzkih+Kkoz3uiV3TEE5GQVR1nTMwBmXWRn76+Gq42lNX3Y6jmGlN/VDrKqoyTg/G4m2wSLv8McRJ9/aiyYsavdm77NSkMuZ2bAcWKOYV0YvJ2BZu06RvpP/7kltMmZSDRux7Q0SZwPrmHkXfg8ZXsCDijycNMXJwvBsDqXnr6Br6AUO+yc+dxY/mTt612xt/9D0IzxFUP2nLXtSP/ZJ36Da7IYPtWq+KKqlFDjrlIr2Xl8dHj4B6BM3RCTAHUbyRkpnakgidDu4GyMCSejt12z9LPJiU7aq6sI4ZqrLs3sJwiSaM/OvdQQAmmYIiiAL7tQ7kMA0go4GH8kIbTQRK9bzyBcE1wH32qm3xr49jgXD6g6+H2jr//WyRi24EHIQ2ZW5v2IA6rvhq3Te/buQ50MNoMvmP1BvliH0Oc939MUaHIAHld6OOdrETeLnCwLfi0cKbulMrjuSEFhfGf9t/mpuOWDvOSJ/ZUm5MDnbpl/XYDbtB0RgWq87Ekomsapb9tbcjH7KIwd/udqH9e1g ZVtoZpeU r03XRDEoXiLHcM/YVIFOslAaYdfFKiMQDSogphRO3YbDrwr0eoJThgTfg/RvQJgrLzBVm8ii+qlxYSfNi/UJZ/9KApfoZSCuQOsWvx7TO8JZ5Korn8vcN5K1xuJsIcdZIS/ArLfb56KjOMYTq8dvAWuARh83klC2snQy4jjugjvuEANkVo2dWcNxxZyhMiWXPUiVr/fWiLPCei8cQaqltKX6wQP+L7+KDhuMmUoEEknacPXqoNLQMe6n88xJC5KAnJqXAv68dYieScj9yP/ogryslXe2gmpp5uxhafn0iK7iZf62QcuEugQWWisb5ekFbSnqoxZbV3h8xu/OtMQbSfZV3Q2qtHela1T01gLMlXe8pdoxlCtQN94qI+Eoe+q/bXQp4zmcVAktLjS+/kdpXMruatT5SdwGTFQdx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 09:01:23AM +0200, David Hildenbrand wrote: > On 19.06.23 23:43, Peter Xu wrote: > > On Tue, Jun 13, 2023 at 05:53:42PM -0400, Peter Xu wrote: > > > @@ -6506,6 +6507,7 @@ struct page *hugetlb_follow_page_mask(struct vm_area_struct *vma, > > > * because we hold the ptl lock and have verified pte_present(). > > > */ > > > WARN_ON_ONCE(try_grab_page(page, flags)); > > > + *page_mask = huge_page_mask(h); > > > > Sorry, I was wrong this line. It should be: > > > > *page_mask = ~huge_page_mask(h) >> PAGE_SHIFT; > > > > That's ... surprising. It feels like either page_mask or huge_page_mask() > has a misleading name .... > > h->mask = ~(huge_page_size(h) - 1); > > > For PMDs, we do > > ctx->page_mask = HPAGE_PMD_NR - 1; > > > Maybe > > *page_mask = PHYS_PFN(huge_page_size(h)) - 1; > > Would be clearer. Since I just posted a new version.. I'll see whether I should get that cleaned up in a new one. > > I guess "page_mask" should actually be "pfn_mask" ... but the meaning > regarding PAGE_MASK are still inverted ... Yes, pfn_mask can be at least slightly better. I can add a patch to rename it, or we can also do it on top as cleanups. Thanks, -- Peter Xu