From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759B0EB64D8 for ; Tue, 20 Jun 2023 03:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6DAA8D0002; Mon, 19 Jun 2023 23:22:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1DD88D0001; Mon, 19 Jun 2023 23:22:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABF168D0002; Mon, 19 Jun 2023 23:22:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 990438D0001 for ; Mon, 19 Jun 2023 23:22:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 515CA16019B for ; Tue, 20 Jun 2023 03:22:24 +0000 (UTC) X-FDA: 80921678208.16.5FFD286 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id E5B08180009 for ; Tue, 20 Jun 2023 03:22:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MXJ2F2J0; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687231342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wWWpWHiSoFGWMQrh08hxM5ySB17WGBX3nzE9Kqfr2V8=; b=MEIg1HSLo6NNMaWpTJu5ZGlcZ47ahvi5aXxEotJrHAeE01TNKwi6F61lai0O/ogn9Au2qL ZO+qJTbGrajSJkUPYugsAuPUYEmXBtTx6YtMTGiDOs/E0uW0iMy0foZUrRhOz5QYB8CClF s3zILHQotiDGukfYQz6FbZr47O6ueAA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MXJ2F2J0; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687231342; a=rsa-sha256; cv=none; b=W6JmIvR9U+wTDiYte3E1ojisKopKfUhp2S3CX2NmJlvNhKD2AUN9WBJGP2PaKPg8nM+wY6 98XgrGtI9zDUmJqyikCEkEDjkP5TyBVqIH+XS/cqptQ8bsQdtjBxc6WqRN7xLa+8TKgfQ0 dzRBxUEVrlJw97CSGXOQioUOsyBOgmQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wWWpWHiSoFGWMQrh08hxM5ySB17WGBX3nzE9Kqfr2V8=; b=MXJ2F2J0It8QPHRB6ToKNVEwSq lj10/CbxtHFZzI9n5eWpQyn0Jj5XsUiASD0jrVC5UXyN/5PxbHFV0C+OyeOYBFL0rswZMKTodPcQq QCPAEzyt6NQa4g5YxJvzJuzyqCcZEwyRFcFNHVIfZnHIF0zWvgeGsv/+B+TdgDXqwf/R5chFvFNOr wam0y7d0HnYg2uWMlMFqgQy19axT9geowj3NVihTyf4+btYyDqumHMFmBPChgsoWbiY2FP7vAM219 SCCUe1kuqmEIGuQhY5eSgEvZZa4mrskhnGY3HCZsxAoWctFwmWVfFvO6WpSL6mfjtIbc0cRNw84w7 KpFBDa9Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qBRwc-00CapV-2W; Tue, 20 Jun 2023 03:22:14 +0000 Date: Tue, 20 Jun 2023 04:22:14 +0100 From: Matthew Wilcox To: Yin Fengwei Cc: linux-mm@kvack.org, akpm@linux-foundation.org, kirill@shutemov.name, yuzhao@google.com, ryan.roberts@arm.com, ying.huang@intel.com Subject: Re: [PATCH v3 2/2] lru: allow large batched add large folio to lru list Message-ID: References: <20230429082759.1600796-1-fengwei.yin@intel.com> <20230429082759.1600796-3-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230429082759.1600796-3-fengwei.yin@intel.com> X-Rspamd-Queue-Id: E5B08180009 X-Rspam-User: X-Stat-Signature: di584im8tz7jn73cwuzx4k5g3dgt1spx X-Rspamd-Server: rspam01 X-HE-Tag: 1687231341-516661 X-HE-Meta: U2FsdGVkX1/Nd1Xg0l9pzP3DM4RreYgh1s3hxrpxSG63w1vtn3b6BPBBAyqCeMhqqzxUXwtXMBZABp3hYONZBEyBacKSpIXEsow21KyQ/iSEg6QNVsuDlkOciF/mKg3YUJeNERHm6EK2gvFjOrjkONpuThd93pkx2UhFE+HuRNo03nr3wnqh29IEf1LAd3hFedm7JtagYqxrJaOZTwb2mEJ3gh2eTj/yqEvozkX6YkcaTO6/XwUeLlazwupEsA1R0G3Yqm9WSN7/EIwEio4qO5kdvIFGLPDSbnMv3R2qisa9dkfy8yXzRLF0bcPJhZxKVZlcvaaSEmNV+AZRO9tRTVgcPGCtSDgf/7B/FRMS9ZDixr6zJVzXRhYoyUemQZP0kFM8imnv7z6DMq/SkP1KoqM5r936XUyR6iqccexL6SEWSw+dIY04MOm0iOTfPUjLkQ01a3LHPWkijlM0tu/3NByPUkY44gj1DN6Q1IcV9c6dVhDfdt7OU5yIFaPAsRn6aqKhhCbIqIsFuVOqa4Tlpi2lrX6M1bdepRS3PVx8A/+vRreA7I/dQ1BRP1Drf39GUQlMNbcp9RYBULJbwVhRWq3XvgdZ4JhNJWFTzdWcbTpY5DjVVJCA1R46jCMW6qeLudCum8qDac2CNt1OEmAL+TGjp3KSSHKldesXlkw9Q8CJf6se2VFAWNKU8ZEp9LO+s1plAD3TRiI46Efj0e/ypAmJHVXsrMBT5hQ+qPcW7e1qh5LzECKJufml0EBeLEj4eb7pfhvXx2QCiBt51aV9ksEhSQl+uPaiOu96lgC81pEQT66jK3Q/3XnnKXIBe388BkBKEbBL0EESd9qMBShSHPmucV+LsGZSRQDZU2hXvC925/QiO9KHa6ahB0Wd/C508KqwsIYiPIWFf2vMKB2FCHe6J8SsOUMn+HGrJrg0Bnz7YrrFMhEmPKwFWl3ZaflKGMkIjH7yFzjQ/eNeUPq d36XEre2 uPo4LNv+O5naobeHxbIpntVq12GUTf2fL5yRYM+j693rYy7H8UvpYLEBT36rCnSxn1/khjvjMXp4+psnhW8UTYT9+ZoHo7aN+pO4xAIp0RGW3y0afdiFHv7lWwfG/uNCDonRpPXg1/ixSRmw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 29, 2023 at 04:27:59PM +0800, Yin Fengwei wrote: > diff --git a/mm/swap.c b/mm/swap.c > index 57cb01b042f6..0f8554aeb338 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -228,8 +228,7 @@ static void folio_batch_move_lru(struct folio_batch *fbatch, move_fn_t move_fn) > static void folio_batch_add_and_move(struct folio_batch *fbatch, > struct folio *folio, move_fn_t move_fn) > { > - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) && > - !lru_cache_disabled()) > + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled()) > return; > folio_batch_move_lru(fbatch, move_fn); > } What if all you do is: - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) && - !lru_cache_disabled()) + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled()) How does that perform?