From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED48DEB64DA for ; Mon, 19 Jun 2023 21:43:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEE238D0002; Mon, 19 Jun 2023 17:43:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9E368D0001; Mon, 19 Jun 2023 17:43:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B653F8D0002; Mon, 19 Jun 2023 17:43:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A6B5B8D0001 for ; Mon, 19 Jun 2023 17:43:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 66406120318 for ; Mon, 19 Jun 2023 21:43:55 +0000 (UTC) X-FDA: 80920825230.18.907583D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4DC8F40016 for ; Mon, 19 Jun 2023 21:43:53 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qn2UC0RR; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687211033; a=rsa-sha256; cv=none; b=l497Byol1Czkh0Y+cLEwQVsDa8HRIJv0f0ii7PNinFFrXYoUWTwYdbg38yu+J5BAXlC0mH jcPLcgafHoC/AaisrZt1cae6KBQIStyU209xdKT6aEE2s7vIglhaX+vKP5LYnRYuHJK0es zByPJRrj4CPyLiYyRXOdWpbGmubGolk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qn2UC0RR; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687211033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RLoob+M/nR1AIL2pYIs2Zh5ySzQr5e7siB01cUwFeGY=; b=Xm1wfOopxrWE14Z13F7E7s1QaEWBdnR/Ir+w6XHUe4xvKO+OgV0s7gpohkVEoHgevqKcHt PJIk/QGnRBBbTlhkJjmegahRjnUptH4qr+wrpAmKzesFakFzILAD0zsRLE012qDL9/HGHZ G2rkg4lF3SJBXrmi3lxuCVc5xspxxqY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687211032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RLoob+M/nR1AIL2pYIs2Zh5ySzQr5e7siB01cUwFeGY=; b=Qn2UC0RRo8BmxharEwDTT/aLnujW7qZyo4P4S0izSZcHMgnjoPDjQlLWV3JNBwBXFKXOBM 5zt+JdfN5WTzvj/BvD+TLp1+/+IAe0jnscaoI1g31FU3L17a02z6G2INXNVDgzOGpbXtCD TTNdQuh0oEUIkZC56rZseFeZ7/G5rXw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-i34B-TS4O7CqmkdH0HFQjA-1; Mon, 19 Jun 2023 17:43:51 -0400 X-MC-Unique: i34B-TS4O7CqmkdH0HFQjA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-62ffa1214edso8231316d6.0 for ; Mon, 19 Jun 2023 14:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687211030; x=1689803030; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RLoob+M/nR1AIL2pYIs2Zh5ySzQr5e7siB01cUwFeGY=; b=j6NWonSTycSYNVXT+qhSBBIdOW3FMh+HwFT1ohYtt9mF10F04dfpC8ddaj/yFWUsL5 aFLM3Av+bDgfgetHfs5+b4oQ0GpHrrYW2Ke/t4sqi4SbVLyJ21FT03OihgRBnNTiZ1ob B5qcvG10bUeDlq9SyO9U/jSTXi8A+4zPc1h+du3YkyluE1O3D75xqh+I/mRcL7Fg5ULT 7sLBNKWtTwYgC7nfMvUqasGPXsSijKXlrv1eJUBGyFPofVPAnUQaTLY+ARQLLSBr4dQN 6t6ogyUy58P3TAuMETlkhT59JgA5BjcJm0+2fs4fZyv/SVhpHjq1LTm9fafR0PBVVDfu clYQ== X-Gm-Message-State: AC+VfDzWEyPUBS0Bgfw31F8jTEeczHeSKiF2mb7P0491pIx6ahhGg5+k AtS+HmOmA+q7Zwz/kLGFGry5/C5hqteJdF4px+v/0kEoMd9oLFvACLzujhB2bOO//Tr47fVqwi+ nHsb2Ur7NfH0= X-Received: by 2002:a05:6214:27eb:b0:616:870c:96b8 with SMTP id jt11-20020a05621427eb00b00616870c96b8mr13057096qvb.3.1687211030663; Mon, 19 Jun 2023 14:43:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7nTJLtt5TUY5GP0l3LO0MdhzE5hTrhflyMc4sxVPF63LR69+bfy2e06TzUrA2twyZRV0FFnA== X-Received: by 2002:a05:6214:27eb:b0:616:870c:96b8 with SMTP id jt11-20020a05621427eb00b00616870c96b8mr13057083qvb.3.1687211030448; Mon, 19 Jun 2023 14:43:50 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id w1-20020a0ca801000000b006301bae200bsm429214qva.15.2023.06.19.14.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 14:43:49 -0700 (PDT) Date: Mon, 19 Jun 2023 17:43:48 -0400 From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , David Hildenbrand , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 3/7] mm/hugetlb: Add page_mask for hugetlb_follow_page_mask() Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-4-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230613215346.1022773-4-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4DC8F40016 X-Stat-Signature: xg3aomxyeurc1ognoqm5onhf4n77qyne X-Rspam-User: X-HE-Tag: 1687211033-579094 X-HE-Meta: U2FsdGVkX19pC5nQMB2WLdhymZ2gkzehJLt2spimCeT1JjSe+aO4e9xCrP4VmK8//ikqbOpZY+J+U2RkuhpoH5OoAozGKO27jlSUIzRPdMNifZKMNl6KCRhSWaiArB9p5V42vXcqU444+X/5LEzf2NmzXUfAyN+OAGGn516mgE+HJdHNJdP4+wzcqJaGWRtR4A4n6hTGH0mWt1jyztEl7eDqR5CBYpAYC8IpJVxpsQgbytUstcyYiQPatAlQDcBxSveWp8sMB9D2OdVEsZzXCAC4pHNeu/9RRksSRlewKRabGptpp+ZxsdUTB2Cop97xaBkTq2o/ywxpWf9mWIT3g0L6287zBr6JKsiDvUO3w9UXvWKbBiSsOn9t2jXrctInmE+KeIisq03cSp5kjVQ1Eu8u9wsNtc9mUns2K32mb/AxmMQjGLwh/krZjEmIRWesPpJbf637zCQT4I34BWwmIJgx/hxmapa0uoard+Qik83nKyLgZGDX7vDQlEPr5iq0QuEQ9Sikebohcw3lmKDSYz5gSQtlEQ0xpU4FXBjWK3jZD0k4+Ccw01o+7GmbcIsT8NgWl++V+uO8Ys9n8X4NyPAxiWwQWspXULoVqhBzU4osUKEOQ9Wm9WGzS62JTCHsOV467UDUR/B0AIPt8RHdcuKKJVcX6R7Q9kRoJ7iz8BaQVKQN6SowOMGWuDJpM8vP4ZoDu3W0RUFd0tHDQl3EBYS+JB/78mB6MeEVWKF2sNc5UNqsx7ooVBbL0oEGefgGFnPfqJalAhgl2o7rlzWLVZeJizqsihZC3ULNoXnCTEnH3LmRGbhw3kMerx4vB4rZxizvg+5ZmGf+kQOeLGnEj1bejvPewQk5Rj/KQmW5GYZrpaSKwkRCgq7GyEif/79nWlu/zcUtxqAdzDV/k2u7cF9cVfKQMmRVJvrpnjR7obr/ytkBVmVdY1lxl0Eg0G08KFcELUOhTn04U135ui5 2SfOZ9Jg z331ZcBt7qJ6HGwTWB8aha/DSdo2rPdixH+45PQOwRlNAVk5XANqrhybgnLOMOMyd0iZyt1o/7kQnrR+tk8q3jOg3dNlq/FtLkigkXeD2Nli/xZPUbWiCpBhKCVWqWQ2EKlB37gilqtI93xR/cADTdThrPIQyS8OsNHFO5LdId9vwH2gZBzWtBOLjxB+ulWfeuDhMRtRJNIGeMea7gDCIl/zlePvi8cjtVqQX1prr+yXNFZyKEM0sczeQSWBDVJ6+kyX22IktsTYUcxGVH81tt+VqVLn0XWB8JZphwzGooHc35Kem2To7dmu/BH3gxYKp7kUMjubSV4kON0pV5edflSmQiC1ZPYlbsDRhkwwuFaJAIMXBEKjUV6fivzau96isjuzlHgjmiYRpbKnyfRTl119kwSnczGSLLYysROKwKGHRKWNrCJHEe4ySZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 13, 2023 at 05:53:42PM -0400, Peter Xu wrote: > @@ -6506,6 +6507,7 @@ struct page *hugetlb_follow_page_mask(struct vm_area_struct *vma, > * because we hold the ptl lock and have verified pte_present(). > */ > WARN_ON_ONCE(try_grab_page(page, flags)); > + *page_mask = huge_page_mask(h); Sorry, I was wrong this line. It should be: *page_mask = ~huge_page_mask(h) >> PAGE_SHIFT; This can be exposed if we bypass fast-gup and also specify pin npages>1. Probably overlooked in my initial round and I'd guess fast-gup just all succeeded there.. I'll temporarily drop the R-bs for this patch, so reviewers can have another closer look in this one. -- Peter Xu