From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710E0EB64D9 for ; Mon, 19 Jun 2023 19:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D92438D0002; Mon, 19 Jun 2023 15:41:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D411C8D0001; Mon, 19 Jun 2023 15:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C09338D0002; Mon, 19 Jun 2023 15:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B373A8D0001 for ; Mon, 19 Jun 2023 15:41:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 85EE0AFDE5 for ; Mon, 19 Jun 2023 19:41:27 +0000 (UTC) X-FDA: 80920516614.26.E80403B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 6F7D0180010 for ; Mon, 19 Jun 2023 19:41:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CZSIYjYI; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687203685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKoKC0b+LCjcSl2EVWbdFRgACSV8gQthNjDiIthburU=; b=aiFwQiHrTsIjueH/5mX6q6bGoTJyDZtSbX8uBl/9GxrPFP2yHcRzc3pO78OZJKA2KpZW37 KeLQkwXziuciS67ILQ+6kGYA1PGD+RxI3vE1WsqP8GPbzt0Mq1I3wFhJ6KsTcBqfDyasQa bmYQlLycAAG/z4aPmmFIAo04PUgVRQg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CZSIYjYI; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687203685; a=rsa-sha256; cv=none; b=e5HLNgbaasqFjt9IeEOLL/kEq4Tm0/SUODcjYfRTaqVCBkXfBz4UvFJJM4b79wOfkj2ml8 ktoWkCmNmJ6ALAadGvAhfpr6GvkR+PufiC5luiGGD5Rj3SRwbHZUC7dZBKS5SEpRJHSld8 JU/82ewwVLCUwpgDv+T0RhHYXaK+phA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687203684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NKoKC0b+LCjcSl2EVWbdFRgACSV8gQthNjDiIthburU=; b=CZSIYjYILznvOaWyV7XdNytwygJU4wNDSfKMIPqOGiM6004pr+nfpUDzSZlZUzZed22iO6 Iydu++cWIx8gyTWTPWhsgwU/FRZU/ITXOlyT6FpwcZ+fjSSxWCSm6pf6KRCQtSLEM0xvyI Aa6RhE7NYg7B3UZ7AxYqiFYyNaz62WI= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-aT_1v2WoMO2UEs5TmADquQ-1; Mon, 19 Jun 2023 15:41:23 -0400 X-MC-Unique: aT_1v2WoMO2UEs5TmADquQ-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3fdda8e7167so6383691cf.1 for ; Mon, 19 Jun 2023 12:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687203683; x=1689795683; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NKoKC0b+LCjcSl2EVWbdFRgACSV8gQthNjDiIthburU=; b=bYpKRb70QOzkTRxm8irVwaKAmuouNdQqd9P2HYyDcI5vM5CaKGXkAD9LgewqP1Nohq /Ju6EAciJbE3E0TuFMa33gkfCeuhE+pvPdjCWORqJFtbsybtYCQRXiQp+gaHWWypbwkZ A8yKeEp0lkbXkfNgjAxqBGCTxIWTbjiURuu+EIs5pvOeCf+Y5PuShzkwNQjiVpJI4TrH GrXJIdWRz9hBcWxjP/EpGGLdZzLxQVMktuJVpPbL5pPSBFP1nhpaRmEP3qREF58vbax4 wNfnDADaf1e6jTbIqIrU8+HlL7PAtVqxfMC9nUzlhXxx8vbcIJHVhepUUCp9whkM7oML m4fQ== X-Gm-Message-State: AC+VfDwwpvKrIi08MeCKoG9ieYY7HJiZG61f+tfi9jribZizxIYdRwLE 5JBmD7w6waJaILBNY6If4T9LS6ThN/M2xoQLcVDL5FUP92IoJ6EQ6gji3MUbVLk75FomXWImhfR Jzdbrd4T9X84= X-Received: by 2002:ac8:5842:0:b0:3f9:ab2c:8895 with SMTP id h2-20020ac85842000000b003f9ab2c8895mr14600259qth.3.1687203682941; Mon, 19 Jun 2023 12:41:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ZzRjTvhMgkKAzruDtjbgbAepbDf8LrZ+k0sJu+iGWmbjsg+ceTUlHogXIsQHR6jn4iNlczA== X-Received: by 2002:ac8:5842:0:b0:3f9:ab2c:8895 with SMTP id h2-20020ac85842000000b003f9ab2c8895mr14600233qth.3.1687203682664; Mon, 19 Jun 2023 12:41:22 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id g4-20020ac84684000000b003ef1586721dsm227166qto.26.2023.06.19.12.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 12:41:22 -0700 (PDT) Date: Mon, 19 Jun 2023 15:41:20 -0400 From: Peter Xu To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , David Hildenbrand , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 7/7] mm/gup: Retire follow_hugetlb_page() Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-8-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 6F7D0180010 X-Rspam-User: X-Stat-Signature: moxgw6qezgbmaftriatqx6pk7oiekz9k X-Rspamd-Server: rspam01 X-HE-Tag: 1687203685-598947 X-HE-Meta: U2FsdGVkX19GhlKI2IWsiI2OlaGjYCN3A9FqmIayt6/NHK2lV5dldWcTQJz/kNyZZPC1/9J5clfQxTZqQ2wM4LdeijyEJS3NDKklRq4o3oOvEJPuD1WDPas8gjWUobO4UkyrZNw3myDfD73JVl+JTTU5UVuDdgg5QoZOCIQSkJ3RWhbqJtYJXCvKPOYcftB6uZRNu/cEeUut4hpFFciKFKn2w+ZLPNA2J8ZrmBvmM1wJ8D3K5WZdrzKBQcuT20PMqUjVX1cA4t4beEp5uMpdzcIOG7SvrvvAglmoXlTMW8xTbdDp8VZ2hbjARaovOa7rf5qdDnkYGPjt5n6AOg2N21fQJ8OLwyWSIw51vPbwN/SnUZnnARRZuzwNJZOKbrDyqTsSD9IRa7/95SQB3dcgZk7WGcy9uY42FiLFQSX8KjH/lCaRV1hKJCAkytiZtX+LlKq3F3zLn9YZ+8BCV7cKSEf4FJxS71psANH3Tg+YABegH5HvZlEN6uH/sDuQ4c9tYQhIPOMwZn0Ke7WRqIA/RC5Gv/rRt+eee3rbajjR686niZSIfcmLHPkV99yiWstcWyi3tc78XoLyBLzr4mgOMqGcZ2ICPyPStkBkyja3/P5NhXE8eOrYJpJcZe1d/Dj7zkTOvZNd793Qmo7jUPHihAT5TXY5B1aF/JcGvxyHucaeG5D07yGI8UU+wsZDock/8bPD3YYwzeKvB1mYOW4hQvIfydBb8+OxkSvWIM9mnGyqmfPPbCQSXPRu6iolyUK11V6m7GxcRCPLMR0FazuhAXoDV/BmADfZb/pNqeoThW0thC3HhhxImMWkWRT6R+UDMvkE4HD+BNIV0FwQe9Cgu2iSnLPj1k7j1AgAwQukjsqJxvOjGUUm1dAp5Ibi47bjLuoNUx7osgBoUY6T4JNQtYWeF5q2tIyjZoS7Qbts+khhp9PBGc6yffJbdk5bMh2+X7tVddyEBQEHO5mEgx+ fe/TKmB6 EMYbpMbLB+fwaw6RshQfuMMxf+lISqi/8vh6qRuyUP01EowM+vArXb0Iw4FhCF1gjjQBXYd7iS1SIgfCNFUVxvuM239IRrXeRG/w+Fby2uGxGYgcTjdiBdbIloocoaxEsDRKliIyzmBfuC2vpuO2TuWXkQwB3VNGfUuSwwIOs6cJPQkDU+atTCHqOngMtcvWTIcT4iC0UOW/Tv3C9dXW5tu83SE9XY2g8wsDU35UDO3bGadqp/mZpmfvMWWfHZkjrXE4ZPnGjid8E7KoS1YCZzCfdThI8CwATcYYfOVnTJW84i2lOw3sGWDz4WmRHHwmPRPMk2MUyxJ3DZ/FV1/N0ZPWl3a4BErBRNmdIqQFFHT/vj0G7shDL506Vj6U2YmBzqLXMHVi/8xu5pId0bKbFNhjz6CJhXSWRDx5Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 17, 2023 at 09:40:41PM +0100, Lorenzo Stoakes wrote: > On Tue, Jun 13, 2023 at 05:53:46PM -0400, Peter Xu wrote: > > Now __get_user_pages() should be well prepared to handle thp completely, > > as long as hugetlb gup requests even without the hugetlb's special path. > > > > Time to retire follow_hugetlb_page(). > > Nit, but there's a couple left over references to this function in comments > in fs/userfaultfd.c and mm/hugetlb.c. Indeed, let me touch those too when respin. > Absolutely wonderful to see such delightful code deletion :) > > I haven't really dug into the huge page side of this in great detail, so I > can't give a meaningful tag, but I can certainly appreciate the code you're > removing here! Yeah, hopefully it'll make the code also cleaner. Thanks a lot, -- Peter Xu