From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FBEEB64D9 for ; Mon, 19 Jun 2023 13:12:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A3168D0002; Mon, 19 Jun 2023 09:12:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12D7E8D0001; Mon, 19 Jun 2023 09:12:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0F948D0002; Mon, 19 Jun 2023 09:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E0B3A8D0001 for ; Mon, 19 Jun 2023 09:12:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D3DBA065A for ; Mon, 19 Jun 2023 13:12:53 +0000 (UTC) X-FDA: 80919537426.30.934841B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id 951A6A0015 for ; Mon, 19 Jun 2023 13:12:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PVLE2oqZ; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687180371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aQmFVaQuAwWgIZ+l8dIjyNcxs23FYGNdPQCulAHqOAo=; b=EVtxcN64hSVrFbYpK+XFjxK/8Rr9avqUpwxR++0Z8CmnxXQx4aQg0N8P9syJ17Hqdgu0uS Uf9b/4WlkQT3oG0UEBz63ux43Tu88xaAEckuErj1ZEYs9zEsgbR27HoGtmcG7IqL/QeXe4 /0Iqdlcu59YqY4TxCWi1I63BIL5vcZc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687180371; a=rsa-sha256; cv=none; b=0Iq+R7M4Ptw4K68cbuWZ5zn8l/l9mmci/pcQTkDr5QTe65wYDy7bgD4YFvReuXIRVEGdQe m+IA9IKbUG3WjuzK8g0Hh+5pSCBx1iDWhDKRUw93Ige3j3tWWXj5BiOJ1ErEUqfcqpwg+N +zKZKWLrnFmsncyslGIBkoel/+Psq2c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=PVLE2oqZ; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 53C40218EA; Mon, 19 Jun 2023 13:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1687180370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aQmFVaQuAwWgIZ+l8dIjyNcxs23FYGNdPQCulAHqOAo=; b=PVLE2oqZFPuxokg5tgu/VBGR7MN9qR5XuBvP30AAyZqCTaRhBtwGAdA4DEsfO9MEcJF0uz LH9cF3R7RbTcDI/fRH9uKl/+bqt0crZU9UaQXA3AUBRGh+19Lk8Coc1S0opdVIMcN6g0wU LgYfJ8I+SyyIVB1Jcce96DitLU+1fU4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F334139C2; Mon, 19 Jun 2023 13:12:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qQHiB1JUkGRdBQAAMHmgww (envelope-from ); Mon, 19 Jun 2023 13:12:50 +0000 Date: Mon, 19 Jun 2023 15:12:49 +0200 From: Michal Hocko To: Haifeng Xu Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, roman.gushchin@linux.dev, shakeelb@google.com Subject: Re: [PATCH v2] mm/memcontrol: do not tweak node in mem_cgroup_init() Message-ID: References: <20230619130442.2487-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230619130442.2487-1-haifeng.xu@shopee.com> X-Stat-Signature: 9bomssyd8stantjsghtge1g91rz8x9yu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 951A6A0015 X-Rspam-User: X-HE-Tag: 1687180371-842521 X-HE-Meta: U2FsdGVkX1/I8+wfbXo3l/Bd5hFGxMTYYAgP4Xr0CmbP8Vls85VzONIYDOMPxJ4cXF2Hjjj5dy9b8ks/tHGWNNBAuraQl/odo6MgmcidDfjtLquyft/FQhmf81b9Tg2qsGi+Aiqy2gHoS61s7CtUIyhUeIp0bD+nXkTFjNsxvxwXI99/VfDpfsSoG3uhVoY77At/l1wo160VvSc0dUcwI+XhU3P9A4n6nxuPkEz/2XwwyLSmRpIn1XAwLGEqPBnxsMAwSS347pIVmiaafIRgq3rVJcFRgTc2ehIY9/7UeZthOJ2IUbQyNPBDnZ2p6Q00uS6upXcPpUCz0yOI8yaV1UVePY7aA5rELvetgj0vSDkBFiSJohjOC06dkKsF4214DzeoSYDbYGPp/vMOvmlUWDRgL3pW6QTvA69okJ/+97R15CiRkJkpRW7pwqcYUsozfNBi1reJeX6kC4Du8HrKpsoSDO17cMudf77BmlbiD1uYLWuqTPDxzuBZhg3ylQ7Ymr+GA8o0kh9KGjAyqK3wPoqyG18TWMaDGWNs9fuvfA76J9iGj2vobdU4DOfUQ4U8IQEvjF9qmHP1qZSaVVjQotA24RT7PxlZ0k7N8WMVCx4tVX4CohKm/diqLWWh+c0koRN6DFcRalDas12lbYNvnwb8kgRrkbmGzC3194mlZ7lej6MTnfXhhV9GaWt2erCf9idF62Gx71HcrJugDD34tOBEqp3dxtC/6Gy8ZFlo+W53h93hupulgm/V4KeMMHtiudsB6JHBMnOLvLyh8uicF4JpXcs8APc1y/t/3EIWvUZHNSLfiCVkwQOrA9xNCT5jO5r24lV6qY4gyOhrEDcVzZA/cOd6H9S1/vyON8TV2B4hbuWt73me/CX1TIyReyW4TUMajW+8MzGihNlLL5K+anbThf21xkQooFjT1u7nFbTcZvcOxh/7D3F4c+NUuwHpz81um5pUrOxTjwAwEHC onDk+Zc/ Qkj8UNFX9AxRbAx3L4IcrW0TkE05ZIJ+4MJnPK8PjzjTOxQPJCcXi2ZpQMGszLDmNCqcCpcPVzQL3jN02k3QTg+OdoxMtUJAdpJDcN4PN+kY1SJmS9ReCER15sFD8g7x3gRiVNCdzSDq+rh3VV6agx1ce+mn5gr0ljXwdyD3Goj1KhgjBAYu6UivUU1rA8SFn+PadZ9Fr/J6SCm58zF+Nf29XzV9kKagEwtKEU5yK5NE1gZBIdFFACrJj/qR1M4HenEwjwvkeKRffti2wknM8R9lxCS6uMuzDaWcGUmRm6Q3A/jSzg4rc30HtqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 19-06-23 13:04:42, Haifeng Xu wrote: > mem_cgroup_init() request for allocations from each possible node, and > it's used to be a problem because NODE_DATA is not allocated for offline > node. Things have already changed since commit 09f49dca570a9 ("mm: handle > uninitialized numa nodes gracefully"), so it's unnecessary to check for > !node_online nodes here. > > How to test? > > qemu-system-x86_64 \ > -kernel vmlinux \ > -initrd full.rootfs.cpio.gz \ > -append "console=ttyS0,115200 root=/dev/ram0 nokaslr earlyprintk=serial oops=panic panic_on_warn" \ > -drive format=qcow2,file=vm_disk.qcow2,media=disk,if=ide \ > -enable-kvm \ > -cpu host \ > -m 8G,slots=2,maxmem=16G \ > -smp cores=4,threads=1,sockets=2 \ > -object memory-backend-ram,id=mem0,size=4G \ > -object memory-backend-ram,id=mem1,size=4G \ > -numa node,memdev=mem0,cpus=0-3,nodeid=0 \ > -numa node,memdev=mem1,cpus=4-7,nodeid=1 \ > -numa node,nodeid=2 \ > -net nic,model=virtio,macaddr=52:54:00:12:34:58 \ > -net user \ > -nographic \ > -rtc base=localtime \ > -gdb tcp::6000 > > Guest state when booting: > > [ 0.048881] NUMA: Node 0 [mem 0x00000000-0x0009ffff] + [mem 0x00100000-0xbfffffff] -> [mem 0x00000000-0xbfffffff] > [ 0.050489] NUMA: Node 0 [mem 0x00000000-0xbfffffff] + [mem 0x100000000-0x13fffffff] -> [mem 0x00000000-0x13fffffff] > [ 0.052173] NODE_DATA(0) allocated [mem 0x13fffc000-0x13fffffff] > [ 0.053164] NODE_DATA(1) allocated [mem 0x23fffa000-0x23fffdfff] > [ 0.054187] Zone ranges: > [ 0.054587] DMA [mem 0x0000000000001000-0x0000000000ffffff] > [ 0.055551] DMA32 [mem 0x0000000001000000-0x00000000ffffffff] > [ 0.056515] Normal [mem 0x0000000100000000-0x000000023fffffff] > [ 0.057484] Movable zone start for each node > [ 0.058149] Early memory node ranges > [ 0.058705] node 0: [mem 0x0000000000001000-0x000000000009efff] > [ 0.059679] node 0: [mem 0x0000000000100000-0x00000000bffdffff] > [ 0.060659] node 0: [mem 0x0000000100000000-0x000000013fffffff] > [ 0.061649] node 1: [mem 0x0000000140000000-0x000000023fffffff] > [ 0.062638] Initmem setup node 0 [mem 0x0000000000001000-0x000000013fffffff] > [ 0.063745] Initmem setup node 1 [mem 0x0000000140000000-0x000000023fffffff] > [ 0.064855] DMA zone: 158 reserved pages exceeds freesize 0 > [ 0.065746] Initializing node 2 as memoryless > [ 0.066437] Initmem setup node 2 as memoryless > [ 0.067132] DMA zone: 158 reserved pages exceeds freesize 0 > [ 0.068037] On node 0, zone DMA: 1 pages in unavailable ranges > [ 0.068265] On node 0, zone DMA: 97 pages in unavailable ranges > [ 0.124755] On node 0, zone Normal: 32 pages in unavailable ranges > > cat /sys/devices/system/node/online > 0-1 > cat /sys/devices/system/node/possible > 0-2 > > Signed-off-by: Haifeng Xu Acked-by: Michal Hocko Thanks a lo! > --- > v2: > - extend changelog by test steps > --- > mm/memcontrol.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 4b27e245a055..c73c5fb33f65 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7421,8 +7421,7 @@ static int __init mem_cgroup_init(void) > for_each_node(node) { > struct mem_cgroup_tree_per_node *rtpn; > > - rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, > - node_online(node) ? node : NUMA_NO_NODE); > + rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node); > > rtpn->rb_root = RB_ROOT; > rtpn->rb_rightmost = NULL; > -- > 2.25.1 -- Michal Hocko SUSE Labs