Re: [PATCH] memcg: remove unneeded header files

[Michal Hocko <mhocko@suse.com>]

On Sat 17-06-23 15:26:58, Miaohe Lin wrote:
> Remove some unneeded header files. No functional change intended.

Header inclusion cleanups are certainly welcome but it would be much
more preferred to explain why those are not needed. As build test follow
ups show this is much more subtle than it seems.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/memcontrol.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d42742edfeac..a2c82a18745d 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -30,14 +30,10 @@
>  #include <linux/cgroup.h>
>  #include <linux/pagewalk.h>
>  #include <linux/sched/mm.h>
> -#include <linux/shmem_fs.h>
> -#include <linux/hugetlb.h>
>  #include <linux/pagemap.h>
>  #include <linux/vm_event_item.h>
>  #include <linux/smp.h>
>  #include <linux/page-flags.h>
> -#include <linux/backing-dev.h>
> -#include <linux/bit_spinlock.h>
>  #include <linux/rcupdate.h>
>  #include <linux/limits.h>
>  #include <linux/export.h>
> @@ -66,7 +62,6 @@
>  #include <linux/sched/isolation.h>
>  #include "internal.h"
>  #include <net/sock.h>
> -#include <net/ip.h>
>  #include "slab.h"
>  #include "swap.h"
>  
> -- 
> 2.27.0

-- 
Michal Hocko
SUSE Labs