From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5867EB64DA for ; Fri, 30 Jun 2023 21:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CBE58E0054; Fri, 30 Jun 2023 17:39:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17C318E000F; Fri, 30 Jun 2023 17:39:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06BC18E0054; Fri, 30 Jun 2023 17:39:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EADF78E000F for ; Fri, 30 Jun 2023 17:39:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BBED940515 for ; Fri, 30 Jun 2023 21:39:34 +0000 (UTC) X-FDA: 80960731068.11.FCD142F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 9338612000D for ; Fri, 30 Jun 2023 21:39:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Fau6L1/K"; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688161173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wQi8kE1utZmoURCigtdOBC8M6Vwy/ecTHFCV8ZmblqA=; b=XjHQpSI0ICkTIyi8g4hYwFu1R9s9dOl2+r8L4XVIZsRk84zbomCAh9puoSx5G7RZI+nIth ZpB4fxk3hfdWSHsbUoBhEoMwHCRHz0kb1soBgmx5K5uXBZQzZuws8hEM/u/nqYEizR2Lt0 coWFw9FXTByVaBiSZd3U92ztcQFeF64= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Fau6L1/K"; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688161173; a=rsa-sha256; cv=none; b=QcVxGcH8a7vkKRABwsHBtgJ8qy9wazSMsc4apa+/k2eKiUCj/u7/3uCblCBz4jPZQBeNYU ihrycLDbUuf8JZmdGpKKw4cJjFVrWYssPsaCRBRDvnD53l43hY9uSgAk6imwBjUNWUZCIA VsicEDIMp8QJ5byipBUe1F8arB5hLrI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wQi8kE1utZmoURCigtdOBC8M6Vwy/ecTHFCV8ZmblqA=; b=Fau6L1/KFNPruKB7rY1tU73Uiv isB9eLZGKuMwy8IZ/jSht4PywEmTZDXesH/yEHVbQbrRp8MWSazY/j/JzhSohgByM2GD9QoesUNYx uFA8DE84qcdnnAIp4uMlv44kj6NvLDNckUAQHXYyvoB6AjjD6a651BP4KDcCZ3NpCo5oqjrwD5LYM f8+Jw/w6gZ4DjBmR6mQtr+Hqc4JszwRBk+J1DeAmHKVCT2/G8RR5+O6rgn5dP2pCT6u1Pvm3HsyX9 ovweEVVEaU/4KKUjSuQvD2LDVhAx9uS/kp9kh6jo/JFQmH5rDarmuuYmzQKB/DrJT6J5aRQjQ/kBw m00ZidjA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qFLpu-0062Mp-Tz; Fri, 30 Jun 2023 21:39:26 +0000 Date: Fri, 30 Jun 2023 22:39:26 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH 0/2] mm: remove page_rmapping() Message-ID: References: <20230630121310.165700-1-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230630121310.165700-1-zhangpeng362@huawei.com> X-Rspamd-Queue-Id: 9338612000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3yjxgx1j99jhxho34fwsnwph1p48jc84 X-HE-Tag: 1688161172-206058 X-HE-Meta: U2FsdGVkX18172bo2YTUtjovsZsQDnIgb7nJJFsV/pDbErawh9ShuOBy3rIXPczcQexrV5Uqhldn29TbqcFLc+ZCtgub7AkbRoCkW5YvbpsEqrvjBIxc4tROpV6kgFkyfSWVfI/UnhUwTuHWmcGHIMBfAOEJz7QQuni3BW7E7LuT1hsQqV3sgYdhz/H/tMK1JjIRimwqQ0sdSeMIRUj9B986zCZVJo0LfnBeR99ps0ybHyWtGFWGOycmSS9KJ+VskVzZop8q2Lgcf3NAFBI3rNsPFWttlOzNlxXhsp2lNZtsbRfcWJR/jXj2rKCFy3QYxVmL3LRSDOYaGoQDLacXawBpHW0znCe7jmhVa1RN6NDZs9y+kehQzZyZHtEVh5fatk7uplX3J1m1bHyXP/qSb91oKwN9ckqkDlhnMrzTpZ9EnKqmEi0gUWeS5llcmcnUcWtdJr1bSPMu1yLnbK5ID32HTw0YCEuJl/+cdMihTV6Dmdt6jYqo18kQSXPp1INAglK21Px5B+aNBuAQDZWqEb/LIuMZLvcENhLVv/TCnNUz0UAS6qaZywKf75ysul/H6AXphs0+mmi341Fs8bQZJW+fmmlsReXtMdCAlZKg5YSqZ2DAS8EZF0G4du+xFxycGEFbTDRFXGQo3RDPonqbyK1i4Yr+Hw3oLcymm0HC9UFf+eTo/X2VxS9FaVbfWWGo82v9PExMXaWEQrAv5EOzk0alZpweMpRvicec2sz+9oDjXu7hRwhelO2ePOGOsjueVsZi8IQjkWVXwVbSz0dE8EBspmLMe9YbLxDi2eqi2BpqVQAGS7L9oSFBmDdapNtSQC3cUnyb/TPCNVacl2ae+GJKJi9/t7pzFBwuCY91wMuIyRSU2+lOgt0Y9pmiFLGuU5fqC/xQ1UedJHRX49ah9gk0QtiMdzsS2ufNp8xPE3/x0lZLdqLs+ErztWIVmfm9COvSTbabsMObbLmkl+n hPE0ddez HOKM1O+wdGCIlXznGT+CtS8MImAG38iyXmGsv0+TNw49Njy5YzWEclUElpTrQnB6d/dGzFuW4Qpf1dqJ6XjPmYSeHZOin6kbmtFYNUAYZVT+mKjFbtYqW+o1bLK0qiPVL0fqxj7AxohEZYWp5jwIZWMukUa5QMvnXIGhjFhluPJRsUT+RkQayJGfNkxW16dWXzmRN3xsHbc9UFO0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 30, 2023 at 08:13:08PM +0800, Peng Zhang wrote: > From: ZhangPeng > > This minor patch series remove page_rmapping() and convert the last user > fault_dirty_shared_page() to use a folio. This patch series works better if you do it in the other order. First convert the user, then remove the now-unused page_rmapping(). It's almost always a mistake to start with "I want to remove all the users of API x". You should be thinking "Here is function y that still uses pages; I shall convert it to use folios".