From: Matthew Wilcox <willy@infradead.org>
To: Peng Zhang <zhangpeng362@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
sidhartha.kumar@oracle.com, akpm@linux-foundation.org,
wangkefeng.wang@huawei.com, sunnanyong@huawei.com
Subject: Re: [PATCH 0/2] mm: remove page_rmapping()
Date: Fri, 30 Jun 2023 22:39:26 +0100 [thread overview]
Message-ID: <ZJ9LjgghNB3osXIO@casper.infradead.org> (raw)
In-Reply-To: <20230630121310.165700-1-zhangpeng362@huawei.com>
On Fri, Jun 30, 2023 at 08:13:08PM +0800, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
>
> This minor patch series remove page_rmapping() and convert the last user
> fault_dirty_shared_page() to use a folio.
This patch series works better if you do it in the other order.
First convert the user, then remove the now-unused page_rmapping().
It's almost always a mistake to start with "I want to remove all the
users of API x". You should be thinking "Here is function y that still
uses pages; I shall convert it to use folios".
next prev parent reply other threads:[~2023-06-30 21:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:13 Peng Zhang
2023-06-30 12:13 ` [PATCH 1/2] " Peng Zhang
2023-06-30 15:56 ` Sidhartha Kumar
2023-06-30 16:03 ` Sidhartha Kumar
2023-07-01 2:57 ` zhangpeng (AS)
2023-06-30 12:13 ` [PATCH 2/2] mm: use a folio in fault_dirty_shared_page() Peng Zhang
2023-06-30 15:58 ` Sidhartha Kumar
2023-06-30 21:39 ` Matthew Wilcox [this message]
2023-07-01 2:57 ` [PATCH 0/2] mm: remove page_rmapping() zhangpeng (AS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ9LjgghNB3osXIO@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox