From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCEEEB64D9 for ; Thu, 29 Jun 2023 15:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 208F88D0003; Thu, 29 Jun 2023 11:17:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B92D8D0001; Thu, 29 Jun 2023 11:17:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0597B8D0003; Thu, 29 Jun 2023 11:17:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E79948D0001 for ; Thu, 29 Jun 2023 11:17:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 941CB1A0266 for ; Thu, 29 Jun 2023 15:17:34 +0000 (UTC) X-FDA: 80956139628.14.A3E29F1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id D3B3810002C for ; Thu, 29 Jun 2023 15:17:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Nmd6u7CT; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688051851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Br5lmtkM4xEPXhnEaSyMakyTIFN7fYK9NHh54UdMeT0=; b=O23wqvDXhQ1bhRMcMpkH/ckTrWPFZ7JOsT/qjFvmjMYBuy8dGISgXGGg+VrbyN6uoKMFCl HTrvZC/cv5gPDyNngt+uidfcEmsLEn4n17jU4olRb4j1J2Xzt4lTbn+cWRZ9/dK9vBvFx+ vcCxNFTCpkkVHZztvzDmN6FAk0aHd1A= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Nmd6u7CT; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688051851; a=rsa-sha256; cv=none; b=aVpxBSnr87SGlQEpWjWAFOOIgDgrSIn2b0NhzEon4K9h5hZATJLMlmmSxXtR8kXSy9Bj/T 5ggMIrY624xq/g/txFg3yX+7dZ2UPskyu51dgzlju4p1wIfdepRshpQbcFnIisaiTWswC1 O89VOmD43xwiA3i5oEujonF4n597sRc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Br5lmtkM4xEPXhnEaSyMakyTIFN7fYK9NHh54UdMeT0=; b=Nmd6u7CTxl4EWCi8FGYXJ74Qpu bAcilZ1J7uer3chhnj9MN/wr3YlSmQwFKddAHjADFftWFDNj8j6wVmV9lmXVGQ7hbllm/xnZBWkTq D4nBq3DBaEIm3a4D31XhJNZJUtW8UZBSiQbR5kICGO0FzEElP70STZR/WqzWrBv2ahNjKTeLhA0qT TqiOifl12mHfnHDZC/ZVhU+ZeU778mdD+KSAUDczreAq54NcsJd/KO8z2utjgtS3O9Hk7COLoXsNq a3PX8GJ5wdi5mtjI20jqjKQ2ZHbYmh8T5Fa5v7tZ7A1guEVNONDXPygWDhvJwB50dt0TPckJKdwi+ XXJFRrBA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qEtOZ-004xdy-03; Thu, 29 Jun 2023 15:17:19 +0000 Date: Thu, 29 Jun 2023 16:17:18 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Greg Kroah-Hartman , Michael Ellerman , Nicholas Piggin , Christophe Leroy Subject: Re: [PATCH 1/2] mm: remove arguments of show_mem() Message-ID: References: <20230629104357.35455-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629104357.35455-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: D3B3810002C X-Rspam-User: X-Stat-Signature: ggi5fbay1rrw5d74ntkte5533c8wxko3 X-Rspamd-Server: rspam01 X-HE-Tag: 1688051850-515371 X-HE-Meta: U2FsdGVkX1/bZ/A7JE+lHUpBhvubDtdgxU26nwhk5swA3/hEu1ueQZxQdz6qVw+9W0yZ/iVYBcsiEkk3qxPjINqNJ3p+cAQJI3qFqmmwpb4wyff28JX/h/56sd2MMhJw8wLySpxOZhyo+8NeOEeZvFzOK0DGPUsjU7BqC4nHd9mFTRDfYYp/48jljnbjChTzAik2suvLMmC8sRbu8YXsUt/L4yLpXEr2riDMn1gB09ekAwI82wsS8Gileiz0jgCkIAd9kJBLBcohN7GT0RENExlj646POS6KDovQuZkVXDbMfJKRTOGJcZgCB7WGFhh8zNkRIrRfyGPR6vpZVGE0nr3DLlWu5YywUX8f+WLJyxj8bvKRYWGcUYld0ykiC3eV5GFa9Ng1ZXkqfEFmjUyJ5ItsJNcg3q64P9cZSqvaUZvOnvI+m3fbnKebmtOWBfo3INMSHshojy8LN7b6IKmNC97HQPzC2j3ac3eYApdL6EMH/UsZnyOHfcI38mMnNI8Qc5vq7QA1uhQrcM0U7zzzZaxucREkBS6am1dzyZcN9kTPmREwjSYR+ZLGWe4f3pTh6ovoRZ9j5Z1Gn3bvOImOMVp7Zs1dP5wjELQIdHhYOwUneGB70BQS2tB/ifnLhRvw+5yo1kZRr1mu1ytYS2d9clECo5S/EuClNF59tSIn7u4BBHsGLF+zGxKaNCjHfqEt2VgBRQidK6TtzZbK+R8NxHczMkJGrQE4eTqohf1K8Djeb9/pogVJMaAGT8s0BTbyw7TTOok5VCozF7PqvJkRja8Tyft/H/H9uufOOr0/YEXVvGD3vRCUYPYovmoUDgWfyjdBZ+Y1mZZpyQ1UF5IVPCt2ZvN08ACmYaNKewKuypopagxBDvEyQRJdudklk8oBMKtHpKiOSW5E9vgxSFXggM+uuWT0AK6MfnM83MgMFvWWHxE6ZxLmTcomD3GtXJpQ3V6YAA2BGMBMpo00faX hV7+23Ef seC1twyqJ3lDiKYQcSf9VtnZJuLEDT+8UwQtUQS6PwabgR04QHc+l2wurQ/P/CwAxMT5BEubAu4J8F89C8iDZgWN0hRXi0JdE+sYSYOWUJ9AKFw5UtfsJ4YgfLh0YKgIwbfJdBrSyEYINsj/pzqcT43gkNyq5NSzBTPYJqbNYuKvKYj2Sz/ZERN6Evw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 06:43:56PM +0800, Kefeng Wang wrote: > Directly call __show_mem(0, NULL, MAX_NR_ZONES - 1) in show_mem() > to remove the arguments of show_mem(). Do you mean, "All callers of show_mem() pass 0 and NULL, so we can remove the two arguments"?