From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484EEEB64D9 for ; Thu, 29 Jun 2023 14:42:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3A508D0002; Thu, 29 Jun 2023 10:42:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE9B78D0001; Thu, 29 Jun 2023 10:42:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB24E8D0002; Thu, 29 Jun 2023 10:42:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AC23C8D0001 for ; Thu, 29 Jun 2023 10:42:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 721A11604D3 for ; Thu, 29 Jun 2023 14:42:05 +0000 (UTC) X-FDA: 80956050210.19.D0A5461 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf04.hostedemail.com (Postfix) with ESMTP id B647C40005 for ; Thu, 29 Jun 2023 14:42:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Zm83snf8; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688049723; a=rsa-sha256; cv=none; b=nPZi6GXJZ+n0NW/NRQ0zylKQ4c8vTu3xwDAh70iIKZ2zV5SODLmXz3ncXKzWZfUdMhGJlG TUgsL1foZUzcKv1MTrGnyFuBTCQI88nCLECqAb4iHIrXldjCoQvsi1yInPsFmTQ/9WIFQ4 8IaGLO4JjXJfuAAdbIJovQ9IPadA2Cg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Zm83snf8; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688049723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/E/nHU4CpzLOREHy0Tb/APQ2Q+vrubq7sRTQS2maAHg=; b=3au/wjutlnUOZHXyblI52IZsuCy6DPU2aKxbmJT+d7lpTBOT+m+9IfQwFBlm8TzEJ8TxHn F9fqUFWGlO1p6crS6jf04Bqq7QwwGpwd2hkE3dkv6SYnAxgFOmWgggkhD4vKSkFSG04L8P Mr5mr2GlbVVu0w7mhmB55eKzIPipatY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688049722; x=1719585722; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=49jKW1QMOhOfQCsdVQEzVWF88EaDVYoWdRGiLZ7wofY=; b=Zm83snf8HuN1lX9vH1vNrJlZYGFwmeYrnUXu+8W5A7vTJUVrI9DuV/rR rGRWGL6JroWlJ1SmoE2QcPp6kIZzkpnKdGDVuS+dV0Zh6N0M0utgAGoX0 gmyQwjbjhfqevJu64a1ACbSn5rJPvI+zxfCLpl7pXrQM9OqmPH2fdjrEX 9TtJBTQddtdqTXxvBhHXRonXkEFc8wLp9Qvk7YdQ2bzs8qJVSaPDDTmF2 hVWMl+TYzaDkFW6+h6xpu82ZcCBboOB/aqLJm5xsSNlQjvsabDBjysm/B kSPzPLSDAy1sxUB52tosf5vCNXNQ1bOV5ZHkEx0xJAqkikNaIsbPUDpJn w==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="362161236" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="362161236" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 07:42:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="841465734" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="841465734" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 29 Jun 2023 07:41:57 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qEsqJ-000sht-0n; Thu, 29 Jun 2023 17:41:55 +0300 Date: Thu, 29 Jun 2023 17:41:55 +0300 From: 'Andy Shevchenko' To: David Laight Cc: Andrew Morton , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Subject: Re: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Message-ID: References: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> <6b241f45a61f40fe9b221696289fd658@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b241f45a61f40fe9b221696289fd658@AcuMS.aculab.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B647C40005 X-Stat-Signature: 8hcszd16jipdpi4c8uqwzc4szchq3bk7 X-HE-Tag: 1688049722-459088 X-HE-Meta: U2FsdGVkX19O4Y8J9eSesr9eKvOrh2L86gfDYuF1BLYz4iNCX9yvilnGqkXwvzU0dd+XqWpjdAsB6P1TngCGmbQdyU0dqaG4E8UExn9tJCHiRvC9CDYx5vfDwe40Nr6OsAuPJxJHrGFDPWh0z6JwemBxX6TXRGQE8k9CAgHjHzhlIE9+tBS3yB0ovEqw2jMbQqmCS8yme2DgWOFWCF3Q7CDi5+Q+AJng0/fLjKhKM9yAj6GPd+bz9qgD2hC/cEX/87P0rIdDR6q6bzns+blQ4pKeC6RZrC0qhatmUaeFOByxay28vqhLKAVBZV4GdetUabhkpbJQKT7ZsexIQz7xM9Mf3NnSaIHRLoP+/0unnrNBAKsZBvKW3Cl0SucKk7SCQ7WKDpsIJ9DRK4E72NDeF3oON09sy7et1qKcD46ZcYN9R68IJe4/jraF3XDUJDFzMlcYitt28fTpK0njuIeFHbSBv3YOTEBIl/7/y1eFfIcISNqYrPJwQcxSs2+Ji2zTgx6mLE/GyDcEWOaONWJOatyJiQUWps2s1tI6CqwR2t0oo3OztJdMbReRSJrx9KRw3n8kTPfntsSnkQ9FNQisKwc6o8faMnw9q06r1NSKjbzezPRB0ESLM8YfpgicauZY7NH1Tg81jQzmQqFeHyORV9CJ06X6tPb3o0jjjZqFrtUW5EwZkYfYVEXc3zoE59+3w3QLrwQ+Zxc6yHp1h/hw44xG6exYP83ZYfZNk+388OVeLms+nGJVA45vPw8fNG1puEPHf94IXjEbe0gfO36ADR3q6Y0uRh+A/2is02js8ohSnfNE82Z8CslDBoR7BMW4Y+cDxhdFmjAuulCMJ8QjxjZ+Tvlkr3slh/zCg2Ng9e6ZwQTVn2/2usG+2BmjWa9Zu2CVtN/rtmmtE1u1fCOACzZ2SmVcCYjzPfKTMDo5DqGObyiLjSFpx5D/mjDVuQlbXnxfcBR6mlQzTnTmaQK 9LHdMVP1 ynvMVerxsH8TQxI6HMsoiVsyze7KJd8624o7Mp1KwZFvjnPzewTnUhME6w+3t5CBhC+I+/4lia9Ti7ZSGKgRLBZkmPTKjF2USu0TYqFjPcAYs+Pu7gJxBpg6E01ayTGc0hlSSMAY3fRytiGp6KLsbzLSttqH43H7+hRkSY93Prq8i2/TpXNwWoiOYqD+lDE4GnXV/HjRISbCFgaLFXgVHVXhaLc61Ggdaq4JzXXmzt5QK0h6L2EF9vHJTARq9OE4XuYK9VfIoqpVad1QjbjNywtctSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 02:32:13PM +0000, David Laight wrote: > From: Andy Shevchenko > > Sent: 28 June 2023 16:34 ... > > /* Strip line number; without filename it's not very helpful. */ > > - strreplace(token, ':', '\0'); > > + p[strchrnul(token, ':') - token] = '\0'; > > Isn't 'p' undefined here? Yep, should be token. Not sure what I was thinking about... -- With Best Regards, Andy Shevchenko