From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029EFEB64D9 for ; Thu, 29 Jun 2023 09:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F8388D0003; Thu, 29 Jun 2023 05:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87FBD8D0001; Thu, 29 Jun 2023 05:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746FC8D0003; Thu, 29 Jun 2023 05:22:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 67C588D0001 for ; Thu, 29 Jun 2023 05:22:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2CAC41A0CF8 for ; Thu, 29 Jun 2023 09:22:49 +0000 (UTC) X-FDA: 80955245658.08.DDBCD8F Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf29.hostedemail.com (Postfix) with ESMTP id 89608120015 for ; Thu, 29 Jun 2023 09:22:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M9YEfHpf; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688030566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6VGwAQ4Mq2HZsq6DtsdkLPdNrBBoYj4oDRTrauv82qc=; b=bivEsViRG0GkmccyWnp3DmKljJwRwsO8aFSm1+Y+K8XCW16qM7c1wU0r4LN6HTSsoKLieY L6QYhdNqBHbJPTWxBtC7x4nHA+MJ1t3hW9TEO5fZK7SWkGix9zh88hiGC8JOFGcRIVtRGk rnIHIyITwNUaj/iuRwIu+xrpxJLPnqM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M9YEfHpf; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688030566; a=rsa-sha256; cv=none; b=AcbaRu64Jy0mS0mqa13m0zKHcwVdWpFXOejWELKhypG8YchQ/Oef3mH1jhNNTSXKWZcGoh HOLdFiVh5HlI0JcZ5TRvHpeSX51wZMg/MepSIQe1y8DIHO5xawyCcjNgnb+oCrU/sfvPg8 y7THgjoFWy1n0MDK7xMRsy3rujKX13w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688030566; x=1719566566; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=3NRSTjyOfKpve9/AW/hw08ffGhe9mZ/e6rJCV787WIs=; b=M9YEfHpfF4dx6zkVUm7QH2KGKjBld75+qBHalrpCL+2y8606zgSED0sJ noYtqvdabCmprGlmPneCsH4EZGrLO3vb47uZ3UDS0lzv2VLKDs7425fko UA5FcbUISKKKjnxP2KcNAtySrhPvdsETKtC+0aFnvVgBDAs6enVXMKd5f WpSBsCS5V6w28YTJzrfdyJEfYtU/6LOQWLXHLJ5M6kIbkYmA3n2eJ3cQ3 Ht9MYwbFGPLBslBRyZPGm9sWg0794ns8McHGcsLJ0cpg8lgK2ZiHdVByb zJJUAlbonDm+5taCQhmdVc4nD+o+N5tPhn2YqcdttazCo9xo7CJx3SkoH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="360913468" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="360913468" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 02:22:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="782622678" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="782622678" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 29 Jun 2023 02:22:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qEnrM-000oP0-1N; Thu, 29 Jun 2023 12:22:40 +0300 Date: Thu, 29 Jun 2023 12:22:40 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Subject: Re: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Message-ID: References: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 89608120015 X-Stat-Signature: p5k9rz57ux1nyxkwm5c63i5wmi8ps5b1 X-HE-Tag: 1688030566-542218 X-HE-Meta: U2FsdGVkX19juY+HwseUdxRrYZfrjZEIu0NGh8XhTC5IInTL3FIKdZjmhcKzBYLopz7EaGJp7c4gs9koi05yVkqfoAGxFu9H2Y34iqfOTalh60+cnNJqbd73Vr8YVYJNXmqSZTym3STlJgXPVTu8U6M5kaQfnZTaLFnVJmuPq6JQQyNkSyfutWcIJjnWt9UUrOmhsZXxr2wQ4p4OY2lfi8HAaqCNhrg7gxm5z6kvB6px+dQb6XrYruH6rG7bscZ3FuHKA1S0/8TAKVhkiN2CmdalUuvtOvqjHzsKDi9JgyZY66lWVCgtHgxmdM9OsAc13YkSEtpxUnkwlHOue4sASLSBxR/IzjS3OR2feMiIhH4AJPa3o5BTxhjnaE4vCuV6YUeOLKwdAKn94/KbJiWbyYzojbL4YWLckcxlxcgpwLu8ez2oaXyv7AYN0bNcEb3cbeRbolpoVFOQ/UXyva/Yon0zpnfpS/IHBcAnfpAH6MemOQMb18pFu4pg+9qNCKti+ORSVs2M8XUAWLScoblO0DN0P4kwCnCUhSxoMtKhCdOfFxU6ZpBcF8/4ISOVQacJ3gN7zyo/qwRoKzX/J2+FNxlWbVu9nOD0izH+lpLBAQ45B4gQfPZm8Or17psCjkhH8c447GWEGcjFLcAKXBm1Cxy+Z9e37vePTd1oUjVzQGpLSLxfXuaBlb1xUFNVZE9Z5c0Av/wOjHfcH/+2gpxA+AOMD/HSrGhwwzQYFQ4Y6PbPqI37SR4sols++EdiUJ8KcakqTw8ZCI+ltNrekiNJnjNceQtgOTtQxJGa4C+1vr8S+za/jbYl+4Bf5DbLAj9usE+ITOsmbsTE7BVbbwGnnGYPEkaeJb2J5HEzG24YdqpZ8rodKWOlCCtEvRS7fx7w/Ubd57sLAIDCyEvkunL3xQvfC+NfeT6xcRP8tX8RiJGA3tuwWgj5RIeg4lg6KaCbd/fx1VTNklE31g0WZDK GGaZlE1k /+cFAemWFFIIDAcY2xCtI473KTpLAt00WCE82LWkjwcXUNrG5Swfa5jG9QCjPlotRu2Ud06Td2g3ZTAhJQcKJ+TYScAFd7m6Vxg4+pO9YZxeg9ykRZPP44cke+ggxfqWXfHk2icILnUPkEUoPg3XA7u+UGA+yauYP9HPbXpYyKSabTlwMs/3+3cE8QdEQwjJOwTnAZG9az9SnAGuFVypwvW5csUaPzWj7CoYluILEVC8KRXDpZibu4wDl+Cld2zXJERjD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 05:39:26PM +0200, Alexander Potapenko wrote: > On Wed, Jun 28, 2023 at 5:34 PM Andy Shevchenko > wrote: ... > > /* Strip line number; without filename it's not very helpful. */ > > - strreplace(token, ':', '\0'); > > + p[strchrnul(token, ':') - token] = '\0'; > > Why not just > *(strchrnul(token, ':')) = '\0'; > ? I don't like Pythonish style in the C. But if you insist, I can update it. -- With Best Regards, Andy Shevchenko