From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6F5EB64D9 for ; Thu, 15 Jun 2023 19:42:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75B128E0001; Thu, 15 Jun 2023 15:42:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70B156B007B; Thu, 15 Jun 2023 15:42:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ABE28E0001; Thu, 15 Jun 2023 15:42:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 48D9C6B0078 for ; Thu, 15 Jun 2023 15:42:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 11176806E7 for ; Thu, 15 Jun 2023 19:42:30 +0000 (UTC) X-FDA: 80906004060.19.D4C51E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id DD11F1C001F for ; Thu, 15 Jun 2023 19:42:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=coBraIC8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686858147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UcOpteduUqck9yvQgpJHjo+JwyvicD28FUiieKHhaT8=; b=DDEoJm0+bZkMU6iphUILkFGzvulBOEFcj/AW5AuF6nplqP/+dAisdO9unr2dQ+4xmvxWNz xJdni2LG9oDTkZvznwSwWHv1nLSc1ExIGABYL2XKqimA8WEvMcQK7GehVMyD+4PsXWyCkE pAHYzeagrxArzJNGVlQaMtInE7+Aozw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=coBraIC8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686858147; a=rsa-sha256; cv=none; b=fzdY7ubn0Yjvfox9l6kv00ro2eh+ll7OO3eyBLPZTrvj1Kw+S7yDFAphlH1olLPGxdOOdp EJuYI36JtkSS8TPnpM1mljYV7VtH0vqRHMNbBWjkXIFyyvC5oQbW3Y/Up6r8q2is+lQj/n lMtZRP6AUUrqV848OsWrjGR9hFzpqxI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686858147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UcOpteduUqck9yvQgpJHjo+JwyvicD28FUiieKHhaT8=; b=coBraIC8yPmLTLDfhHZjQ8IQkkR9JGzCXb7WOaw9rINsvbqPbTVkJSMb8//8PSD1AeE58/ GjV1oJVYTDheohFJSP+eooF4KBV5AdjORn9juh252d9IZZGdQDV7eff5mZpHpnXLTk2UbK AQ0XoP9nyXAYaION297HflTltpQlQ3I= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-4uhG101sOZiF5mYp3NQ1-g-1; Thu, 15 Jun 2023 15:42:26 -0400 X-MC-Unique: 4uhG101sOZiF5mYp3NQ1-g-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-62ff7a8b9aeso99166d6.1 for ; Thu, 15 Jun 2023 12:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686858145; x=1689450145; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UcOpteduUqck9yvQgpJHjo+JwyvicD28FUiieKHhaT8=; b=TWrJrM6phFDrWG1zB8LzTyJtBxrTgnIgulJ1TrMIEGHJSEipV0DAyWPYqNOe0HLE68 q3RBK3fT9iOcrZkR3FZp8P2lFcjl+gY8W7xBIdU1x9LrONTPXNY77YsHWreRIR2EAimC CyN3uA0bCoT5olTYWuzYuvoWzDwY6gMbeEqk9rt8RyC3efQ5eLVvQ6O5+xCTQA2jAhO4 7Pkd/JBEEoDmEVlQL7/Y6aGvVWMkgtWSZXBs6qgGaiY884/wepKhrMYgQ6jPkLJM+9AD p4mHMfHpi3zq9mP+ypgqcQxTkqtim9dUZRw0ggGgZEkkocU1FHrVvo3u01/VzbQyiWiy Da7w== X-Gm-Message-State: AC+VfDyArSjg2jjZqrJdYWs4pak+Pt3FP6TjChfuFuxB2mEFtWPFKWqR tL++vWvtuxmIusDC6zfVGNdEOXCkEUCFT6/lnAOrtsJw67JLX0ARhTfhRnRIoGq/RNf4x04RBYf gFRP7wtw7FYI= X-Received: by 2002:a05:6214:f22:b0:625:8684:3406 with SMTP id iw2-20020a0562140f2200b0062586843406mr34404qvb.0.1686858145570; Thu, 15 Jun 2023 12:42:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7eG2fiy35s+OEj/WEhtEEjuGtnQktBQRKTkC3B9+KcNyvhYrS9tXTaM3JWpqtH3iGie7+hlQ== X-Received: by 2002:a05:6214:f22:b0:625:8684:3406 with SMTP id iw2-20020a0562140f2200b0062586843406mr34304qvb.0.1686858143137; Thu, 15 Jun 2023 12:42:23 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id l19-20020a0ce513000000b006262725bc89sm249428qvm.73.2023.06.15.12.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 12:42:22 -0700 (PDT) Date: Thu, 15 Jun 2023 15:42:21 -0400 From: Peter Xu To: Mike Kravetz Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , James Houghton , Hugh Dickins Subject: Re: [PATCH 4/7] mm/hugetlb: Prepare hugetlb_follow_page_mask() for FOLL_PIN Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-5-peterx@redhat.com> <533c32cf-9a18-1590-4d29-f076d6bd58c1@redhat.com> <38574ed3-ea96-a72e-00dd-4e6204413a86@redhat.com> <20230615002525.GD38211@monkey> MIME-Version: 1.0 In-Reply-To: <20230615002525.GD38211@monkey> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DD11F1C001F X-Stat-Signature: w747h5bapgn5fzjt1iod67u3gizhcass X-HE-Tag: 1686858147-58309 X-HE-Meta: U2FsdGVkX19jgHZfEP+vXUtpt05uWGAY72TptMcnT0zrIN0VmU7HtpN5SOWLZC56YklQKgnFrKVLB/EKIu0LUWCm2Tf1ELazUxsrrJeYQPXYhHz8RLGGdFNUyxVYQ+c2wbdsE2fL3OotVdzhScaC1HChh1cEmUcpIbX+vIpyffJ/GR/PIy/FC4jsSu3j7Vrqsb+Cj+UMEFjw751qEJpQPJ/ZYv52w/pfDHLcklfG1MG9Jzed8QKyyD1GDTsF267XmaPHzWn7YdYAS6YXEhsT0hLpMGe3ZQ+5KiwFUh9j9DmwIkjPwlq2znri7iqtJEOiG/kMLxkTf0zB0teutgTsQ4XWk/oFbCyqtgtMwI9ImE7ofKzk7FuZnzXsqZCDRzv07b8rEvQtrQ/OKUyStLQeY3Xh+AOCkHseqyAniR6xcyo14yTTKmbwvyA9KHTvDZJaqYBQPeJ5R1VJtIf+ZkfDPsJcQhRmmIx7daR/EuydpSRbenS2dUvJokdhZC7DOBkTXq12e0M884y+eUSHnvQ47nk1dnwjpSbmTOAza0HDdLFEzuKLyfCabRuEUJSgehuJml2Hy35qcq6TaNqS8iD2tWEK1UcixaVd81Pzurpl0z9RAQ53XlFpWR+7kpHpUuvHPaN5ZfpUmh5FrQ5rMDbhzJpNQH+8g+aXDtlEL5Q+wnxebI+H+2NNURaR8gAl4v6DNYicPCrMQ35O7+4Hg8D6hPbUv3bptOtJrjZHQBsamC2Y3oL7JMDb9/XtuKrTSDQYl3XUdrPcoG8xW5y7TD08PhQfG6emeUdSh1+6qzpCNGPemKPim/6sgwAGUv4s0g45ItGD0SLSoZv8RcFNKsNJDfJG68nAPoQsPpppvxERl7TV1PUmBaIywB3oI3MLnKWDdMu06zJI+vmSzels/WofOF1s1MKpFYmuIrIR2E/iawnAlFhteR0z9QD5u62SPF59CDE/240Uytw47ssfLU2 NDGDgPk0 /sXb+NlowCsNHApDBn95k5utruFO4chfZSohfrDXgpA6CCFET/V3jeMxOikyeYzy+o1vizrUWizb0fjDNOl0QOqs/hd5ogNejXt/5AivIM+iVT2Tf0NWvVl4SKvCt4eEHUpHFC6obw/ctb3X3/MWu1wek0Sa1G/8250Pv0U2AwccgphVDFO1jASGHgvVGECXCT2VHelQWvOirw9+NLgA4MOrEjVXVp0q1TvVGcIWosBP8PqJ+O/SIH0eVzHr0z58Nlr/0yYZ7JFx1kqDX2U5pd5EYOl7MCGCzBVCxDyJ9a2kjrW1gEdJ6GBtf/jVha6Dvlh9mfEtQfiEQ5kfasY6FIrg3ahqXJljc/vP2EGOqeCFzLJypFD9/HbvoC1IIXw26yojZ3FPPV97C6915YQUXiRruFjPYakL/UNGR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 05:25:25PM -0700, Mike Kravetz wrote: > On 06/14/23 11:51, Peter Xu wrote: > > On Wed, Jun 14, 2023 at 05:47:31PM +0200, David Hildenbrand wrote: > > > Right. Then just call patch #2 "Add missing write-permission check" and this > > > patch "Support FOLL_PIN in hugetlb_follow_page_mask()" or sth. like that. > > > > > > Regarding the backport, I really wonder if patch #2 is required at all, > > > because I didn't sport any applicable FOLL_WRITE users. Maybe there were > > > some? Hm. If it's not applicable, a single "Support FOLL_PIN in > > > hugetlb_follow_page_mask()" patch might be cleanest. > > > > Yeah, I agree. The code is definitely needed, not the split of patches if > > no need for a backport. Let me merge then. > > > > Should have read this before adding my RB to patch 2. I assumed no > backport. Agree, than merging the gup_must_unshare here makes more sense. Thanks for taking a look! No worries, I'll make bold to just take your R-b over the merged patch when I repost, according to your R-b in patch 2 and the comment here. I hope it's fine to you. -- Peter Xu