From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A782EB64D9 for ; Thu, 15 Jun 2023 19:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D521F6B0078; Thu, 15 Jun 2023 15:33:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D02516B007B; Thu, 15 Jun 2023 15:33:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA2988E0001; Thu, 15 Jun 2023 15:33:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A70866B0078 for ; Thu, 15 Jun 2023 15:33:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C643C0A0F for ; Thu, 15 Jun 2023 19:33:24 +0000 (UTC) X-FDA: 80905981128.24.11DB970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 4162440017 for ; Thu, 15 Jun 2023 19:33:21 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bbOTzQHF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686857602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qJ9fh5TisbZKUaORbgtmA89u4YsXzvNQtjxXBV2tisQ=; b=PYAIYcq24kZkSol6D6/ea60YfaTrw3RyWEkpOOmmKqCt46KoWYlyci8jJZMtfPhnTjw71Y eArykWHDTKIk2DzED/HxnYFbnciOFdrs+NN2NdUExnKDQIy1/rxNkS8Zt8MhA6eKY29OoA PgDlQh4t2efgVNbwx3GQKhaBIq43T+k= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bbOTzQHF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686857602; a=rsa-sha256; cv=none; b=GtjwNRNvaabYfBa6tpg22OO0EIEqNMYPvPrO0aT/SLjyPWW87HTp7miK+zKf0Ta9AlcL6q J8EopW7sDt3ZjMf3nvattD/uqMpfD0PoDWpmrKNcyo+TJ6qpfiXVOuxxjO54mDwhA6GVS3 aMXjySBo9wzY5q0zML2j7klh/gcUeUg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686857601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qJ9fh5TisbZKUaORbgtmA89u4YsXzvNQtjxXBV2tisQ=; b=bbOTzQHFQZUnxusf+53lpPIqMQZ9jTA74BfRDp4i3/TPU7IZpw38lTM5xhKvO9CemgA7af Fno5aoSmPvABJ/c2mCThaVnf2+JLjZutzRSwQW7foRGwzsHpBH9ow+gponsXDn5oHVS1xt /PF/ttD3++kbggxBidCZgACBtm7EZHQ= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-WKsGpGl7Pq-kIpFdcXg9hw-1; Thu, 15 Jun 2023 15:33:20 -0400 X-MC-Unique: WKsGpGl7Pq-kIpFdcXg9hw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-62dd9986b76so87086d6.1 for ; Thu, 15 Jun 2023 12:33:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686857596; x=1689449596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qJ9fh5TisbZKUaORbgtmA89u4YsXzvNQtjxXBV2tisQ=; b=eAXRACGhsbeUKnB9q5pJ47bY19ISPEe7R012KWAbiAxHBHt+ei91mOzLjSrAUTqgVX 3emrhCzL/zpg0Ek7LjHLZw4FGH/1QaX93xQghhAzWA/B3H9sE0vsjCQg9jGQPpq3p+Aa UtVP0c0LzTQzSnJXq0y4jU+HR/297goxFryYbjCvJRGgrKpE1QCv6dUwIuHqn6/suTpU NwshCAqi7OQ/4VsMjUW7SfHDf+gnW4/aaZaJ8i1T7JoOBJara+f07J+KwG+vmqVhpQ7a bRUwIuDz3FfucEzeOPUa90ZzayuEV3P27nqFdFG6JYf4csFk8e+4TgYnOpaA50gD3TBq KS/w== X-Gm-Message-State: AC+VfDxM9UXwca11eGOTviTR5ZfObkP1XJouME71Dv9a6/GAZpeGmVmB u3C4FbxnQ2NaQq5NMwgm5RUm0ofRam5tisK2nLv6ixPV6TDD1bLIGeeXQZv2YcwCJ+QUf01gR/3 wKyI++wDzBgg= X-Received: by 2002:ad4:5bca:0:b0:5ed:c96e:ca4a with SMTP id t10-20020ad45bca000000b005edc96eca4amr22503023qvt.1.1686857595806; Thu, 15 Jun 2023 12:33:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5M13ke+gvL3VoDObxmyNhDkjVrjDagXp/R2MhL92zTstn0T61v6zTXVFTefmODf0p29xAboA== X-Received: by 2002:ad4:5bca:0:b0:5ed:c96e:ca4a with SMTP id t10-20020ad45bca000000b005edc96eca4amr22503000qvt.1.1686857595549; Thu, 15 Jun 2023 12:33:15 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id c20-20020a0cca14000000b0062ff47845fcsm719203qvk.48.2023.06.15.12.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 12:33:14 -0700 (PDT) Date: Thu, 15 Jun 2023 15:33:12 -0400 From: Peter Xu To: Alex Sierra Cc: jgg@nvidia.com, david@redhat.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org, akpm@linux-foundation.org Subject: Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h Message-ID: References: <20220715150521.18165-1-alex.sierra@amd.com> <20220715150521.18165-3-alex.sierra@amd.com> MIME-Version: 1.0 In-Reply-To: <20220715150521.18165-3-alex.sierra@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 4162440017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: cwhm1gtznw88eq1dped9jyaa54qniz4q X-HE-Tag: 1686857601-681966 X-HE-Meta: U2FsdGVkX18A98eTuT+OpdX4mOjOhxw0YWuxta/h/F/d3fIXd0m4++O4De+QVT0v3s0uNxCMXYMpyJwE1pZ4cP7jIByyHy5upO6BNNqPM70dzTMuPxvHirKAOxcitBe8THDR02DTnlZTwXTPSTHLvGBsAyvrXt5cte7zFQe6yBtIphz6Fad52dPwbmPTbBF1Q3NZ+6sFRLRhKIQFdJRP8eSgfOilrIV2k37JnTSuPFGB+M0q76xnQ+XuBhze2AReUwgKeTdtyEuFaZFcr35DjYomdhdXukQ4nE9OM/8dwCxwlJp1vWbbYMeE3ngZZHviauO/FCP8GN4XvYTWKmAAGL+EM+WhmiFNbocaapItFCPp2fQ8ezwvZ6loHuNXFVtJt5t/Mh9xELS1dCZGUPxRrNYaHL5NdnFoQLB3+A4th2adMYdILYdTiDYXMp4+085iu4OI/gR9cOPGZjkc5oC+umVt1v2LxmELLR2AbzFxi2RbXq2SwSe8XmXTnUcuBLP2MTeDpJg8bLXzNuZ+leadGkeGr76q3KY98fWwu16SbihWoC1VQdwYn+oHnek5WndbrR7AWO/Jqi2ASwf7db+BOsAuk4QBQBMH3SrtmJWil8lLciYXF/T+H7lR+Zz0rQ00AoO3sbM61st83mIrWwzi34oLwlsxQ1WtR9AtFcRD/RNe/h299YxQ121PN9TbgdeKLKWM5W7XuGVX9IhyzyBXS9R1OAiztlxV+RXyVn8bYm0IOHWZEgUyZrOcquAXdDcS8+YabtrgNZ7QzVUPFa5tPWs7uZsyM5oWtoTgPQIISeCAb1VVTotDTmeOxkJtZs01HXG4KKC34OyUhApFBmoGbbmID8tDlqdmUNW/9ckOjfFF78XXu+X9XMl1dXgLLUOz2gEyf4RVD0bKr9iuRp5CP9otrIne9QOMSYv4aHMqeeisymay9BwHiudHtGwtRle5Em8uxjJ6tWc9UHKze3P 1G1HzmxX Fb8FvUD5my42XLCfZ0ITiHAnWCHio/jU7XsfqFyd2OnMx9k5JqeLmOHmRf+eZvJhE7IvFvZihfWTsBvO20qETANjAYVxU3JYpz757ydQvQ6z1Z3pi4297J+p7sf9nMo7G1h/9V07M3rzS6aHyuwZFL9NvXC9oWtJ/WPZnIkkZ88Ax9H/N68IDDnMV3540FJjRYaB/TwOL01ao+LJfuhRpc03vKfa3q2BINFArLdzYi7YcyHiDaKlMP/nsS/zmwxMC3Nq6YHgX1OxzHK4pN83cQTZvCrUEuaaWz55GfVKotVN06ArC6Ir7F1sD6TpK/ruJAhMCtqQv+rg3iuK43blXB1/p+Rzb8Ve4BQbGmUZLcVO/oZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, all, On Fri, Jul 15, 2022 at 10:05:09AM -0500, Alex Sierra wrote: > +static inline enum zone_type page_zonenum(const struct page *page) > +{ > + ASSERT_EXCLUSIVE_BITS(page->flags, ZONES_MASK << ZONES_PGSHIFT); > + return (page->flags >> ZONES_PGSHIFT) & ZONES_MASK; > +} Sorry to hijack this patch - not directly relevant to the movement, but relevant to this helper, so maybe I can leverage the cc list.. My question is whether page_zonenum() is ready for taking all kinds of tail pages? Zone device tail pages all look fine, per memmap_init_zone_device(). The question was other kinds of usual compound pages, like either thp or hugetlb. IIUC page->flags can be uninitialized for those tail pages. Asking because I noticed it seems possible that page_zonenum() can just take any random tail page as input, e.g.: try_grab_folio -> is_pci_p2pdma_page -> is_zone_device_page -> page_zonenum I'm worried it'll just read fake things, but maybe I just missed something? Thanks, -- Peter Xu