From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F326AEB64DB for ; Thu, 15 Jun 2023 20:49:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51CF36B0072; Thu, 15 Jun 2023 16:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CD4E6B0074; Thu, 15 Jun 2023 16:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36DA88E0001; Thu, 15 Jun 2023 16:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 21CCF6B0072 for ; Thu, 15 Jun 2023 16:49:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CBEC71C8D84 for ; Thu, 15 Jun 2023 20:49:08 +0000 (UTC) X-FDA: 80906171976.01.E393105 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id A9A33A0003 for ; Thu, 15 Jun 2023 20:49:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JJDf3RrW; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686862146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hKMjMj3FplZLOT+91I/4pBUGTAnLqLsMd/PZxjoHeJI=; b=JN1r3Z7XBjl0DYczgwe7so9HDj24rqFB+0QhzwzRzbndF5Oz1/tXS3T6D2TbNz9qB2GT4L j+YlZ1F6R6iol5VDg2I8w9kYqaSojX5rFPLXHPs7TzDE/tHRB1wnSW4R6AUo3JPbEgBbci 97fj6ARvFmIP6N2nWqGqOYQcd2Hy2iQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686862146; a=rsa-sha256; cv=none; b=U3xwHOT8yBc8Yt2+6F4y80IYXpRUS0RZndVro2dOeZgWNTfxZQl2au7KvUTt7wfoZvZOMx BSeoENCWWUih68X4TCueVul4+UNt+WHxVLBZfW+f9YZsr1MAV+Qn++laJM4X/U5h9M08/u vaMx2SIQdENMyIKL7awmpZ8InP02jao= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JJDf3RrW; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686862142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hKMjMj3FplZLOT+91I/4pBUGTAnLqLsMd/PZxjoHeJI=; b=JJDf3RrWU49HLeZn4B3D4726S5zWyUuhOXeeOYCuNITA457mRE/sJ+pyF1nCVRz02Vprh/ 0qlLIOMgzt1Ea2nPFxS4AlWKCOTV/YKRxWSjdb9IdSLwLygNsTRDjXLWXSIkoUz5KQIz4m rMxEs3CORcr5966RZKutZclA0hBYgHo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-PSZAIYkpN4atAGTmM6G8ig-1; Thu, 15 Jun 2023 16:49:01 -0400 X-MC-Unique: PSZAIYkpN4atAGTmM6G8ig-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-3f9e7a1caf2so48101cf.0 for ; Thu, 15 Jun 2023 13:49:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686862141; x=1689454141; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hKMjMj3FplZLOT+91I/4pBUGTAnLqLsMd/PZxjoHeJI=; b=iVmxExq4ovN74P0xCaA1eRe1XwMcD9KGUEHtaeoUsOmCq+OcWVlqhXyNuTi52vBbpA rWOg/V7OcXAd14gnXRDPP3aKpl/gFN7rhF4danFqu6mRq0GpNyBrqqXvGFMPjrJjCqsx 8BOZECKmXAwCxfEW7etL3utS9Oi9cUu9QBGFzAT1uU6zYiBso+2yqORRpWGge51PsGmb vgZ9wn01/csbEra1I5lFbkno+lCz69sDze2QmZXGe1jKibR3x/16ncj58uuA7XdGgc6p iolaBIPHLAa8eFfp0ZMFl9kpYqO4tT9xo9Et4HDW17ZSYuz0FJ4CYbRgAoCevRl80J3W msfg== X-Gm-Message-State: AC+VfDy7VPWOGmyRtP1z8tMLgqSq8WW5056/k6pNr8nvDo5sKaFmREZd XbnuOOaZOQzrjjIX1Y/euVuwgS7oG8DUDOji4ZZtlaWDm6HdtuitDQSD7jZ9uZeoNbk+EVoO4zQ 3YvH/Amj0egM= X-Received: by 2002:a05:6214:411c:b0:62d:f62b:907 with SMTP id kc28-20020a056214411c00b0062df62b0907mr205915qvb.0.1686862140900; Thu, 15 Jun 2023 13:49:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ67Q0T7UNcg441S5K48ufQ95OaInqX07S7iw3hjgHEcSdnXpq3izlYE7fKD1k9BhKtWSVJMmA== X-Received: by 2002:a05:6214:411c:b0:62d:f62b:907 with SMTP id kc28-20020a056214411c00b0062df62b0907mr205893qvb.0.1686862140601; Thu, 15 Jun 2023 13:49:00 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id d24-20020a05620a159800b0074a6c29df4dsm1117082qkk.119.2023.06.15.13.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 13:48:59 -0700 (PDT) Date: Thu, 15 Jun 2023 16:48:58 -0400 From: Peter Xu To: Matthew Wilcox Cc: Alex Sierra , jgg@nvidia.com, david@redhat.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, akpm@linux-foundation.org Subject: Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h Message-ID: References: <20220715150521.18165-1-alex.sierra@amd.com> <20220715150521.18165-3-alex.sierra@amd.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: qcazfkyhnsb9118j8pbhmes14c4bd34s X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A9A33A0003 X-Rspam-User: X-HE-Tag: 1686862143-320331 X-HE-Meta: U2FsdGVkX1/s2acnRfU4P47ZuOCnFIyp0/niQLfO/ovw0zaXklpRhEwSiBOJWSf4rfQTICNfd87A6wqhK4MfWCBQxvEXo5oItOaMcwByQ9qbgU4/x9vkAyPnglmmgdDFmnJjH4RzYxNsF4dAEr7Xd5sL/r6ZwwgV7HYEkaHyYgvm8UXHWsyK0ncniowMGJDFe4xt/F/qCqjyOUKQx+R40k/hqQSNv3Hm7+8O5/o46K46PySk8O145m2thy2hjbG+KEWHwgtF2B6jI2W7q5g7kNko01u+sc4b0h/VSRvyoRa+ta4ar3794kiCb5Vz6zje95isbw5Rw1F/F7Cdw9wYoAHF1O+FqICaxE8KoS06ckzjAsyDOeEfj29cssQO05N5PzkXn+9wxTA0Y0xAW/Xv8SKqHgbpdCVnuW+qhHxfKEi+wkTqbsEihvPiazes/u2Ajsh40NXVws1PniXE+ZqEui9ub9Y7tXzViToUrvkeM1I1fFWZe69mBriYkGpXL8gZYabsPuch7Q4rYUoKQXXAuzI2ywASoQMTRli8W/65xwzMpYKq5bj9BbYIYENLEAERO6+nikI/b5Oj/lhCpdiEX/Ihrm1CByCZYlGU4UVePkxZhqtHAXPAckAydaIhNtHs19roZivjX+B/+gbmFZHcVxiP7bS8C8ReOHokk13zf/zV4nKoakvL5C58+nCrPbXUeIuAXjOmLSsZS2836ZwXM8IPVNXNMg/lSdYuUqqTTi2g1HZuIa2jL9RXkxT/7WnetOcJDnbIS9/k2hYF51Aud8Ty/znx0mkKp3Fe5Cp/SytKQjJcyZ36csRT9Es30yGbJbqjAv840+cw/peNIRjQgQ/tsgH2FTniSNp8kO/dKSGZ4NE70brW/H0cnA6LHTNgVgwnl4U/wONFG9KerKDip9ewyAEdp6a+aoWjGxTzIIH4t7m2rFzOvpeIHuyCFQFxf/NgCSIINg+ri5mW15C 9v+bs8XL 8zob/gqVFieSVnSr5CZJd32zz0pLb29d+FGTWJjtphMMWn9jH+C5UO0zHciZCfCV/7MXCqEXuLEkZ3Y3R1VJ7zeEH8LVtFYQHFA+jDvXZ08OWQQfPMO63/MpXxDn00x+uZiRmah/EhmcHzJ8dKW4dAwpF43+tdds3/Q79DrRgqAJSnft2kk+xdGmUWW7fXr5EH4nbwEmNQu5KaGF+8LU9+mxxurPeVA24bP9O9KhvIiB6AikREI2jgOmcCuf7tYorlLKanOdLluFEfBkH62fknxOG82oAeTMQ2SkSbFghN2YoYX7KYQNBgy6YZXJ6Nt9GI3Nitra6UBHr1Lm2K4BGfFjc5XkcuP34O261+NrrprcSFiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 15, 2023 at 09:15:26PM +0100, Matthew Wilcox wrote: > On Thu, Jun 15, 2023 at 03:33:12PM -0400, Peter Xu wrote: > > My question is whether page_zonenum() is ready for taking all kinds of tail > > pages? > > > > Zone device tail pages all look fine, per memmap_init_zone_device(). The > > question was other kinds of usual compound pages, like either thp or > > hugetlb. IIUC page->flags can be uninitialized for those tail pages. > > I don't think that's true. It's my understanding that page->flags is > initialised for all pages in memmap at boot / hotplug / delayed-init > time. So you can check things like zone, node, etc on literally any > page. Contrariwise, those flags are not available in tail pages for > use by the entity that has allocated a compound page / large folio. Oh so the zone mask is special. Fair enough. > > Also, I don't believe zone device pages support compound allocation. > I think they're always allocated as order-0. Totally not familiar with zone device pages, but memmap_init_zone_device() has pfns_per_compound which can be >1. From there, memmap_init_compound() does go ahead and setup pages as compound ones. Thanks! -- Peter Xu