From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C7DEB64D9 for ; Thu, 15 Jun 2023 14:20:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8116B0074; Thu, 15 Jun 2023 10:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 898D66B0078; Thu, 15 Jun 2023 10:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 787616B007B; Thu, 15 Jun 2023 10:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 69E8A6B0074 for ; Thu, 15 Jun 2023 10:20:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36536120900 for ; Thu, 15 Jun 2023 14:20:55 +0000 (UTC) X-FDA: 80905193670.26.096F4E6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id B8C82C001F for ; Thu, 15 Jun 2023 14:20:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=i6Q6AyW6; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686838852; a=rsa-sha256; cv=none; b=GAnEb1gcPJ9xmlItnXUtff1SqZldOqMbMgY4SWa/yqaI2Xjijj1PI5dxvLz6Nt9BCSIE/I 6lmD2cFWUdef4DE1u7zoGcFuf/cEtcKairi/sWj7ZXumDMOn5wKGmJBdMHa25KTr+b9xUm uw/LpnTdxsCMNfgNvEXUp//iKuMhRBc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=i6Q6AyW6; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686838852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYNb+3lcXJf+tmIIl6IAONhkS2Go6YZm3aE1o17Tx0A=; b=YpJcykgdvTJxMeioGiNZ5f7VoRflSedlLbRauzXHqvy3y91gea7xjTItX7Nud5vpZKD25w GIjjO+jH/q1DfPvFTnQLTNJWTO/hliVww1xVyGbXORjiMRvS2eiPbDSyUM9j0HTIkcFu1z HITAZ0J/AtBkKmcmEcbeHUtzW4jgb+A= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B6F4D22419; Thu, 15 Jun 2023 14:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686838849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYNb+3lcXJf+tmIIl6IAONhkS2Go6YZm3aE1o17Tx0A=; b=i6Q6AyW6froqh6nSV3dqpjOES93TieOrn6KNautrpznUQXQknQJXaBvo52jnrGscCDZcQd By/QcC1Qht88TU464BUEvMDSVMN0gcA6j+0rYH0Ztjd0+9qlVUi2r4BdZkl6hpA9T3E4lR k/BcVw+6IDMNQBL96wJiGXclpPkqmXU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AA1A713A32; Thu, 15 Jun 2023 14:20:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hODMKEEei2QpcQAAMHmgww (envelope-from ); Thu, 15 Jun 2023 14:20:49 +0000 Date: Thu, 15 Jun 2023 16:20:49 +0200 From: Michal Hocko To: =?utf-8?B?6LS65Lit5Z2k?= Cc: minchan@kernel.org, senozhatsky@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup Message-ID: References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B8C82C001F X-Stat-Signature: 5gp7p9n6yscwjrwen9y5ropks9fn9k4e X-HE-Tag: 1686838851-929175 X-HE-Meta: U2FsdGVkX18o0blk1rphH4SKXVC+g/GKOPZLvKhF2URZMNdDamn8RI+PJUfr0AXMhCZt5aYA3V8Io9NENKpvJVmpgX9KCeZ+LIjAGMGSFdHdiFZ6sqGO+tUueatx3k0DC2tsIKQ1JLbLGpmc9TXpXELFEBedvPuwuNz4UkeLzwIJ4UpRe5lWYWtMszQxb12h8JGucJB8WVV9tPYfv1U429E7qhlIf1fskscCV9IksmHO+uPvxkfqVCo8M+mRpcpFMbnWUm759z4h+wwHsFv5gFV61m41Prq+ancXitIvKkhzGZIJHnHHrDaBNFUPJsIRZWE/Gt70NFNkcbQrZHWn1SWcJeWLXt7+BtaunU+TBxPHIqCVsmK/6Qghw1q41I3Q9iDCerueoCZwxb+M/jpI/rGnvx5to6ln0p9u6fB0+LiauSuh8vXZ4tOnv4x8JtRbhyHSMgExqgtd/xAvQUfmiNNJ8/BZeE2xX99H/FATwJNI5IvyUOv5Uy8jJ08aUjEbVl85zDj2NB/MiaG5r/UQotG2qDZj37Wk5wlT0n+UW0hHBDG035M2PkkMK9pq2ZTsZoMLRxWXP2+g5g8kwheDqQTjNrLoyDXDID5yd21+jfzuklr/7H8bbkdLoXFvTKTYcYi7wZprki9VLcs3z2JrF7NvG9Qcl4ga7cEaCqjmk3ql/wAzFjOfoaILzEDvHqAJfoLK6XFbZfWOVD+BxPzy3IICnUgsXGVG1xGMRsJVtB0nrZwf3mbn2UDd5/2uKPSkkVY6To39C18f7GbuBgzdw+63S0Mc8wS5k3d6CWtYW8WOmXIyhQ79/84VK/8K2DYHXiaTq/8OGw1ddmjEFPqtyCPx9Uhx9au2E4L94Bl6Z/tMHZXMbNphRgOuLQPZYfg9HcZyndO1eggwMCSkm4/OAhoMym88P5d1g/sQmVtZ3gIXjl4IhXIVuGoR+8o76p5yd6OLXDEZLlq5syjqNQx bXzrLmZS drdNjKeyILPSgYduYACLUCcg98Q+FMckCbhsXKR0MJa3ddL2EvsI2J5doOsALXAPcdBVXHBeIDBYrdPohi9b39eHxr/DkjeD6feg4DXju5UQ0RyJo85wnpqj4DcPqmx2mNN6FJUpIwjT+Qbw8eU3zeXRDCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 15-06-23 22:13:09, 贺中坤 wrote: > > This is not really answering my question though. memcg under hard limit > > is not really my concern. This is a simpler case. I am not saying it > > doesn't need to get addresses but it is the memcg hard limited case that > > is much more interested. Because your charges are going to fail very > > likely and that would mean that swapout would fail AFAIU. If my > > understanding is wrong then it would really help to describe that case > > much more in the changelog. > > > > OK, Got it. In many cases I have tested, it will not fail because we did > not charge the page directly，but the objects(like slab,compressed page), > for the zspage may be shared by any memcg. That sounds like a broken design to me. -- Michal Hocko SUSE Labs