From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55AE5EB64D8 for ; Wed, 14 Jun 2023 23:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC7F98E0001; Wed, 14 Jun 2023 19:55:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A786C6B0074; Wed, 14 Jun 2023 19:55:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9406F8E0001; Wed, 14 Jun 2023 19:55:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 85CB86B0072 for ; Wed, 14 Jun 2023 19:55:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 47CD3407E8 for ; Wed, 14 Jun 2023 23:55:30 +0000 (UTC) X-FDA: 80903012820.02.0ADEECD Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf16.hostedemail.com (Postfix) with ESMTP id 7776B180008 for ; Wed, 14 Jun 2023 23:55:28 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Pf4mNAMn; spf=pass (imf16.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686786928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cp8A+EkiL0VYJVNToeqPquceOf+WVhmFookr8OmaRSM=; b=nqtm0BzSy+Voql6P4lPh4iafIUXOoVnSKgdM5Ngfa8GLoLf7AtNEfEjg/j52QE/kWuJbk+ T94a8sMlnn5jWWJFCtaRhO2s4qwPYDedRn1QSyRvgYNv9JplvyS5Cp0d21r4GU46nUDxM/ pNXS9Gvg0w/g3mj7ibVCuT8WFuefvx8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686786928; a=rsa-sha256; cv=none; b=Y+F69cpYQycjjFaThT5qg1V0OksvVcUIW8ON2Y3qKlewifGMuhlaq8wpinuosH2MK6qDFi nH3s3dMkLMWOR4/ztwkNrMT0BZ7B8Ro5jitrEk/uzsxMv4UJWQZZfDLIS0ils1NrGA7wN3 isPZ0NrObulDq2rTP1VIOqPV5kPvLXI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Pf4mNAMn; spf=pass (imf16.hostedemail.com: domain of isaacmanjarres@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=isaacmanjarres@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1b4fe2139a8so44755ad.1 for ; Wed, 14 Jun 2023 16:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686786927; x=1689378927; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cp8A+EkiL0VYJVNToeqPquceOf+WVhmFookr8OmaRSM=; b=Pf4mNAMn9dp36uBXyHz5uNXAjSQ4WYXHKBb2JMlBKTTRzb2BLWNto0F8B2d2/+tVBB IISvciJ6L2DBe+qRhbWFmtkLfrflUm/aUmxcEfxGIwEUPNPUb2rfS9cnniqVH3GNjo5u JELvww7og3gzZyrQzIJfpYaMKrhKTNlk7n/q9e5KAxJAklyLW8Kiyed8IiqRv4thceR3 Ale9dLKP8uUuLq/J8kt95IcPg1U+DE0y+l0FjjcShQZ/aErLILik0i5/r+nytzfRPAgd 4Y9+M6DlE4l/z/Ty3v6/aY48Ov8bOB2pMIngjCGP5oGtmY5bpI2jbrEDOzqPLWRFyXZC tTQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686786927; x=1689378927; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cp8A+EkiL0VYJVNToeqPquceOf+WVhmFookr8OmaRSM=; b=kKmA0ML655yg7tiHyD1k0nirE4feSjxLYLpmmD2MYb8n+yAb75mQYfYjAjehYDrfqp T2UrlwWRv4WbStTrz1Q6y8Q7Tul6V2Fmw34ucnWkbRlbAPhceJyO+TE2K3Jpo0FD2LRR sz6iqM3bVD0wrECXa2BWGvhWChVBdSZYOIU0EytbU2/gAAUcO1bLDNASlB6FuosSM6h1 wocfVF0fy9RS+NstXZzXb2uzwQK/fuyApxtRP+0EpIeKDNdb+hqsei7iUmGHn67rnHEk zbNp689Iof8ptfTACdbH9Q/ftICPRd7Q9uk3zm1Gkc+kFra2/GiswTUsRkdYJF9V5jnQ 15tg== X-Gm-Message-State: AC+VfDxMPDbjfBvCniAdHmeHrC23Pl8nVVT4wKsxznIZl7Co9ovOe6Mv c6bCr/CRdFM9iui3vGFnB7ZiKw== X-Google-Smtp-Source: ACHHUZ4LZ3tbRG7AocVYuv1WtNna6ocaxw45maUfrbQyz+pehk7SJKYGZchCEC1ssOUIwjWnOtBZrg== X-Received: by 2002:a17:903:5cb:b0:1b0:4687:ba19 with SMTP id kf11-20020a17090305cb00b001b04687ba19mr108329plb.10.1686786927017; Wed, 14 Jun 2023 16:55:27 -0700 (PDT) Received: from google.com ([2620:15c:2d:3:ac7a:bf2e:1950:e94c]) by smtp.gmail.com with ESMTPSA id b17-20020aa78111000000b006542e358721sm10853520pfi.186.2023.06.14.16.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 16:55:26 -0700 (PDT) Date: Wed, 14 Jun 2023 16:55:21 -0700 From: Isaac Manjarres To: Christoph Hellwig Cc: Tomonori Fujita , Petr =?utf-8?B?VGVzYcWZw61r?= , Ard Biesheuvel , Catalin Marinas , Linus Torvalds , Robin Murphy , Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Jonathan Cameron , "linux-mm@kvack.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , FUJITA Tomonori , Konrad Rzeszutek Wilk Subject: Re: [PATCH v6 00/17] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Message-ID: References: <20230531154836.1366225-1-catalin.marinas@arm.com> <20230609101156.6f17e3c6@meshulam.tesarici.cz> <20230612074755.GA24234@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612074755.GA24234@lst.de> X-Rspamd-Queue-Id: 7776B180008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7s3qkpgqf13cbgqsfeh6jmse1oundtse X-HE-Tag: 1686786928-289601 X-HE-Meta: U2FsdGVkX1/2iALn7Sd9wyNRAoBI6x/DJliylvJhCJTREro8FPtH+D2WWt5n2a0WbnD8O+lccE66kYyNim7Up9LkKln9oftWZ2D/9Ely2muYDBosUK1+pGDNSk/yP7yFDXzUf0pjXBZF12+EkWbIVer8Llu/51foe7h61uU3g/hEcBrGtCGCM30DJlrmyardI1UWJwfYVR0HJQjNCfDGelA8jHGwUzMhpORi7mOXCrKOZ/5rHWfk1qdFwbRz8GdIgd7T9I8BCwSGpdxnPfsPbW1hzS4FXE+zPPSJ2hxWLtrgfyYo6y8z07NkIMkq6roZxDG4VfLhT8RqGOaI46XnKaZye/9sWActvmNL35hWKcN52v+m57pj9eW4RW+iyJKo7HXrm2tr90m/WXLw2QKbTG2nMIdg1hmdv5ml2FMRX86DePmmb/LPmIIVHN6Y1sZzHmChyeOVbV1NIIbTSVQ1qOdfnJWe3WBI77+XQd9MgPttojcyWoTuwsj5VnJlR7XfcBNJjndaLHRx4i3VNHjTdTrOD9dHy85pVYHvnqG/Nctvv8EGy/7cXAyQSPdtDmF2cXrcuPKQGpM59Il5TB/c9E6JUtgNp5Ze4Ugn4/eGudd4uV78G1m+jjrsdgutE/hTlSc3+GHsVxFFmjIpY2KQB4CAzUzxmciKC+vvuNI1JC2JgHLzWt/7iHntOjLhUnfHyApihbnWphvpqNlCWn4KXMGh3P4hTFrlGWuCxsmc93BPMZEDhnTrxlxX5/5+n27SZqVtCMsoIRPnOrTVY9BfT6TuNOHnzwebEQYIqxP1FiBrI7ZPAbESScxWGy8JXmcwDJhlspgg6Rmiowl4skIZuwu8FIok9MrQxmf2PwWHLV5MobSk6x06fYz4Z7EjcsX7vLzLaHOWYTJ2DJoWrjQ7tKnQ3IzZbAf+pCAzCeNC3lgd+P32Qg8hIsF2F1QLaIGjZR/PVvwFmGlJjlLg0JT 0+0wnXTW Lri6HpEj6XCCVGfFLdjqbmQ5adkC0cU9QTL3Q2pT5ub7Z6/lpSxE/DNrrwpUvxl8lbE+WMnS8TOScd6Qz9RDmQjdEYYoy0yvcp47aNRh3kaoUb7rqbuvddtIAmT/DOLWtweGmwOtpH/s89T7WLTco1vdFPlYrQxd3ZVeMYeqKs9istoZNqStnGjEHo04W4na1sxeYQYPnng1TBNR4CKgnl9Vw4YCTcqSZCIKUnDeafaNLwJKwNAGB/beQQVoXU5d4YPvXtcH9+n3D45b9LwYaZO0QOtLEPtzedQ05MsL/NoJrunZhXTadRejGltoC6WI42o1UCmbsRBsJ/rZP7oHzdWM5bVmHRuvjLg5vRYqbu7SF1W6JvyI4rAZtZYxIln04N40Esbh3Xy/hBHkKSuJ4UKmJIjECqGiTjPeh8fN2VohLjpKnN6gKh9zEu7GLU1T+5dlsufsNX7y8iro= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 09:47:55AM +0200, Christoph Hellwig wrote: > On Mon, Jun 12, 2023 at 07:44:46AM +0000, Tomonori Fujita wrote: > > I cannot recall the patch but from quick look, moving trace_swiotlb_bounced() to > > swiotlb_tbl_map_single() makes sense. > > Agreed. There's actually two call-sites for trace_swiotlb_bounced(): swiotlb_map() and xen_swiotlb_map_page(). Both those functions also invoke swiotlb_tbl_map_single(), so moving the call to trace_swiotlb_bounced() to swiotlb_tbl_map_single() means that there will be 2 traces per bounce buffering event. The difference between the two call-sites of trace_swiotlb_bounced() is that the call in swiotlb_map() uses phys_to_dma() for the device address, while xen_swiotlb_map_page() uses xen_phys_to_dma(). Would it make sense to move the trace_swiotlb_bounced() call to swiotlb_tbl_map_single() and then introduce a swiotlb_tbl_map_single_notrace() function which doesn't do the tracing, and xen_swiotlb_map_page() can call this? --Isaac