From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFFCEB64D9 for ; Wed, 14 Jun 2023 15:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 368696B0074; Wed, 14 Jun 2023 11:51:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3187F6B0075; Wed, 14 Jun 2023 11:51:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20A638E0001; Wed, 14 Jun 2023 11:51:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 129896B0074 for ; Wed, 14 Jun 2023 11:51:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA2DA1A0191 for ; Wed, 14 Jun 2023 15:51:34 +0000 (UTC) X-FDA: 80901793308.18.DBB7FE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B13EE1C0026 for ; Wed, 14 Jun 2023 15:51:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PDppFL9x; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686757892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gx5mIGJbC2RshKNPwZeqJT3qT5qrlHQNaZU0SSca/wY=; b=wk2JVWXxvhFZmKajzgd/xx79gE1FpS7xZ/8CqfNOfENenKXebJQd66qf6v33qh0AGRxLY6 0lco0nsRbd/b4/PqYe4u/YYt8eRvB5RmFnWFGLNhudlP6WJoiNEYRCZ4//imvJMaof/2JO cVbWSVtqUclqueTfuobJmfYDUHFGLHw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686757892; a=rsa-sha256; cv=none; b=3VCgWqAe1y8RmwS5e9K7hEZcQcIVaCL7HyLqjaf8VczmnZCXBpccTVB5Hv6lZuqgSQOEaf bHn5KqlVNK5hylahRzclckRBVWZpRPwjSB6Mf1921SytjIkji3LTmWnvAYEw9wDEzKqNzF YRwEbulJ7+4m2K/6OTNUgHETKo0T5AU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PDppFL9x; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686757892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gx5mIGJbC2RshKNPwZeqJT3qT5qrlHQNaZU0SSca/wY=; b=PDppFL9x0lA7sSA0kDBgZxRCBtzvcM7Za9gAR/SOg4oozOtno6oJST+F1JTX1y75ZSGx01 /rnKYVzdA1mexonF1CpG/3KYy3Z1/WcDpLG4JHBG/kdsygznfCChYuVChOvM2PTRKs6ni7 ZwysWeIAXYtr/m/607zqztcJ+yKgMA8= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-4TMTq_GIN1WSSIcLNG9yJg-1; Wed, 14 Jun 2023 11:51:30 -0400 X-MC-Unique: 4TMTq_GIN1WSSIcLNG9yJg-1 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-786e0c87328so167632241.1 for ; Wed, 14 Jun 2023 08:51:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686757890; x=1689349890; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gx5mIGJbC2RshKNPwZeqJT3qT5qrlHQNaZU0SSca/wY=; b=LDBZ9nbVD9m4L0oZfChWI2P4SAjuZkqb/Xl416xP0vNW8/sBGcxIWkrgSAIQr1iexx rqhh4+XzsDqmxsVmoFd3Vmd934HTJwHH3ZHgLT3m9W2y4jx42xNay10WvYtJmH5IdSuC PxTakXVdhdEnfzOpXzfitVdsb6tGRF2owU2/H0EgvdS7G8Z3ZwWNy6j3EaVEI1E/AI3I JtnTK2zo17yMZY6L9s0GKIW8dzqs+KJDhCIkzT1pSAnd70lD9MD4Zhp6y4BYCiIcZbko jdidZ3w1GASZ2MIc8evBGTt1eLC2ku4+b2miy7ltR/4co3X2cIiWYI8Ad0C1mDoDV4YC aZfQ== X-Gm-Message-State: AC+VfDyFjAI6AGNy52WlN9V5j5s8Z7g7N+yrZiYLNyHXfJVncqsiHgME S7Khs6Q11tLrVgd58uGG23qlo7SNZB6nxucKF5x15p16dLycYrdZyzmACQjmVSh2EJihOadr6Z9 xtIG18s8uSw0= X-Received: by 2002:a05:6102:390e:b0:43d:ecba:57d3 with SMTP id e14-20020a056102390e00b0043decba57d3mr5809634vsu.3.1686757890159; Wed, 14 Jun 2023 08:51:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6YWRXgNTEb2Dq8Ia2QatMeTechjbZLoRWlFtVHbRiS/UMriwUxzHyaITTrU68b4zQk7vMUXA== X-Received: by 2002:a05:6102:390e:b0:43d:ecba:57d3 with SMTP id e14-20020a056102390e00b0043decba57d3mr5809614vsu.3.1686757889866; Wed, 14 Jun 2023 08:51:29 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id n9-20020a0ce489000000b006260c683bf2sm1493153qvl.53.2023.06.14.08.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 08:51:29 -0700 (PDT) Date: Wed, 14 Jun 2023 11:51:27 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 4/7] mm/hugetlb: Prepare hugetlb_follow_page_mask() for FOLL_PIN Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-5-peterx@redhat.com> <533c32cf-9a18-1590-4d29-f076d6bd58c1@redhat.com> <38574ed3-ea96-a72e-00dd-4e6204413a86@redhat.com> MIME-Version: 1.0 In-Reply-To: <38574ed3-ea96-a72e-00dd-4e6204413a86@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: B13EE1C0026 X-Rspam-User: X-Stat-Signature: 47bi1xmkzjuo7om4416ndgzyhyxxtxit X-Rspamd-Server: rspam03 X-HE-Tag: 1686757892-210500 X-HE-Meta: U2FsdGVkX1+Z6MGE7MUn71r9N30hLdzpC4YUPghbDlUg85IH0Tzy7nh42ZNF2jzXbEoZHO/hxG4BKNKnB6TSsBaat3d9kYou6AxClSAna458O2aXxVyztf9kwko90syCjY6djgY8/P9aR96yhRDi/BF7f6jp0qZ46qddbfkW2VXIWFRZuNtOEAwZovv2+7s4UjPSw+zdhVJzwCQvoaTTbYsUqMNJ67wUcxaWpt6TYRvzwI1I6ivG1PDAKcVfi0n2JZiW/0VhL1dHIeL53zOC6vxCtD4kC5Yl7Q9HcKDSKaZjZhGFHkCA6Lx4pRi6mcxVIgPkqWpFJp8wkzW3v27g5/tk5znNJy5biwOqF4QTCQ9y9KuMLukIfJ6Y1djLm1k3Al68HrN3l/EJiGmOC+iioFMTqRd5MsDSjz5XyNbc3ga8S/JNKuj4iPW6M0th+8iezVq/8vxhbrg5leR/FPkoSzbNOLrKHxIqPkk0rKOVp1EDefMvSHSCD7HCHrA9AoV5GnZ5h63Zz0ca5whYLLXN/XKZ2SyutNeFLncgYMDXWVpPAUqqLRtFyz2N/zhZ/o2n4eWV0h8pdakKonsR8AmHNXRLX+FhFaK79xMLIsWhU+ICTfNoW4GFgIInw9mtbdz0xzLPOYqOKY7/LyytX6EmCH3d9A4SMH/peZIo12ulQykRskOBx/7rwvkjECkRY5VY8B6K5OZlC0kmTVmZCJlxSwexZZwM+8znkhSHCmqWS8Et0RJ3I11lcxIcz7VcGtp9+k7VzrahzdZpmv2UEphNee49ucARK21Pb275qAzqmSjsMDkA1iqjq4HfEp3w0psfnzG7Z/zXBDrqmvTOtKol5aJZX7xqvyBraLauTh6ekcc+lCmf0LVA+s4sXBbS2OP/ybSvV5Z9gInviPGj37WJk73Nyo+7BEW/8t8DaCKMa8hqpkZKqr61PHST08CuuRP8DSWCkQ84V5OQK+NjBEG ipFrd8EO 3Yq+P1UYY1uioHxs3L89h4KJy2clrSu2qEjathZwSVaBm/oI+zOst4l/ZaJahOasyvwj/D6ZpouxyyJcTNz71aQ7SD1/1NGwzcgH/wm8WNIRC19WyQqaTG13h9927mTRvAG6QiD61MWztH+WeOObqewH25i8G1La2E04Cpi74j2hkwPyUmKV9z6EzPt1mgWvUySCuI9V1XD96NvFlOFTwVoWKyuHCs11nL2+K+pjeoVKc2YIj96RNClp5NZvqt0V+lNq8/Ip2pIaU+cV+2ro6cP+lxU+k/8tVg7vq7QzyNAeBfRFBMfKW4nli8lD0GkVWwYG10ZzXiHVMYMZLG3YtKyQA/kymlphfy8WELDenFFZHN7vJAyT0YGopZ2ziZM/BoqS2DuvDFaYhhevDAwx2ew6+XcgduBcs1Ze5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 05:47:31PM +0200, David Hildenbrand wrote: > Right. Then just call patch #2 "Add missing write-permission check" and this > patch "Support FOLL_PIN in hugetlb_follow_page_mask()" or sth. like that. > > Regarding the backport, I really wonder if patch #2 is required at all, > because I didn't sport any applicable FOLL_WRITE users. Maybe there were > some? Hm. If it's not applicable, a single "Support FOLL_PIN in > hugetlb_follow_page_mask()" patch might be cleanest. Yeah, I agree. The code is definitely needed, not the split of patches if no need for a backport. Let me merge then. -- Peter Xu