From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EF7EB64D8 for ; Wed, 14 Jun 2023 15:35:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E43C66B007B; Wed, 14 Jun 2023 11:35:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCCA76B007E; Wed, 14 Jun 2023 11:35:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6DC68E0002; Wed, 14 Jun 2023 11:35:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B14FF6B007B for ; Wed, 14 Jun 2023 11:35:27 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 78B2DA0701 for ; Wed, 14 Jun 2023 15:35:27 +0000 (UTC) X-FDA: 80901752694.13.646D080 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 45480A0012 for ; Wed, 14 Jun 2023 15:35:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bsBNsPAn; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686756925; a=rsa-sha256; cv=none; b=zZ6AxGWBPawYr36Ms93bvXEj5QqTMq2uzR3U2qnlSFkYSqtLEbunpFWBY7f5KIJ1oZb4eu +QhXaO5u25sahHd1aBZxX/vj+xtj9MYM0oRmphN5FaC9FeoG3Dy3fvwmAfQVub8OmW2b3P qopEKmW3klemlcOZtyPDXtbhns5aIgg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bsBNsPAn; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686756925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gmwzH0CjVLzqwLy7siJrCROCQ7j4iPuuS4OQ5spBH/E=; b=Ykc+Xc2kco/Y8aBRo9/YDS22Yb/FzqL2FTRnO4aVaxntKjNy7dU/NBNnUtqOpvo1lvGcA+ N1fQ0Lbp/IznJlTaJujTR45DeIzGn769VzXbytLeVQAoxmHaAHWxRvWqLcCJl7y6urG827 +M2XNqJEEj4LoS2mjMSp7GYcmRvOXuE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686756924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gmwzH0CjVLzqwLy7siJrCROCQ7j4iPuuS4OQ5spBH/E=; b=bsBNsPAnByAPXNRIUT3SUiVvD6hqGylNBuZfcHc/0HZJOmG2Ov6/fRNxp6Ag59Rxb7GC0c 8pwPma6DuKER0q2LKWd55gFib7lehuu04SQF5laDTbtGMXTa0fBHbRGvApfhxM8OcO0PJE MJy7MkEDkSDf7JftTooCZOgz/Sa8/aY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-77LAzPAjNX25iwFGlabuDg-1; Wed, 14 Jun 2023 11:35:21 -0400 X-MC-Unique: 77LAzPAjNX25iwFGlabuDg-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-3f9eb7d5202so6391881cf.1 for ; Wed, 14 Jun 2023 08:35:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686756920; x=1689348920; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmwzH0CjVLzqwLy7siJrCROCQ7j4iPuuS4OQ5spBH/E=; b=CcGKxEnX/WoXy+88TCixaY1U+k/b++tJS/UD/eGN3Vmct+4FRtjTdcT4z3uSXe6CXJ HBUs0I/zDGmNhpIJxPnugQllZToI/hdDB8VVYbXSA2yYuI+gdTgh74RjUASjozECEB9J S6ThiFTSBkfcZ+mPT2oyhm/jDGK8LntDcwHZ9GXU6l23OmK+QdGkCQ25XbFPe9BHdnKc vH7jQ65VxXTohppmTYQCkltqzA9VmFTzvFjbpCmlG1A2WcPlDGiwqVTUv7bIWPv16Ef/ I6Q4qNCwyoPpKOCpUQPSpMR97fntP4Pcz7MjnuYN0gWfuvSUVTDs1LteEmaZSTBvo5t+ 1Psg== X-Gm-Message-State: AC+VfDyfh4Ej+nXoIOXZH+v3wvgSOJAW4OeZ3u+/uMp4HWxthaunHnC3 GY20+6tiTIDASqCMF3BAxMcM2TJCPSb5sOGq/ay4sAhPc8eqZ1QvMyiMyVo6d4xRfn0D/EpthXm ckLa6pLWbGiQ= X-Received: by 2002:a05:622a:1a02:b0:3f6:ab9a:3d8e with SMTP id f2-20020a05622a1a0200b003f6ab9a3d8emr20549380qtb.4.1686756920612; Wed, 14 Jun 2023 08:35:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7TJod/VnPoMZiUa7o/El2294sJ8GL00HWcJelg2hFCktid9sv2kfOTl6JXIqQfFSSX+RvYNw== X-Received: by 2002:a05:622a:1a02:b0:3f6:ab9a:3d8e with SMTP id f2-20020a05622a1a0200b003f6ab9a3d8emr20549357qtb.4.1686756920392; Wed, 14 Jun 2023 08:35:20 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id j8-20020ac85c48000000b003f9b6d54b17sm5106366qtj.58.2023.06.14.08.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 08:35:19 -0700 (PDT) Date: Wed, 14 Jun 2023 11:35:18 -0400 From: Peter Xu To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , John Hubbard , Mike Rapoport , David Hildenbrand , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 6/7] mm/gup: Accelerate thp gup even for "pages != NULL" Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-7-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 45480A0012 X-Stat-Signature: xnufxgwqjohdq1dadiy5pj7enmjmc67p X-Rspam-User: X-HE-Tag: 1686756925-952684 X-HE-Meta: U2FsdGVkX1/kY/JoP5fePr50P69O6yt4yrEuiaMtE7GPQkAbDHAky08WKm/y/0xrwLp8wwwhUQZjueiCcUq6oq6j1RkEwWpRm+RvOUkbTlw2zITvOD3mjSB567p22MDW3NnY/7NQ0gID+BwWi0G1cVpoz369TPzVlAp2KkpA3GqQhOhU25JxiiEb7p+NG2UDQ8u8naPvp0GrmuMjf6/s/mq+J/pbY0ToBk28yf3Z1U8xIIw1Od3JOT4sqIQdN6IAZl5aP+ivT12+AxDLoYiadHPJMsduDhSais/HX5dL2Gjp42GjSsbtLRQ2ToFKfWDQHmA/8ki+8JunEU/cGxrYEyUpue1WmYFZfFnzI0OfK3BJXSBqsqsZK0NdOikotp4+GXybcrtqmwvkGPO26oTpAO6Vyt2fClHR0eFuN8k04KbMbeEmZGyru+gYu1vVPhI7yNwLI7DFyKiuHUCKK0rbTxznzqpptFNeoFy9SS+6a5wh9fY2Hl7lsD8H5qYfyxpY4TybuK4AVYc2l08q7H6JqL2YQIz2gtiFsZlA+WAXQ692ocDab9JEDsT7p32NP06aTpR9DsrEi0tOn7q8IPD19NTYeW0ieTU3bsJ01Rwz7GHnoJFQ63o3Il7pz4EJ8EGL4mR748XZOVIiZEwB838AWZ5Zh7yqrbWZk8t5ai3fS5VYaOauVW1ODbXhR1iqpIeIyrUxwAzfLbe2igfjzmzsNHBGRLtCLVXFECgFA77OTNgriexNZjMLYkcI5NEF6bIdaVYkEka01oHU5RN24ThMTVZV+sMDxYc+s8s+/5ZtAcdEUjIfd8GxBYDFJzsI1dVivJmhFg8+52/Lh1/mMztoFg9KKxBzYl32a+WsyT5aDgkcYJnWOt7ek+54cqMmf0hfNwd4G2jeCTbGjhIyg8b4qaBGPfY/Kl7EfraZFaygOoS6xvBZ+e91jvg2RKAMxuf2KA0eO9289Ym9EqMMsVj /Xy9sacq pzDTbMIRtJYa/4qipFQE44YmuzPHwMym3+9Zd7hLyxu25HkyWOFwJycX3alExPuTCXNSIa3nTIzDKdv/6cRoStLersFeV3O7X0BceCdzqpl+Y+niAzfrYi85X5Py4DtFk+pCzadKlqwS44dvivM4xFRGWhmVO7BRvPcQPwm7IAzdXLKbp3uxZTYphDNxluRoiydUj8SrwByzbEgJyRJcZ0We4GerHN2Plp3ZQh1Sf3SVZXgM4ylj2J4uhTsf4ngSKLP+u7t6wKjkcvFRfpK0yxfZpJ22iwaaKMjOjfujjjLXUXfpdXxjzTxnlXGtviXa3KdmKlTWzzqsrQhx3I1YHBv7Pmrti/PgbNSc4KoL1ZqQVijbi5IYyz7QgW6ReM0izNExeFTOPljH/3LaeyjSj5wzkTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 11:19:48AM -0400, Peter Xu wrote: > > > + for (j = 0; j < page_increm; j++) { > > > + subpage = nth_page(page, j); > > > + pages[i+j] = subpage; > > > + flush_anon_page(vma, subpage, start + j * PAGE_SIZE); > > > + flush_dcache_page(subpage); > > > > You're better off calling flush_dcache_folio() right at the end. > > Will do. Ah when I start to modify it I noticed it's a two-sided sword: we'll then also do flush dcache over the whole folio even if we gup one page. We'll start to get benefit only if some arch at least starts to impl flush_dcache_folio() (which seems to be none, right now..), and we'll already start to lose on amplifying the flush when gup on partial folio. Perhaps I still keep it as-is which will still be accurate, always faster than old code, and definitely not regress in any form? -- Peter Xu