From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C16DEB64D9 for ; Wed, 14 Jun 2023 15:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C02B36B0074; Wed, 14 Jun 2023 11:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB2A06B0075; Wed, 14 Jun 2023 11:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7BC56B0078; Wed, 14 Jun 2023 11:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 963986B0074 for ; Wed, 14 Jun 2023 11:11:14 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68B66120733 for ; Wed, 14 Jun 2023 15:11:14 +0000 (UTC) X-FDA: 80901691668.15.490342C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id E60C3C0022 for ; Wed, 14 Jun 2023 15:11:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PHDeukY/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686755471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FVZChglvS+O5VeulYeKIgpHYT7pfIMFY3lkOqv9HePk=; b=o7hwgYLY8NMmmwtZutBB03yJFy1Z8Bb/C72mrghdquHKXgNGl1WMk3sAGc1muhSrpWHsFn Tktj6+2H/+skCmTay0GpLd4QxSgCAjBxB0AiBXWWaWNytYj2LpvyQc03Vyc2m5r8p/ivPP Q2mA0wcFJinUkw0RBbMuKydYAXKhW2U= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PHDeukY/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686755471; a=rsa-sha256; cv=none; b=csrV03EEbvMnYIkVdSn46sAF++ubCXL/Mg5awiwjDBVmhzUFJTBO8ffxhDwAPGeDyModFg cDgdUl3pw8VZbsmgevB/pSPz+pATCwayo95o4x4JM+SDUilPzY5kPu97CfnJauJ7ODbyeA E1yrmv2BPuPed/RlJOdRfvisQRbcV8Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686755470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FVZChglvS+O5VeulYeKIgpHYT7pfIMFY3lkOqv9HePk=; b=PHDeukY/oWG7QdolBWKUO1Ak7OZclBwMd9yuZzU3MQu2SxUOhO5SC7nVwm+k9QsqvA83+s tK/wdp4IYNLMNmwoAsmrM1VfnGB6DrCgnRlLi4PcKT2/HZeIl10nAoAhVxWE1j3dAazkp3 bJVDIv94AwnZOajO5CesujklaYV0A+o= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-BDz5wkh-PV2nQa1nBv8xRw-1; Wed, 14 Jun 2023 11:11:06 -0400 X-MC-Unique: BDz5wkh-PV2nQa1nBv8xRw-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-76077669a5aso77846685a.0 for ; Wed, 14 Jun 2023 08:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686755466; x=1689347466; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FVZChglvS+O5VeulYeKIgpHYT7pfIMFY3lkOqv9HePk=; b=imZAmiGDX6R1RtCoObP50DM8L8X2BsWEClPgLHltT029WylTv1fe3iMN5j/oPv9q1L 7CIt//HNsX6LKlD7D71aI/G4AQrpibrxNzGDE5ju2ZnTld3v1tXitku0YtYzff2AcXYv bHtVrSIyKK+D9B76PwncF7QTiKrZEYNFeQTdI6l1lbG1USjVUwS9nswdaZujQN7VMpUk /HM4QUI7fnZgGgizMOeR1LbH/DW7OjBRNZWrFYdYjzPpInBaLtFxd8zTkgb48CT/oZR0 deWYqnyCJr0AbmL1fRCyf+4K91ysPBem8k6HIt/8k21GWr1WhEapuHyArmr9D+UsZj8p XM5A== X-Gm-Message-State: AC+VfDzGRk16nlhdksHeYPal7dup5rEVMiVQZ12Q7cKw/VlWMS5xCE39 hBfljC0zgOsGxL2TLqc9nuYg9A/RpJ2QmSBJeksQjg5k5ICAxrZRWQOSG3oKwGEbra9MO9FqYl+ IRLvOcVWXRaY= X-Received: by 2002:a05:620a:84c5:b0:761:fc4c:b6f6 with SMTP id pq5-20020a05620a84c500b00761fc4cb6f6mr4259156qkn.7.1686755466443; Wed, 14 Jun 2023 08:11:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ52SBPQPFUhM9K34/k1mW3GgSmlJkXZWl/Xv9ay2wYHAGf/sxrjp6jsOoO0aqMkJmMcXRKYyQ== X-Received: by 2002:a05:620a:84c5:b0:761:fc4c:b6f6 with SMTP id pq5-20020a05620a84c500b00761fc4cb6f6mr4259129qkn.7.1686755466190; Wed, 14 Jun 2023 08:11:06 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id o23-20020a05620a15d700b0075cdad9648dsm4370929qkm.25.2023.06.14.08.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 08:11:05 -0700 (PDT) Date: Wed, 14 Jun 2023 11:11:03 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 4/7] mm/hugetlb: Prepare hugetlb_follow_page_mask() for FOLL_PIN Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-5-peterx@redhat.com> <533c32cf-9a18-1590-4d29-f076d6bd58c1@redhat.com> MIME-Version: 1.0 In-Reply-To: <533c32cf-9a18-1590-4d29-f076d6bd58c1@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E60C3C0022 X-Stat-Signature: ps9dtu4jyrb587cdn8oube5pxptqjwcr X-HE-Tag: 1686755470-694671 X-HE-Meta: U2FsdGVkX1+dh6PFedVc32TdIEOg64Ae+lYp8fhwnu1eZ+4LEG/QXAA5W5XJhzS7IH1zoSIa3cIhToipBQQxczK1AnLKClLV4hnDJaluzUKke7gmp5juMmx6Pl643+5hU1cxiyAsoBtxPwCUSs9jdVWJYUSHKBUIwDREhrJJhf/1+iWwV8Rd++KjISWqMc5B9xTTYYmt5kh5zDANXygh0ZqETSIQKOIsBDzQl6HMFtVAQz9YmRsl9psMnyziLKTqZMlHNCk2UZ21khx3hJhU9PZUM0t+skhEcFF5DK6wKJaAsi1EwNomo780rT1Vvbtf1DzXXrXg8oJGQmNKS/bq8xJd712KPPlwy9TsVW+eBsKRfcXOmj8x+jfWkFC60705msDQGz8WOUDqP/UVyQ0nuK3DFOO3DnY+eKXn7uXbX1ZhhHDI9Dzm2Wbvpm6FHi1fngmNPzn8Yv3in2BHrsPwq3ZlFjPRe9uxg2WrIPaUSkxH15MhAcYaqt6s6j7EHX3QuGoFv3/0nO/T0PH1BrUy4wUMPwynLXKNBCu9BxcU8EkyvdHkK7+IaUbW7t/vG91ClAm3e6o3l2+Mnhi2+f/XdZ7mV8SAJ4Hn1D8AbiAmw8f87AUD7mvYZgmiEJo7kCcoT76v38rUwadU5qrwWyWYk4Ss7c2ukGdsDckEuWiBYz7GlJTF1vBiO8Zjra50uioAxvWA4i0B6JcUObE2UQXrYAIq87anRplhsQNZ8n5M0+k9/fmdVLDQ/o6NayMyzGSSB1ousVX4ecT2RkOEFah3KvlBykNDnNM//9cJkYe7G4FilXHy3/EGAQCVxYld+5gWBALlwdUiF/LxnbsPd4khYirbDRZw5h3rVzR21Trqx/jj2e7HdTgrbPceXUdaqamf9KTQUOH+Vc8XU3TeIFVnJr1zzHn+eS+pN6Dwe9atZEW8Z1GzbpvVzvBTjOhgSshRTL0c/GhKJcaExhZohGt g1Wa7tFw KrOJbnlpHygijPJm4MeyD/G7A4EkdkmPYfLOSsKwUAwmuASIr6DsmNPfQGzpCMpdZIzDK8GdoQjqQ9rgZKhD1ObZ5urME7lGmL6m7vYMAaB7uvPu1BJx3fUVYGdh9P8DHvmBMI23wDiUo3EUe6hRES2Tt202U2/BrHG83bD4Aj2tlU/QF6fsTqqKaDmqaJPT0JrDl+4OQZ+u9cQn6OUIlEzoUV/TBTaEOKAPIXBNsSTxoJ7QzOk6acBdLCXwPK+xaFNNSL9Cxvdzhs9yEXMpahUvKIBQdHDBzGch20xaYqeLZXM29PPEY47oXkWl6FbjDUQxjtJlz+PkP2QvwQm7GhoMRimeNLiSZEG4zxTM59lxc+smScSPRoeC/GvkeUlrK29MnVaBmqqltouMH8pf4uXu8HiM9sqAN1NYQ6f8LFVtWycJ7Oj5WuAv15g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 04:57:37PM +0200, David Hildenbrand wrote: > On 13.06.23 23:53, Peter Xu wrote: > > It's coming, not yet, but soon. Loose the restriction. > > > > Signed-off-by: Peter Xu > > --- > > mm/hugetlb.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index f037eaf9d819..31d8f18bc2e4 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -6467,13 +6467,6 @@ struct page *hugetlb_follow_page_mask(struct vm_area_struct *vma, > > spinlock_t *ptl; > > pte_t *pte, entry; > > - /* > > - * FOLL_PIN is not supported for follow_page(). Ordinary GUP goes via > > - * follow_hugetlb_page(). > > - */ > > - if (WARN_ON_ONCE(flags & FOLL_PIN)) > > - return NULL; > > - > > hugetlb_vma_lock_read(vma); > > pte = hugetlb_walk(vma, haddr, huge_page_size(h)); > > if (!pte) > Did you fix why the warning was placed there in the first place? (IIRC, at > least unsharing support needs to be added, maybe more) Feel free to have a look at patch 2 - it should be done there, hopefully in the right way. And IIUC it could be a bug to not do that before (besides CoR there was also the pgtable permission checks that was missing). More details in patch 2's commit message. Thanks, -- Peter Xu