From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D04EB64D8 for ; Wed, 14 Jun 2023 14:58:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1DAE6B0078; Wed, 14 Jun 2023 10:58:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACD3F6B007B; Wed, 14 Jun 2023 10:58:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BC318E0001; Wed, 14 Jun 2023 10:58:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8811D6B0078 for ; Wed, 14 Jun 2023 10:58:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3C756406A7 for ; Wed, 14 Jun 2023 14:58:43 +0000 (UTC) X-FDA: 80901660126.13.AAF8AA8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 439EE160023 for ; Wed, 14 Jun 2023 14:58:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s+Foz2h7; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686754721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c+DUuKPNc+TCTVK85+ONR9/WBIlqrFGJwe0k+eUv3R4=; b=If/oLyc1oMTaSapr96fTkqiYc1cU+dcAOwhzZvHiHxt/8y4KPW1oifkVC+9v6PFep+Mhlx sfmp0LkauT20B+P/9UlgriofQFT/7t7pL78E+02iHw+U+poKeRJFq0Rwr+CJkrj/PpKaA2 4Fgw7dHJS1u8fNGcbH2D4N4UcyW3bp8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s+Foz2h7; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686754721; a=rsa-sha256; cv=none; b=om4VxvaLciuCVwtyidOszgK8/6iLgwzODbxQZ8aMYrEm2HaQO+NPx8OTLWNGgXYUvnU07G 9htDTB9HHqAljH39IF4WI2J5fP+NKEUDr0QOxY/UIJknFC/oFZgx5h72pgddCwFunmPV5V YsC6ChHia7RwEmsS31FzZVJbG54RuGE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c+DUuKPNc+TCTVK85+ONR9/WBIlqrFGJwe0k+eUv3R4=; b=s+Foz2h710mseAM15VhBFXvVbv HnJzv2lzoy1MDnLHOCJ1NiZO8FcPrZTDVAA8SI2XVCG/6SiXWDm1dJVKw0vRHoQIuP2vr9Xh6Mld/ ZDT/3a5d5Y+J1mlMA0tXUAxHS/4RdplskmthXG+w8QO8eTPwyAf8c/a9h/9oGTmu3JpU70z/7Kwgo K6/iFy68SK1lTA7+veAiIUJCz4ynMQrFINSKE7VFept+g7ONH/qQSNXvgLoZBflIQDrmX28RUm2M+ J/Roi+bORWpHpSJyUknT1GwwzuS+pEelkxjhqztgWf/Gs96xw0g/4eCGot3IKatyqLmSVOsLHXQ/p YnWczeNw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q9RxC-006Rio-NA; Wed, 14 Jun 2023 14:58:34 +0000 Date: Wed, 14 Jun 2023 15:58:34 +0100 From: Matthew Wilcox To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , John Hubbard , Mike Rapoport , David Hildenbrand , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 6/7] mm/gup: Accelerate thp gup even for "pages != NULL" Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-7-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613215346.1022773-7-peterx@redhat.com> X-Rspam-User: X-Stat-Signature: 9izzpoj1jk96ra5qpnaywru1o313wxii X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 439EE160023 X-HE-Tag: 1686754720-779639 X-HE-Meta: U2FsdGVkX1/XWhFF5TwIzkOxQySJ3bGHhKF0TmaV4H9cW0zzccEvKCLQ3SsrSNNvGB9APcZnLePRqEtgP/efQHM2dFuJ4hur39OSXM5gaol/7AVtNIURFARTZHYxGnhK78Z8P+a6UEzql9iVvJhh9vS6BeuhKXjACLZXH3+tXmuWG45ioxg51y1/wustycdR3i2BUFC+Uy4kfinNrTVFBd2Hd+I1Vw8K0gjeMt5xQaxgKkkrXojpHwh45dBaOFbHLslhBBqetk0TRDbP+yIvO6fbmgjDvYZOf05ykVcrovfrI9oPkf+T7+oMS1XFpCjEag7QJhsEMkGZzS0B54pZVrJLOO7W4XY0hnUHPDXxhI0iSqzJpuEON1IocT3UXHB5uAUYBI5gvvppJbcDtOJo+oXFg+KEMBusS8HQ3O4uJzc83mq78IpLfVS3n1yftBrzLsEM4kjMgqWfxOJIEnUusHJE144rc33IziIe9KOnJsOTIscDzf3/kZzq354HwpdgDQ+tv5F7Bhsw/Xj4t/i0oTtuEYXMUMBzedIxwtVVNj03Es7OMBptTARQCCey89ByCaV5QoQRZgeepbqZe0T5MDlw5VfB4zp6/7CK7KmGCjrzYuVAgEkaSMT3uJ+1tqK+qxelVAqR4TOYZ/dBgjiQvgIoQFsMHCrp4mXP5wYKmxdnfLugtphgyqRZ+rk5n6sD4h8udaR6r73/cCNnPndWPm/8RDOftIkd7J0LJWwDqPnfw97TyOnOIdmbnNDH15of9zlOSQ+SpMLyrFhYg/gOnPNN0sJzK+i/tNFy9tb9P0ErbCogS2zQRYk9UxOkirTaKXVGw5zXSCotQDMjv35Ut6upC6ROxs0df3rUWamvTjdGgtnUNiT+FU6LyDGtQD69clvfjkL1GqeXDNp6mLlXXmzlJ3FO7lYN29pXL5LrNSRXFCmPnWpL7M+d551ivPxPxKPLdwjbsh342i//OYZ Z8X/sudr k+Q2HrTT+oN+ye33IRZf54QCvKDv9xXYlhvs0apk6PpqA9hCEFPibyzfdFFDd2zIL1xto49vnRn0be301g7NeTskmbbpIhyAGvjKJVjFLYFLvcRNWmzNUSI69vHQVoDEzARYsYvHI8QpsZ68bRXMRt73Pi6Rgqkyc2Le8IsQgpkoOdlZYU8Enb47olA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 13, 2023 at 05:53:45PM -0400, Peter Xu wrote: > + if (page_increm > 1) > + WARN_ON_ONCE( > + try_grab_folio(compound_head(page), You don't need to call compound_head() here; try_grab_folio() works on tail pages just fine. > + page_increm - 1, > + foll_flags) == NULL); > + > + for (j = 0; j < page_increm; j++) { > + subpage = nth_page(page, j); > + pages[i+j] = subpage; > + flush_anon_page(vma, subpage, start + j * PAGE_SIZE); > + flush_dcache_page(subpage); You're better off calling flush_dcache_folio() right at the end.