From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C63EEB64D8 for ; Wed, 14 Jun 2023 14:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0BEA8E0001; Wed, 14 Jun 2023 10:37:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D94FF6B0080; Wed, 14 Jun 2023 10:37:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0CF38E0001; Wed, 14 Jun 2023 10:37:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AA9826B007E for ; Wed, 14 Jun 2023 10:37:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 63400406A8 for ; Wed, 14 Jun 2023 14:37:53 +0000 (UTC) X-FDA: 80901607626.29.4482815 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 63F8BA0003 for ; Wed, 14 Jun 2023 14:37:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iQFnpbth; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686753470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gyujhLRyZRg2hIoBNu92A1RubEtIut+RN18vb/NDgD4=; b=1Sn+754jnx7PGwCqSN8nPk3jNEsXtrtF9GJPeza5UZwXsgJGvILKaR/RdPY0A3B1SAMaPk mOowYU2/ujdAjx4F58nNy4JlBkrzj4e8xvdT/OWF92QTB9S0J42zyA7tuAfnR2MuKcPuvf aqKT7UgxPj447fOV8lr7gJHgRtctrdQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686753470; a=rsa-sha256; cv=none; b=eUYYOzkVH7T0amfEw5frDnVvAEGf4uZB/2MQlZ4u31lBibCZhkL9sOA6pOJe38adupobjM 3J/x8mkp0o67ICCDqs7m4teceDme1XXP7n+YGZNC2NNnuWQk8LqGpvz5t/uo2DDfIL96fX opx2xiETRNpDDyCi79ls5ULcGsWi7ig= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iQFnpbth; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6665f5aa6e6so473277b3a.0 for ; Wed, 14 Jun 2023 07:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1686753469; x=1689345469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gyujhLRyZRg2hIoBNu92A1RubEtIut+RN18vb/NDgD4=; b=iQFnpbthAVwC3lLw+Vz5Cwabp+JkO7FkrbyZ1Sc1qkFjKTV7BAUnip59ec72h939vt 4q+BHJoB6/j+PWBqHnwefjNokhGRWgl654d5KmO9Lc42nLrxm7j+mvcya+SuY9XglbR8 qQCy2letdDjnOYHPNBJ6Bp2xtbXVRanF+26ADQ/8zjjDfMi3JTyhHl06ksxyk3qDvprj EXKoqWbq3lyTf4e0iXQUS0XnXmZK9DhKPGrzFJzEp5MsABdLsVUYYOHnG3JvgASaROrT PPqu/SlYzRLBdMY49RGq6RAMkSuzS0NC9a+381JGrg1vlpR5pKnGQ7nN4/KVS+NLra7i 7dHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686753469; x=1689345469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gyujhLRyZRg2hIoBNu92A1RubEtIut+RN18vb/NDgD4=; b=JsRQ/8aOjVPvnXZelzvE9BL5iH14YF7OImGW+06+O3M61B6GN0wzOnlXhO3CyScW+z atRB2VlNMlIl3MmMnzrVFu1uct6PtbTHATYR1ZGfNruxyPD/LKtoqUjp791UXL5AM31n Y3yVf0VbHDYTk7Lueoyd6gRjjJ7w7xeRce6v+drTMhA3k8rSc+OU6k2gBqCdBj/KVig5 WPBFUJDQRONExaLgibp/JPMoec5ozTu5Iv6HswBREIsogQVwnq4jn2U6N787LQ4+iapL K93bPKc1HlNRzGdHlmjjnkkoqxCUnN8O6KDajbg4r9LaqjwJHAcNL5GRoN38NfvIND1L Uk0A== X-Gm-Message-State: AC+VfDwDVloVm8sJb2cmkNs/PJ5pjNqW6BqMMxD8y94fe4d8asUwiMAI WxzhA4ng7XA+t5jnNODlOLb69zIWPcDJAN7d28k= X-Google-Smtp-Source: ACHHUZ4gjsy4buH+Wu++ANwpnxK4p0HLM0YlNzqwKgT1nSXYAGD+SqhcEQRWNy9UWTZbvT7d/eIJyQ== X-Received: by 2002:a05:6a20:1603:b0:100:6863:8be7 with SMTP id l3-20020a056a20160300b0010068638be7mr1771480pzj.62.1686753469052; Wed, 14 Jun 2023 07:37:49 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id u15-20020a17090341cf00b001a2104d706fsm12284211ple.225.2023.06.14.07.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 07:37:48 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1q9Rd4-0058kr-Oy; Wed, 14 Jun 2023 11:37:46 -0300 Date: Wed, 14 Jun 2023 11:37:46 -0300 From: Jason Gunthorpe To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , David Hildenbrand , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins Subject: Re: [PATCH 7/7] mm/gup: Retire follow_hugetlb_page() Message-ID: References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-8-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613215346.1022773-8-peterx@redhat.com> X-Rspamd-Queue-Id: 63F8BA0003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8ou5ohyoji17un4na7khoyu86mccdu7i X-HE-Tag: 1686753470-285692 X-HE-Meta: U2FsdGVkX1+c0VQ6BfqmOBaK4Vd8ayXsPBxs0zz63l6pKj4VMwBnWNzLYJPUY9VFrr5mVy7I8gt/4wPhQpTg9a0zaCufbgDLDwRqk6ZUtqtfMc0ttAGlXqWQg9Rn1J0hp4trn+avfNkF5qFBugnM65KJ/RP5wlRBL8cLaYfPttsOQwlondXsCvLxEwEZf4gOFBVD8WeGqPyP0MwPdksPgvOYGHqJkswvFTYlPzwHfsV+4ElVfkHYOYpMLEXaOoIigIorl/Sv7owl0ZEek4+D4om8pmcXw4+kEIkIPAZsHefhg2Of8hqfm6Z0aP5bYfYQOjC2SjSUXcIBCubSLeE4nqK39lR93/KlcQKLa+UbtvSfOqJsqNTyYDl0BS3MwAxv9c+1KqNRo9Xx4ZDlSwf4ZvOfph0AdXKl09m7uyP4NcX2SEyIM2ForBkMXT88PZcoJ9uG41lJaG0GPF6zlIlNqp0AuUEvrGUP+mrdYQC3srEmLtObHm/R67uN6Z8HjUhg5RRNsNCvtxmUppjCMQb2zhpcgQ7F+BELPV9JevSGyJIXhUWJnZGzJG660R2Hfd15BZRz9HezxjsxLp9pc2K2T8F+jLQNIwyMncm8YVHwefmb7qGX+SobcLquGwGyYMjYj1BXLt0wS5g1pbViPlVn7DpnQXuhfjB0TueOhP2UVkWu+YRdOn0zwkjMswZ3Anr7r1jbyRVoE4U7AECrUk0puIK70volpZ1JdVu+Cc9XExnG5Sz3w8BUI+qwey+D2ZStU0cAOU+mBg4vNcDPMpL1zpqUvEnjbNdIUM6nSu4gwAy6+wifZ33zZEolQaDFqNsptShUUNv6lj74QlWu9d2gKS+F4qu4NQmbw09UD49UGvlpTV0sXhB3qUnnrJ4xIO1DXgGaJPhlFi6KivKQJDmLsCs1nKkUqBnL3SDZlICIdia38aR1We62n2V5TH2pDM2bcyu0sw7gVdap7qQ2Rin oHGbL1hI HImIptCBWjlt84yQMp9Niz1PdeYhea1hp1SZC3BIqkXdmbYVhcaVIekTd+Vfj97DojLzs2E0F6sEJNJ6OwfxWlDp916xlMmDoHu+wxY00aIbpVLWyvqjIbAUIh3OW3DMEUPTKhw09xlIuQuOIk+BfsQ/kVUs+fO16MjaATjPGQxtsahwlfMNk7YiBoTnLHa+LZ/K+8qJcmHWHPtrFvqNONoEozq8MZ1eQlW0eb6fX0BRcP2uHkfjyHJJO12/q5zNmmyf/WRqS/ATC1qk4cT5E5NtzqrNM/zfjeBFWwnPJ6xuEp7uVYSuGVurrRjr6sKW1WtQ2tpg21Ch7RfvIuSWErfPf6CS8Mmf+YwGnbSItO93b+RLQf1K9ypfdF58yzEE+SX7zx4MCASAo4n4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 13, 2023 at 05:53:46PM -0400, Peter Xu wrote: > Now __get_user_pages() should be well prepared to handle thp completely, > as long as hugetlb gup requests even without the hugetlb's special path. > > Time to retire follow_hugetlb_page(). > > Tweak the comments in follow_page_mask() to reflect reality, by dropping > the "follow_page()" description. > > Signed-off-by: Peter Xu > --- > include/linux/hugetlb.h | 12 --- > mm/gup.c | 19 ---- > mm/hugetlb.c | 223 ---------------------------------------- > 3 files changed, 254 deletions(-) It is a like a dream come true :) I don't know enough about hugetlb details but this series broadly made sense to me Thanks, Jason