From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A28EB64DA for ; Wed, 14 Jun 2023 06:23:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12ECF6B0074; Wed, 14 Jun 2023 02:23:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B6486B0075; Wed, 14 Jun 2023 02:23:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9A1A6B0078; Wed, 14 Jun 2023 02:23:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D583A6B0074 for ; Wed, 14 Jun 2023 02:23:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AD9D11207F2 for ; Wed, 14 Jun 2023 06:23:50 +0000 (UTC) X-FDA: 80900362620.05.DDD14D9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id D17B240003 for ; Wed, 14 Jun 2023 06:23:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Tji2iYkE; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+0196a6927138e51d4dda+7234+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0196a6927138e51d4dda+7234+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686723829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a/237Jd7ln6xMv4l66dVHFcgKFsuublPEznkGLEXUzo=; b=H4qvEa37KlQkGPkQ5tBVzP1PhIwEQj89Sl0nike/+FI9TThbsRLjO7Yv9iDPMVz7s7wMQr 5GcT0tDJnykenfEQ0JC5jpRDPE5I18ypYRGPthoiHC1EfN+YlXRshqQXe75JXLh4wT3oOF qg8KgH1Rh6iradsGqRETtk38kcXKf5o= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Tji2iYkE; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+0196a6927138e51d4dda+7234+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0196a6927138e51d4dda+7234+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686723829; a=rsa-sha256; cv=none; b=WsfC2iadlT0RRZkFHdeAt1YCQDH4vO0G7zaTfTU+zQqfVOdePeTUi8nNve/IyubRGBGIIs By5nHkWCNHN9Tgpq36SBlpvw+zB4wK1Xd/2Lrc/FtNoqlsCQTSo1AuBA+WdVNrdCzH8JYY Qf4hlIXqqivZ2ZvfsyMFCb4jy+d4NDA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a/237Jd7ln6xMv4l66dVHFcgKFsuublPEznkGLEXUzo=; b=Tji2iYkElPyo5dB3xXWyTj8Gi/ gVm4pEMT4188VSrQO5QbDATCEZHEibdHPW8nbwvpBNrlb5MeNaiF6GvdOu2+1Q5FUC48EqW4w5/oi jZSar9WmBMn7M/hmapwGV4tbqE/BsjenCppqIunVwlnkKf7549DO2Kvqa2C4moVy2LQFWMlxetgdk TAmeNkQacQYKRvNdAV4ahGvbXPaFgD5ZB3Tz5gzBo0CpZLpH5UP9+IMZ1+b4q9TM3f8/YXG+au0C6 zt8hx3RawgF9nXDBZRccHwDGbhLAXys1+WWjN5SzuAbNemIjEbd+JJjYYMTI34Fe3zTPTI+ZoeNG1 tXV3gtmQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q9Juf-00AQ6q-2g; Wed, 14 Jun 2023 06:23:25 +0000 Date: Tue, 13 Jun 2023 23:23:25 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , David Hildenbrand , kernel test robot , Christoph Hellwig , Andrew Morton , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: Fix dio_cleanup() to advance the head index Message-ID: References: <1193485.1686693279@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1193485.1686693279@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: btdkg4dg78u6g86hiz16sudkcks8568j X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D17B240003 X-HE-Tag: 1686723828-931515 X-HE-Meta: U2FsdGVkX18ZgmoZSCTq2RjUEZ5B4EsRHoxNKmtbUsVQdKy+88gzG1fuRUhxkWI1tuUOqLh7IPd9Tx87ODxYYB1Dv64CWBqqU2boHd85Go+GXU8uGCoyFGasJuhf0kJCALtFesTQGbVtzVvZBQNCW1qKyB9ZFWf9c+CffZB9Vh+hfqp9YqfIPBHXWmz/+eJaWbCCowPnq4bVFDdi2iR5CZs1ap6Xt1dibuLwrnLjCAwGmm2KNr8xFr+9G0fs+dGZA6ZhqCgT/XiL8o0OL6QjUnWUd4yfveCBCtk7vSfcQep+Sn1WvXJyalIu7KbZP85Y2ALy9YvFj9TKMy6aiOj6Z8tnVGh1zF5n/8PpvzSG9XqbGmPhSQDFEuzbrMmstA9ty2pJykzJWPqmN+5rIXqxnc87IEiUHnWhog7MJ3P7xLN1JZGI5Nd1aRxDy+kO+5XqbXxswxDColmNpqNyfxscxsi+IpSxwTdO00Z2+x5MpqNkz6zAva2SzihXixrRd8nGR79g4mXt7vNDo3vnNKCzljHLTrsecY0P6H+P3T5FxHjgo8ZhALQuAjvoKvHm7nH4zM1DKOoY6iiMophQtQNLkG0KWdPNQcK2IxrNkL9JMhqgv447hWutgvjPlkXHmOVSmMNgtHJg82yUpbmkc10ivRxwD2boaXY7abFwzNZhBj+tVYL6IA26G6qeH3sAxJ2CyCYr4H+U3Uf3TqUexy36cFS8f5Ctxr/4KL+Db2rXPrF8hwOqJD2AX6AaS/iY6xMl05S2ntf8Y2h/NMHjSZKVLgGU4A2UrmJK0ScNomnLROfQDQ3jEUNBDcDJA4RnHzoA0h/E5apTGODUTGihsxhN5h5BzvrFr6PlFKRxiiHsaFqI4JksxLOCoUa05tL0FTKScS65DaWxQB6tdm2p9TR/Esu6OzNWmVubE+myWimaONfIzCs5+nX3o7gz7tJ1M+0NXBO394l/0mz4SwYpMDQ qNVN7UJR /j9R5XJev78eGmDLLwp7HdEOaDsXpcDuXo4vexswrbneztQd5jki4g6jxBSTIlaFcAAVHRidiizP+ZDGn5nOmJrrNjgYIhYYD6MctLdSICdXITGLH9hFw/Z1FYqfDnVZS7gGHukximF/HY/8qHSS2gLPpTsHKqfn+wOamRvktGe5PWnVsVGzEKPRl9Fm3D/onQ7QcKOOyiC6WPN+IKpiRNWviWsM2sB1c0e73SU0hguPbHyYTzCNuQ5YYQz9HTdSTzmimGyhOjUdjPyOn8XlfZWrJ6t7iHDb9Q01H+iIAnSargIu3BrhTE3G5abFGrq2kwXYg6PBILdWt6taI1/UqTTeQJqtOeHhzoctHcfXhGCeSR0wVCvBmCjqYTX22PL5oJD9zjjRN0rWkVgFbQCV4dmZkGBze0T39m1gwLPAr6S3x+4weBRz/SbeIMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 13, 2023 at 10:54:39PM +0100, David Howells wrote: > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -459,6 +459,7 @@ static inline void dio_cleanup(struct dio *dio, struct dio_submit *sdio) > if (dio->is_pinned) > unpin_user_pages(dio->pages + sdio->head, > sdio->tail - sdio->head); > + sdio->head = sdio->tail; So looking at the original patch, it does: - while (sdio->head < sdio->tail) - put_page(dio->pages[sdio->head++]); + if (dio->is_pinned) + unpin_user_pages(dio->pages + sdio->head, + sdio->tail - sdio->head); so yes, we're this looks correct: Reviewed-by: Christoph Hellwig