From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E57EB64D8 for ; Tue, 13 Jun 2023 20:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EC538E0002; Tue, 13 Jun 2023 16:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19D6D6B0078; Tue, 13 Jun 2023 16:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 064768E0002; Tue, 13 Jun 2023 16:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E76E06B0075 for ; Tue, 13 Jun 2023 16:16:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A540CAFC3A for ; Tue, 13 Jun 2023 20:16:29 +0000 (UTC) X-FDA: 80898832098.13.C51EC14 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6F3368001B for ; Tue, 13 Jun 2023 20:16:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BhCU7R/Q"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686687387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6gY01Tx4BIc89rInz9irLDAvinQyYun0b+aEdVCR03A=; b=psUb2kpq2YX9Jk83bnHeAFXEV3eBGqhQoy8OhRcMNatMh0Y6hI/sv/bXZzuvlWdAwhEQPa CZmN/ILYbAQEbGB6dqHeGPQ/GE4XTs26itpcUK4NHdlee5xxx1bKA+t2IznZj2MyYYqeSM yIi1IhzbRBf8iBGyA9GUotRr121RqzI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BhCU7R/Q"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686687387; a=rsa-sha256; cv=none; b=F1fw5QTGrpAN15zjFC2LnzZG4VNfHpoEx2nBg9ZPmWXz8jppafNAZ1RjqSQIuJAtumZj7P 4cvO6pGZaUO300jCAOFpLL1nEFwDbrdraU8t4QODYcRcfkbGSo9N82HPXuNUX3+U8ZFcke OsrsDSyqtUI+GVe9hiQuz2VkzJH/nkM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686687386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6gY01Tx4BIc89rInz9irLDAvinQyYun0b+aEdVCR03A=; b=BhCU7R/QHMMED3MCZWuMaCYFywOV1V12/Qo7GhUs5mDxfSkiQAuz+0h8+cwXuh/ijx6oq8 OxUChtlbmGOcnUotrJsdMfkgUlnyjwF6M7mSwKrXtTUcDcow/rPj0UqRDUgmvSiZhg5po8 hYXVtAr1Ccf1c94A91lp7/TqPSF9yg4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-8yUzP_8NNuWD5P706kRAjw-1; Tue, 13 Jun 2023 16:16:24 -0400 X-MC-Unique: 8yUzP_8NNuWD5P706kRAjw-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7606a134623so42884285a.1 for ; Tue, 13 Jun 2023 13:16:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686687383; x=1689279383; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6gY01Tx4BIc89rInz9irLDAvinQyYun0b+aEdVCR03A=; b=kQw7krunvoBHXTF+p6yXdWuI/oL7TPJSVozE3uoZFBHhhL2g78ZPELrkqB9DNZ6RiM c9TrwyjGYiePGICFCd5VjWrO1RxO4RV2nJPBqLV5ZeE5Ze737Z4ppgUrQdVzNlKzLLY4 DTR6I25y/c06U4RDj5172vTu59zbygZIJTx6aFKiIEBXsHGA9VQMoE2IWpgc7rvBPFd9 MDKnHRPrP6mXX8K1afa2lq9+JFOcD9NQKtjj/6iQuaYsK/H4VmpqHlGWrnqw1wYW3+If PYXbe9xy5VBsyvZ247DXBuNjcgGce41Y077JKswhYLGGzRtJT7w4/J9Funm83DoilTtj xGdQ== X-Gm-Message-State: AC+VfDzz0BfvX3iVwrWtqLfWHu1/u+Ro+Zuk41Xkutptl3XYNGrKslNf oDTJjwRgR0ZlWTCYgXxGCwfkSARl9CH59aGkGj6ZQm/EYyPUq5JvhB0hMPv+cWiXCKPyhQQBChT GQj+bJISGO0Y= X-Received: by 2002:a05:620a:d96:b0:75e:da20:a10e with SMTP id q22-20020a05620a0d9600b0075eda20a10emr14985504qkl.3.1686687383552; Tue, 13 Jun 2023 13:16:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7iLH0WqTagTH32CHBbOR+wl+dP1yrz10MNUnCv37WfCOA1VxEblO4cznoDu1tHw6xJ5PXvag== X-Received: by 2002:a05:620a:d96:b0:75e:da20:a10e with SMTP id q22-20020a05620a0d9600b0075eda20a10emr14985483qkl.3.1686687383204; Tue, 13 Jun 2023 13:16:23 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id c2-20020a05620a164200b00759322a6089sm3843860qko.14.2023.06.13.13.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 13:16:22 -0700 (PDT) Date: Tue, 13 Jun 2023 16:16:21 -0400 From: Peter Xu To: Jeff Xu Cc: linux-mm@kvack.org, linux-hardening@vger.kernel.org, Liam.Howlett@oracle.com, zhangpeng.00@bytedance.com, akpm@linux-foundation.org, koct9i@gmail.com, david@redhat.com, ak@linux.intel.com, hughd@google.com, emunson@akamai.com, rppt@linux.ibm.com, aarcange@redhat.com, linux-kernel@vger.kernel.org, Lorenzo Stoakes Subject: Re: inconsistence in mprotect_fixup mlock_fixup madvise_update_vma Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: cyooy98ojizogbsbgpxtdzyzb5t6h5tp X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6F3368001B X-HE-Tag: 1686687387-446414 X-HE-Meta: U2FsdGVkX19dT2/lR1GNz/zc0ZP5VLAtNdKC5LBBYxk89EZBvR+flkzReYQH6izUUDcPjpuy8CqcXNDh/Z5dFL8uuAt+JzYimd9I0aTAS96VQmNqneR7U35a6/v9bcoY++8a7uTte8pjhG65LjHM8mNoPdzQH6wt0R/oTf179tHY9xp37eMf6GbftNwntosrTKKf4/PiQWzL5xOlCi211M0HHc4dPHz6S4aqdhVUdzk3HJhTIl88Q2uPLvKHJc3Uf/V/gjjzJYkMC73dDhOPWkyuyGjz5lolYPelViHcyjDYtbyLygqS/rXq7HI9mPeY3n+Kek5enU47ScCVHJ/mYKab5MXuMBqfqYYeB510xv27kyB01TxiDbSb0D2Vrq1mwZNt7yqwVZ/HihqvnPQ9YrxqGCJ7rhyCQ8c2yVv94LghsAJyeK3anqpT0AbomZPD7Tok24oMWP8AzurHylTwqics7tywzMvqBnyOjEFlkAQ+U+VAH9OckXUsdNv1ks1CzoC/hjb3JQgkF9zkHFTAD9y0OrTzya0XI1DWsMwe234fZw8KuIDskLu6rKwhZpBOvnrgMNi/t3+i/Xk2hUGBWUHMPSSW7IzUWjqAYcvmldMB7DCF8K18o8/rNad4DmWnVDZYuBZYhgTDoit7Z6eQmVShB/XvT3ukUVdcJJQKcCR0QZetXACHeydMyFZBfqU2kH9pUQWXzwonLSHUaIc8vkXgU4PGW965A796FTM7If8nZ5dyDaxUBLc2CkGskcRj7kiYj9xjC6V+LISBZmOWf4dMr9JTrnXH4Jt0ZbIe3LKpqvh/M6dIOITzNt6WZvxXF8zSBxElIslZziSIOT64H3ndnyKQy6GG7KyYu90SYLI3ZcX0XYbe7NnkXeCq9ty2KdsqvIli0/Qny3W394QgEdJqYIfxhrnIcf28G2jBMBZCdHWK8eM+LFWP2jiljWpe77Tvgx5w8Kwcx0MqRMr Rrt5Z7+N wWsChdJofMo4GdXlmSRhhjvlSZofnc3mv3hGD2v719Y6ea2tIPfvXrZWK8R4EJu4Q1Zl9cn1ZeP+OHbOactIInXFzf9VkGoEqYSj1phYOBN9qVk3ygU1Bht8vXmHWcTEae+ZvMMN0TxRRCT5XL1L5lQb+dZSD11u0FdZjvcskYvNr9W7DTkI4PENGgexjGwBcCBKGNY8/r9uvqS06fE5f4D/Glo6aZssgGRdZJCdD+NRMydUDGgUaNliTv3AC97b0Us03aN1qJGTMhB30/GAs/+Cst19ttDBIQHqWeEPIRSg4ZXwDZlkbcPsNBIBKXtD1fjLwYlTA8KjWS04gXR8P3XNV0TDIPJ2q+ZwoiQWNuKuvs/u8VJPC4WFbRW3uxHUA3kGTmPSBHyqNwxblYx0ONa2pZCk+KtXFDJRZl3jkZVb9EtNETMDYrW1rLqoXv0AtMe+JY6FSPORjpr8kKAe2MvyrhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Jeff, On Tue, Jun 13, 2023 at 08:26:26AM -0700, Jeff Xu wrote: > + more ppl to the list. > > On Mon, Jun 12, 2023 at 6:04 PM Jeff Xu wrote: > > > > Hello, > > > > There seems to be inconsistency in different VMA fixup > > implementations, for example: > > mlock_fixup will skip VMA that is hugettlb, etc, but those checks do > > not exist in mprotect_fixup and madvise_update_vma. Wouldn't this be a > > problem? the merge/split skipped by mlock_fixup, might get acted on in > > the madvice/mprotect case. > > > > mlock_fixup currently check for > > if (newflags == oldflags || (oldflags & VM_SPECIAL) || > > is_vm_hugetlb_page(vma) || vma == get_gate_vma(current->mm) || > > vma_is_dax(vma) || vma_is_secretmem(vma)) The special handling you mentioned in mlock_fixup mostly makes sense to me. E.g., I think we can just ignore mlock a hugetlb page if it won't be swapped anyway. Do you encounter any issue with above? > > Should there be a common function to handle VMA merge/split ? IMHO vma_merge() and split_vma() are the "common functions". Copy Lorenzo as I think he has plan to look into the interface to make it even easier to use. -- Peter Xu