From: Matthew Wilcox <willy@infradead.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH v4] Documentation/mm: Initial page table documentation
Date: Tue, 13 Jun 2023 15:45:12 +0100 [thread overview]
Message-ID: <ZIiA+E3W2oWy9uuR@casper.infradead.org> (raw)
In-Reply-To: <20230613083906.757878-1-linus.walleij@linaro.org>
On Tue, Jun 13, 2023 at 10:39:06AM +0200, Linus Walleij wrote:
> +Paged virtual memory was invented along with virtual memory as a concept in
> +1962 on the Ferranti Atlas Computer which was the first computer with paged
> +virtual memory. The feature migrated to newer computers and became a de facto
> +feature of all Unix-like systems as time went by. In 1985 the feature was
> +included in the Intel 80386, which was the CPU Linux 1.0 was developed on.
I still don't think the origin story is useful. It's trivia and doesn't
help someone understand what they need to know.
> +Page tables map virtual addresses as seen by the CPU program counter into
> +physical addresses as seen on the external memory bus.
This makes it sound like virtual addresses are only used for
instructions. I had better wording earlier, but there's no point in
repeating it. Just: I dissent.
> +Linux defines page tables as a hierarchy which is currently five levels in
> +height. The target architecture code for each supported architecture will then
> +map this to the restrictions of the target hardware.
The word "target" isn't adding any value in this paragraph.
Honestly, I don't like much about this document. The writing is
flabby and untargetted. Much of my last review was ignored. I'm just
going to stop here since I have low confidence that any suggestions
would be incorporated.
next prev parent reply other threads:[~2023-06-13 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:39 Linus Walleij
2023-06-13 13:27 ` Mike Rapoport
2023-06-13 14:45 ` Matthew Wilcox [this message]
2023-06-14 7:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIiA+E3W2oWy9uuR@casper.infradead.org \
--to=willy@infradead.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox