From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D5CC7EE2E for ; Mon, 12 Jun 2023 21:35:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A26D08E0005; Mon, 12 Jun 2023 17:35:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6B98E0002; Mon, 12 Jun 2023 17:35:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F548E0005; Mon, 12 Jun 2023 17:35:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7CA058E0002 for ; Mon, 12 Jun 2023 17:35:55 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 49B17160330 for ; Mon, 12 Jun 2023 21:35:55 +0000 (UTC) X-FDA: 80895403470.20.D403866 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B324B1C001D for ; Mon, 12 Jun 2023 21:35:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=INXhRbSz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686605751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NkQV10oF5ZntpZuW0m7Oa1esdGwRfz9LHsmhKjiKPeQ=; b=tmuzITo3HN9ul2eJZoWHlrebz/Q6Iiv9434lgXDt44Bxl9ZSUKkGtfke1ymfO3eD16zgpr IrfBRmpNkhGC/5fe5PK6WZsTKWgYhmjilGjZqpFYpnzArHOgGrr2JEVjbqGIQFIW7EE388 43D1PPYcWUE7VZb6pDWjp/bzMoEnDu8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=INXhRbSz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686605751; a=rsa-sha256; cv=none; b=GNsMZYXpBLeakAElP6ucCCW99AL/nP0Mtg0jH9FSnwTqEQY3ndiQovYNZN9oTAAQyn967m z3M2paYSGmiq8KzZSxXaBT1LoA8W6HVnc+dCuuzTNa6BGFcJ32TQvJSzWT+zYUXncqstMM uoYd5E+AnwXucoAppEuCmHfor6KcdHk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686605750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NkQV10oF5ZntpZuW0m7Oa1esdGwRfz9LHsmhKjiKPeQ=; b=INXhRbSzs5T/AHBkAwHqLyVppT/dfkCo6u1SOW5ONuQObQhUXe4+6SNjJy/nCZSdnWhURb ApzWg03lj3rfQsUDcPKCs3W8Wpnk5J9t7EValJQNOVzG58zLhLoqlyeiR7f2Rkr4oKoSPY wNEKoKXOuZbqZOIQvKoMMyIduBFddQs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-Mk2ywDpdOSykYNHlAmNBOQ-1; Mon, 12 Jun 2023 17:35:49 -0400 X-MC-Unique: Mk2ywDpdOSykYNHlAmNBOQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-62dd79f63e0so2256336d6.0 for ; Mon, 12 Jun 2023 14:35:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686605748; x=1689197748; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NkQV10oF5ZntpZuW0m7Oa1esdGwRfz9LHsmhKjiKPeQ=; b=cEXeCxllnGY34eXeUkbulNplBnp0v976QDu3gjOvVlVOB4iMHzYWs2DqBPUD+w07pz A4wrK1PYOBOao8CqqAN3Dd/o7K4ymQk2Vawfb2fWGvQzI0Q59ZS2qp9L5WyQA+Qf5juM d0yFPdK+saRQnJWi7444Skd8fvfvu/aZ7UDzNYA5FHlZ9nqxJP2u3B4uLqqs/mqbjvaQ Q7kmBnns7uz1b0iq8lLtgwpNRvXR/XWggeWbKoN4XnwClpvdJpn63/aTAsOmcLKQIWxv P/IcfAGTmC0T/NAjOqOErpnXKGqFmmFFJuiDWcNxvyO+bVHTDp7ZyiDdObBdi1F97LOR 4vHA== X-Gm-Message-State: AC+VfDzNXlO4obkpirOnfAQ3tLFmGOEmAcwPCJb7/BnJG7O3ECGCb7go DF3e/haN+P+DJoJADr3QwSGL4o6Ktd8y5TtSrxHu/sR/UVW4kjQY0HELMv6RnbLrRsUwlEk2f1p hRtXnmRApbdk= X-Received: by 2002:ad4:5aea:0:b0:62b:5410:322d with SMTP id c10-20020ad45aea000000b0062b5410322dmr13260518qvh.6.1686605748591; Mon, 12 Jun 2023 14:35:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4hVxn8A37sq0YOY66NVF97sTSXxB2Qm4jGFSmtl+98Zfmt7cWhpbXFa6YFA2pqBxvxrtSgaA== X-Received: by 2002:ad4:5aea:0:b0:62b:5410:322d with SMTP id c10-20020ad45aea000000b0062b5410322dmr13260505qvh.6.1686605748392; Mon, 12 Jun 2023 14:35:48 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id x4-20020a0cda04000000b0062df4144a4bsm246507qvj.56.2023.06.12.14.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 14:35:47 -0700 (PDT) Date: Mon, 12 Jun 2023 17:35:46 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song , Naoya Horiguchi Subject: Re: [PATCH] mm/hugetlb: Fix pgtable lock on pmd sharing Message-ID: References: <20230612160420.809818-1-peterx@redhat.com> <20230612204418.GD3704@monkey> MIME-Version: 1.0 In-Reply-To: <20230612204418.GD3704@monkey> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Stat-Signature: oxznsd8n8w8uywgs1s5e8y8d7uaa9cg7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B324B1C001D X-HE-Tag: 1686605751-576468 X-HE-Meta: U2FsdGVkX18nZ4DQBDmM2qHpP/bOqqaSxpIGYW2Q9GJOobcku1XlpLOmuhUdbV+UioSh3xWciFxurTRYnW5ZdeOq7OUActfMwpGfbpbQ6XDiGtcNwleLu+Snv/euZw7Z6vbZj1Ymh51jhgBG6hv7838AsmBaeNLN/sd7Vz3PJKE3BmdUvX9ubdesxUSRIinpNDJgxTYWxrjPlsLfs9EKcmliLHbpX3E1kPa1Cb8rjHASTm6zQP1koBJVMl1ZzRTFkHHQ7QVNq5WVuqYOJHiNZA75YN/jsXNToRXdsLTc7h3JEBV7Nd5TusFD+UNdGe5Z0dV6W+zwyQkdiaYVw5806m/0Z5NDS+lYSx6LFPt8sR75WVxgKb4C1aQRVdjhrJgEotqZ8z3JKtUR2uvn+vN7nSF4U46e2nZUsj8pY1Slrh45cLxTKOrMHwMFYIoZeqBn9AnE7AOd/VcFuODNvQ7uUDKD6LF2ZXKmcQeVLVgkYpafDweBTfJj8UAQheGAdYkS9FPHa3TPZmOcB8/+11YYV/EVVMkbUse7hkGb0+wSYTsXpMreuxVw8cjuzem5tIX4NTzVyDr4Wju22clkvyM238Y7sXlGA2uk8sVmTHDJrKrwV/C00aO9ND4UZReuoVeECKLHM+u5/+EyO4ivHHaQPcJcT0KJaWGgCaSXafBl1gLB23+jUjf9NcSFKsWxKI4yIA91fAvqq+UOGvAvEQKGRTdYJ/is6YoCMWjiMJMaq20VaEOBhm782CXGKOVXBQ2AdGPOijQyQWDAT9Ji+xwY4/BOVovpG4/+ECUtM4MTFezZi9hzvLPC5ajA33aZhjNNjTHP1+k+5xgxFz7W8rLsyLQFl5mKvdu3282aCwzuW3K479ZH2uUedfqmfx4ign29Qt1zHD44BDlHCEYXtAEDjvdOV0F1KTTXSfDulFSpeAWd21CcYKvMNLr1PMgldpwqrTfLSS84VXYNas2xbP+ 15hdx332 JgVtPZtNLmhe7VqlE8WtQubBUNXAFOutjHMKAuRc1TFA5Nj4MIxU/z6MbEOoEdB9Sbc/d0vVakHvN4dk3x2EMbG59GwnSXEpze5R5FUGZtkNTmvUJBq6UWmLeHMae7Cb77TdIkSdqK+0D64E0ujyUL1+uKiFTzIq8a51V7RpWvyr/FgXwS7LSknoYmNlS80IgvXlQ/i2S2e32mxSN37/K5mpt8DtovYGbVKQyRuz+9dVa+FlXWDOJoyqxGyDXGeCW2z0GYyHU1zG6C5BV0ppGqDT5DEKhDbE/swmrL3VzhgV1tnSPwhBrIDdPGQzppd5yRRYz8G1bhckh22INwe2vPRuGQWZgGvQeiWOEwMv2DIE5MLT9GAID5VCzGjpsWmhwjuFB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Mike! On Mon, Jun 12, 2023 at 01:44:18PM -0700, Mike Kravetz wrote: > Agree with this change. But, it does make one wonder if the pud_clear() > in huge_pmd_unshare is safe. Like here, we really should be holding the > higher level lock but are holding the PMD lock. The vma write lock? My memory tells me that you worked on the vma lock and one major reason was for that, but maybe I missed something? I did check again and all call sites should have that lock held, which looks fine here. One thing worth mention is pmd unshare should also always be gup-fast-safe because it never really releases the pgtable, unlike thp collapse. -- Peter Xu