From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE4EC7EE2F for ; Mon, 12 Jun 2023 18:57:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86D276B007B; Mon, 12 Jun 2023 14:57:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81D226B007D; Mon, 12 Jun 2023 14:57:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E4F78E0003; Mon, 12 Jun 2023 14:57:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 600866B007B for ; Mon, 12 Jun 2023 14:57:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 31D46A02F4 for ; Mon, 12 Jun 2023 18:57:26 +0000 (UTC) X-FDA: 80895004092.30.CECFFE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 017F4A0008 for ; Mon, 12 Jun 2023 18:57:23 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LcDgf3QM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686596244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZmIquouHkn7x7g5U3IKxu0y2ezu2hrVL9nMe9oPXqp4=; b=I+X0gQGxSBK7Raf0QE+xEUWjkYim40sinvZ/dEWd70ieOwW4cMq3s2vs30vnn4y/CRIRzT MH0HnwjhOHAVENjff2Zu1ER2x73exvDNBWND4KFSxKYSMJ4Vb3JJOtLqYgYLCooHXMxvNa C98TQG8Yh+/f+PH7jSfzp8YIm+ENXYA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LcDgf3QM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686596244; a=rsa-sha256; cv=none; b=c9UqgPzgf326zTZyuaDzIo4b8REE0E9LL3mLMUsuz9W3Am71k9yAgX0vvquZ5XNyPtVT8Q iQt0pr0o9nzZDuOnWSDCpM7lI4CmEpGQJvE0hn5qeZ/AoPp9GqHc9x+1xgpA9LOR9G6cy1 EkpsCsE26aD4SFZcT663Vk3ZGf9PI2g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686596243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZmIquouHkn7x7g5U3IKxu0y2ezu2hrVL9nMe9oPXqp4=; b=LcDgf3QMX/cgLo7n59BV2jOHkdIsDpMxPceWbq2YfaG7bKB02NeKkomZ8Ed9j2S3x7FXvC FynsagUJq4/f7FXObYYtXA/+jCq64XPF6pEzE3RbQekNeQC3BL8VLIyIuDjvxND9bxaQ1P WcmV7Dhw/a1YWRom6jfblJf+/KajpeY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-J-9Ff0COO8-0u4PB09If0Q-1; Mon, 12 Jun 2023 14:57:21 -0400 X-MC-Unique: J-9Ff0COO8-0u4PB09If0Q-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-74faf5008bbso100044185a.0 for ; Mon, 12 Jun 2023 11:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686596241; x=1689188241; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZmIquouHkn7x7g5U3IKxu0y2ezu2hrVL9nMe9oPXqp4=; b=VC/IKHROMeAnVxEwKAsyyZHOirsLI0r2OqoP2ijb2OwtvuskmsJjQJL+YCxvFNLN9J fLMLxFOJ1wxRzE2KC0qwDNHFqxWg/aTOGnsj6RM8qqotjiHkBwq2g8C+L4adLQRDcwYl gGn8sYpC3R5lyX27m4xstCNIuh17BbPK4Z/hBjkwOTN8kXQzphzZJP3vMCEC75IPXWUa vhvli3uOi5Eohe3GnJCIcZ1YpPM14L8I3rxgPuyc/3+OeoAQXdDdogRGicTxDMU2wes4 AMoitdTNlJmlc7mjd8rx9zhHfxyhFXPn4PcmCIHxE4lbzxsxDRSie9nbc+hlCyqGirx5 CYYw== X-Gm-Message-State: AC+VfDxtLlk/ZUfsJ4rJEWp3qtGizzuPKfRoD1/5W02LJhUO6zcVUDgX Fo2NoPLWLMFG9WKT1ZCccV3QBXp7YlZ2fNIfmhVY7UxBlUUltrq61Yfk57nFsZgng2UruGb3us0 IUAX9xuWvEUo= X-Received: by 2002:a05:6214:2b05:b0:62b:6c6f:b3e3 with SMTP id jx5-20020a0562142b0500b0062b6c6fb3e3mr12804179qvb.3.1686596241352; Mon, 12 Jun 2023 11:57:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6e6wlnXH8y0uBmHDsq+xF3VvQe8OmdmhPPpTZDH9TOC0T37Kc9khtjBeEOIaHB3qFNDKkviA== X-Received: by 2002:a05:6214:2b05:b0:62b:6c6f:b3e3 with SMTP id jx5-20020a0562142b0500b0062b6c6fb3e3mr12804161qvb.3.1686596241115; Mon, 12 Jun 2023 11:57:21 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id h23-20020a0cab17000000b005f227de6b1bsm3397636qvb.116.2023.06.12.11.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:57:20 -0700 (PDT) Date: Mon, 12 Jun 2023 14:57:18 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 4/6] mm: drop VMA lock before waiting for migration Message-ID: References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-5-surenb@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 017F4A0008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ydrtocb8xgugzahpjh8g16i4jg94wydm X-HE-Tag: 1686596243-192523 X-HE-Meta: U2FsdGVkX1/XFzsEsce3mLfTNsTJr2fLwgaS7tOB41mOf1ZR9Gr35U95ecfqBE+4dbGe+yvBNrxKM2TF9wtIrprtXUGbaZzvdFwXyTvJg4XMiMmMsoYa5nQboQVSd9m72i3tcc0yVU/dkxrig0yfxa2ydyAEEJmgxObOARbkD8bj+iBb1YSBbHqvCg7gRgS2PdggaHZ8vEjBLv14WBeSDcuh6x1XrcEkKxPpjpcWoYEui1g7Sz3NR/qxiMqsrhUdi4CIrcFqCje0bvnDHluqGr5IDaRn1I67ToM3Tw+SVAMwhXhStgbbfaqD3Noj4tpqOFbQj6F2ROtQD9btJydy/EMHmJs/8wppHY9MxuMgtmDnncJk/Z8UUHm25igZivvdlPy7U5ap0hjrj58hbvALK5Q5RsiFbBBQAU9Fo+QaGVWnu+WhliS9WMYSuZrzEbe+SFVaUJm8yCy5a2MG66Um/MQJ/Nx/w6dR0zcT9JI2SUXHQN4fnwF594LmEZfgXY86IGboFd+QPQQ7vW0lDVNlNypmEqjx+DCMdGnYfI6Cp/fIFeCZda44VuDJf6300CE/gXj3hU5uPJWugzBZVtkx4iE2PjHyMqZ9o5IfAIcYVshdfIZ8baOzfrlgQSDsFRVRHvolRlYFbirSJz/+AajrRekmQvOMvQZajaWtgFObPHDLZGm47xwLgU+JAcatjrMPUfuLkAzW+bLCcwtlJyXnv+mxDMAzUclFs3WELk4XkOxzubVlv0XchLmxDmFqqAZ4Du0BURnH3P/CW/0s2Vg8rO2FXv5bpQUftnexcLLlJr6PAGmlXRr9aLDBLByt7tUwblWuw0qpoRNg6jjMFWhF5cx4MvqIl7qHxEZfrGYBnHWkmiE6sWFXiWcX9MGz94xxsbTgzZ4flH3baqoheJOaKg/MRsesTSz0wZ+1HHYgnCj0rej6k1p4fhGlTiBEH0HEm6pWHfO4VoN3lDZsUnL yrcU0APi amA/VhrPjmXpykSJLI5Y0s8qYYi92Psk+GEZi/aqYm4bSeTb3tfdZ8RDmEH7cKGDERgJdJPLGpYNvmHi7uN4sB2QwhwQ/nb0Esf9ZqXrZ4hTrI9NRP6o2mp2B7U4xWrI0xJJkJlnRKOYqM/v72v1LlMYNsD8aB5dFLdAZAXTYB/3aYV8L62cbT39V8KQIuVbpNkXLaeOZsS/1VWuWV7p0LJWglg5vo/Ve/QgItNVvVDo/KzGWlXHdFYZNAzVl3qdVswFAk8ejWnVbsGS88CyZxbxsQoQx7Zev6zppbBi9xw8ZZPck2UxfxMwOlshfg6qZWxSSZ2iz6yBtev93VI0YiU+c65MeMcFc0dL5H9DzZW8ptEQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 11:44:33AM -0700, Suren Baghdasaryan wrote: > I think so. With that change getting VM_FAULT_RETRY in do_page_fault() > will guarantee that per-vma lock was dropped. Is that what you mean? Yes, with the newly added "return VM_FAULT_RETRY" in do_swap_page() for per-vma lock removed. AFAICT all the rest paths guaranteed that as long as in the fault paths. -- Peter Xu