From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6DF8C88CB2 for ; Mon, 12 Jun 2023 13:57:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 162258E0002; Mon, 12 Jun 2023 09:57:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EAED6B0074; Mon, 12 Jun 2023 09:57:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECDE88E0002; Mon, 12 Jun 2023 09:57:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D9D396B0072 for ; Mon, 12 Jun 2023 09:57:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A4105140248 for ; Mon, 12 Jun 2023 13:57:04 +0000 (UTC) X-FDA: 80894247168.28.6FD4891 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id E3DAF1C0020 for ; Mon, 12 Jun 2023 13:57:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NBIB1VWb; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686578222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TqJTjj61+e9IbmTeDPEzKkFs8seOoMOv+pnXorVK6Hc=; b=XVrbo3WlsBLnbR2to82vlUbpa7ZMokKja5IJ7NLgtowmjDFcURgdpQd/Ripaj4ci6w4H6z U9ZoXL4Ty7EKsc95itlQy7SxwTe1qzSfERnF02kA+RQbCi2hqZ0+XE63Mya6ltG8ff72vU a05/9GRyozu9MHu+EBiRzgwWsmxf/zM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686578222; a=rsa-sha256; cv=none; b=7feiB9reSvre7OXSOdZN6RDwskeJ50BLyH5DYAKoCEhJZjnsb9s2Kd0FGh5vFbHl3bfZ19 cRZJ9D6+pniXbp0BAijCm34v7IICOQ009j0uMbkI9GFJloniVlJiM9Q1lxgLuwErhSZM0g fOvt42ky0gix0dirXnbUtZHFYjbsMu8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NBIB1VWb; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686578221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqJTjj61+e9IbmTeDPEzKkFs8seOoMOv+pnXorVK6Hc=; b=NBIB1VWbZbtHYhTfNu1rNtTtgjz8FqSMVfVJ7NYmpqdSASHG7g+Q0EQoYnp8NJe7VG+pl5 YMMg2RKghr5k/Cl+uKoVPJ3UuOwomKiPSLUM6YtydKhjCWq1HXnLgPATLFaEN+4HbBiajd 8ir43ELCE4pkUVMA4sSOOrHq55TrpF0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-hBrkNvmPOfyTvjZhpDqqSw-1; Mon, 12 Jun 2023 09:56:58 -0400 X-MC-Unique: hBrkNvmPOfyTvjZhpDqqSw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75d54053a76so52374285a.1 for ; Mon, 12 Jun 2023 06:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686578218; x=1689170218; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TqJTjj61+e9IbmTeDPEzKkFs8seOoMOv+pnXorVK6Hc=; b=BQvPlyyHiWcKlJvtR4BE+Yr0x19Ixjyh9z5AAdkQaXTD4qGMCjS7Bg2tjb/Dn1mWpp TCjwkKRDA9yRcDV3vyOSIvbXy+I4KccwyMg8/DHZt1XbMOMXgKLsuwgJEuoccDXCR7PH jI8VqHQndY4C3hamq7Htcl5BAAmN8okCiZvFxbM16YZBHRL9AYxCHbPnq7/tJ4u0Zr3R iTn3gQKWKSRgbXCjp6YgE4njgNX8DF8ZMt1Q3skUOyv8sv5uMuo7+nMlnODQH0JwQmjw tkGQw4rL15lV/Pk+XXlEb+Xxvs3oeltbv5dqIh38/4eXBNQ7FOfCUPrsADRDNUUU4ki3 O5kA== X-Gm-Message-State: AC+VfDzkfujg3dabRMuJ38xMbhAHOi+0fHyKLpNkEibs08utcbgAO+lV fbLzlfC6Ey+0r2sQjR3hSmyoRRCC9CvAZjzRydvcJiJNDnfR4GzHiALcdQVptOvD2JtZWmIb62W Sm+CtU2VaMjI= X-Received: by 2002:a05:620a:3c8d:b0:75b:23a1:82a4 with SMTP id tp13-20020a05620a3c8d00b0075b23a182a4mr9898804qkn.5.1686578218371; Mon, 12 Jun 2023 06:56:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ51PNRoKparZ97fJpEl38cjmcmWLq9AZx0KPCWvcIJxJzOQFaz53J6ns5SPtzcprqsL5F1/cQ== X-Received: by 2002:a05:620a:3c8d:b0:75b:23a1:82a4 with SMTP id tp13-20020a05620a3c8d00b0075b23a182a4mr9898772qkn.5.1686578218103; Mon, 12 Jun 2023 06:56:58 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id u14-20020ae9c00e000000b0074636e35405sm2869932qkk.65.2023.06.12.06.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 06:56:57 -0700 (PDT) Date: Mon, 12 Jun 2023 09:56:54 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 5/6] mm: implement folio wait under VMA lock Message-ID: References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-6-surenb@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: E3DAF1C0020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4riithjy459x8iroyo9wkub3o8b6bn85 X-HE-Tag: 1686578221-845526 X-HE-Meta: U2FsdGVkX1/Ai8HJw1xnjZ+3AY3K4cS8cWm5jWC4zw5dPwWX4vDxm3Vn7PFzcpYbZSl8nCirMahGR8p7KovD6n5TkVSkT8AAqXwT37XpsUZMtj5XYBp/pHYWTu77JCaLgtqBKY4ajlh4VL0lDG9utAEeS0hsKwaGcroetfKEGPjFI7h7WIraWZ99pVRO6KrF1pthLhH8i9hMChRnzpBc0CRt3tMow2LTV3lsXR8PTaBSYzWJ+5suRzpcwTe9cT0lPmeQL/MzX0TJkCR/lvRjKNXFq0BhTC08kuWcRpZpgByr8UE39TjEBW1NBFGNQioxcnhmqLrv/qm4H8QeqiQ/At6AIk0tvMpNUvb4/yDWbLHxlvXNagj9TMUAe7surfooj52XEpado2E8ME2jHLYRW5OcalRCak7tGP/fIyNTDw1Pq0uxuV7hQCUByw1BymOPKMs0ShTKpds0RPtZlEv5x8O523fdf+zaoB8R3elueXhC8XqpkEDu5nkCT26D1DsuKk2fC/L7fX5f08zo+hDWrWo/+m6J/+HQ+oPXfy8DYW4OK0k1A3/KkeA67+Pb97q0OXM0jjbjnDGfRi3L5mHb6uJz8XK8BqzxDe2NupMmbSVAos3DBqlOVbSnJfsU+fjpx+oTkBhLEjVWkh+8TdT+liwcV4m1GLEDjIiUjSOZUiqv+C5koAqrUgOKylWeXlXwlTYvapsDM1BxdqRn7LsQBIGycwfljcVLaUDSm5daoS1bod6yf1UXCtdnBWrHtvuxRGUh/71NBtNUBJMtzzw0VhJYX2y+Xo8PybxrPGoM8x3enoXkacS+C28fEWKDlx9TAP7qGgRcNhvEIWYCDz1TWI6XMbxu/uo28UmbZmVJ1uVYum/HHJHMTyp9XhtaLedBLtj3OCB+tGV2iy/m8x7ImDOy9a8jh2+tdCbUIxdBcH4DNaad+cEtoNcvndkq5dyx8L9cHaiEw+Nj0mHLcWT /x4/cjq0 7YD8mUdvX7iPNuDgtRs48BNHb6pb2xIg5mJVfCcfBAGRemkZRnKFm3jDmVIPuDV4B6dAPmbiRNyFSw0amdQhf/EEz1hJFM3DKC8w+eh4a9AhBKw3ZF+31db7RK2afs+dtE7+c+jILJBQCEyyh2IgTAt/PKPaixeAzXIRkcU4Z+DArUqTHqgsXUfi4PD3eai3K3Whx9bOC6biRCIB0JS3tUYD/nUNHu9vkd8dvCKUNYWtF6snEQE+08FlWFIw/1hSJ1SFm9Itt4ux89pXEwAaw4wpfs6Hu7zN4VD1Hn0Sx/1VBNeT/8ZmZn84wqSe0jvtrxZakd6SyeBYRU4YyKuEwPSbrLNRDSMmul7e0WoWHnFPSFTo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 03:48:04PM -0700, Suren Baghdasaryan wrote: > That was my intention here, IOW I'm making the following replacement: > > - mmap_read_unlock(mm); > + if (flags & FAULT_FLAG_VMA_LOCK) > + vma_end_read(vma); > + else > + mmap_read_unlock(vma->vm_mm); > > Did I miss something which makes the function work differently between > mmap_lock vs per-vma one? Nothing wrong I can see. Thanks. -- Peter Xu