From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702D0C88CB0 for ; Mon, 12 Jun 2023 13:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3A7F6B0072; Mon, 12 Jun 2023 09:38:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEBC88E0003; Mon, 12 Jun 2023 09:38:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB1EC8E0002; Mon, 12 Jun 2023 09:38:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE27A6B0072 for ; Mon, 12 Jun 2023 09:38:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 845BC12021B for ; Mon, 12 Jun 2023 13:38:39 +0000 (UTC) X-FDA: 80894200758.23.A1597B6 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf22.hostedemail.com (Postfix) with ESMTP id 7E4E3C0008 for ; Mon, 12 Jun 2023 13:38:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=WbdQ2Ryb; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.210.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686577117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TVRs83q6FuZiAjTvEfCpXamFjh2ThBg8h3S4sJ0ht9g=; b=C8Vf9vkjqcit6DQhRV1e4qqgkQ77Ni2udtFP82vtkKEhJSSJMwP10WuSr59liR34xya4TG jsKqseVigTf2dTR5TJerXzKfa25Egx9nLTIXx1dCZqvpVZ75H6te/3E8i19QLmDSHcMTE6 e5ChnHCK6Ovnjm5dgf7gI7bmP8rD9lQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=WbdQ2Ryb; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.210.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686577117; a=rsa-sha256; cv=none; b=lxSHF6Nnq93wFsYyLPZw3Aum+iySo2qd5l0Mq/yqr/tDrTwqde54mffOADPYChoDHzYXWj rUAFS2uX1Z+5l6kP5TvW0IbjJxZDztIfxDSekusA/2HcK4/cs4X/jB7IOO8p2tppO0qgEa s6fHpPEgBQx96fuOpY915nG3DyDcfJI= Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6b1576c2f6eso2425003a34.3 for ; Mon, 12 Jun 2023 06:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686577116; x=1689169116; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TVRs83q6FuZiAjTvEfCpXamFjh2ThBg8h3S4sJ0ht9g=; b=WbdQ2Rybz2h6J4+VsJRzvE0XZvJHDJ9kdTBhb14dkLnDMQqPP4H5wNbeDZ3XNr2kst ThU4MTwadU0BiIdokY/BpgKiUiTcluVB7OjcavPCHvgUmEWON5ISHqMhTOsIBjN5/ZQp CJ8vASOmIs63t84e6NYAfUAk1HHx9WDN3bLXQPhd2vd4NEXGLCRLWtgi3U6mmtPIA5u8 tL7hayebvS9O4bpzX2vbF4a1JWceg3wlQtGoUVslXT49Geq6fUwVFotXLZcTd/Tzuh6e hUQ4vn9DJdAj3qZJPTadEcL1CTdUQsbKujGLpggVFrT1ppRUtnNb8Yt75br3vhabmdPV TU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686577116; x=1689169116; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TVRs83q6FuZiAjTvEfCpXamFjh2ThBg8h3S4sJ0ht9g=; b=GuBg0m8Aa7C5JNzhXjeD5QsaCWqnbVv4tQjAq408Dq2dG90ls5IAYPDK+3M5uxNnRO rvgU/ddUnNI3ct7wxEhPyMEvZdDIDkAsc6km7C+Zrq/bevIh29BuzVE4/ESXe6oxvX6M D2b0auPA545NZ+KXal4Mz24vRJTBkRLqpIJpQw+r/KEKCv9PbHlrN22mZNq0j3HVkUTf A/Z4h7ZwN1T9SMRTAbApgoHwGu2ZUr4OpP9olUDMaBtghMDYZ427U0ANbkwAQhPBEx1L xqmGzkbOV1v+BXk1bOnH8O6pHOgZOEseJhJahPfSKZalWgMg1UVG0MQuTpp0DwCG0PHO Knlw== X-Gm-Message-State: AC+VfDzFpbNsmIYEAIqgLQWmOxRBMaDLpoHsBytSo+uN1AM58IMnysi/ Uv4fevherYACcFGXLEFygUqKKQ== X-Google-Smtp-Source: ACHHUZ6O8CV++68kg1oVwLuNyrayd1GMlfF45hrqby2eDjgBX9Y1fpq0whm4y4OMc3edXiyhmLAW1w== X-Received: by 2002:a05:6358:9db0:b0:129:be5b:fff with SMTP id d48-20020a0563589db000b00129be5b0fffmr3710641rwo.9.1686577116423; Mon, 12 Jun 2023 06:38:36 -0700 (PDT) Received: from localhost ([2601:58a:8200:2b0::e699]) by smtp.gmail.com with ESMTPSA id g4-20020a5b0244000000b00bccc2241e14sm339418ybp.28.2023.06.12.06.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 06:38:36 -0700 (PDT) Date: Mon, 12 Jun 2023 09:38:35 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 6/7] mm: zswap: simplify writeback function Message-ID: References: <20230612093815.133504-1-cerasuolodomenico@gmail.com> <20230612093815.133504-7-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612093815.133504-7-cerasuolodomenico@gmail.com> X-Rspamd-Queue-Id: 7E4E3C0008 X-Rspam-User: X-Stat-Signature: 36567zguk6wfff8odkuje4jzsdepr61f X-Rspamd-Server: rspam01 X-HE-Tag: 1686577117-611971 X-HE-Meta: U2FsdGVkX197cm8QmJU/auDLqOYlVfi8nTwBQ7L/if+v1WsM6bbUqNSQQ9WDVs+5gvQ+c+RHUWVQClQ2VqgbF30l7QYE2k0hL6aXIUFUiTaR7YoswK1yaUCSk8HP9odm8NWqrPAhQmLCS9nzqDuHz2niOun46jzUB+FEZXPjG1JCjX4MPkw/9attz/wjpW+7zxOAL+hS5el+67f7SBM7mrk1zaFIqcxYZgI9jfJL7xYSMWCIQio8BH3Tqshn8zxaoVMLR0qWXhvgERsmCEIUiPpNN4lfW9HWX5tmCyXZHoMW7/q1NxxmF8tQRQqbSbyKJGzgOKx8edbVwsD6DooagKSiiJffQYnxs8KVBU89z0RyM6NWl9poh9Ycv+du9oQwU9VE77DlN6c741QKcc+t7dsSEFod0gH9RSyPAOFWQlTQhDA5J5pgdRWEyM/bSeIvncbsmdSA4Wi+T78OaYclOs41ku0J/DZ5ImiJpRtm4GoPUHe7Z5/EznuXte2RhlZuv3Tp5l6rEyheZ0Va3IwVP1Uhj+k46u9FrzZCmYqvIJSG0f1D52nPzNfHPaHX0HXVNTANsSvz0rYQvkcNqBNUADq3GyDyTcwg4nqyh4aPYQv1yQ6pBVoCge4M/3GawWm650N6/T6aK4igoF+rhCCc/HyCLfTZCiL9QpRNHkziMLEQTLgV+zM67kysLtSzx5DHhWpvyl7d1m0i82f+ZqEnnhLdUhgc4c2nSLVXEeZvB4avi/8I7mSBsECCQbMMobm4KODfEhmrDe9aZEuVHga7BIKOPbyHhCW0qtRDWK2fheVmbd0mgha2KnfhZu51XiE2CIauUd2fqQNCjPf5f7XYaEPItzWDaEjLPTed8CNjoUAJGu68cQ1135h9vVEARSbmMyvc+8gEVtlj7gZtwrub4aTWPkHCG7OX7r0CGdoyqfwg9z71ryFOoK6H78796ddBdgc8R1+Hqeu2xgofYK+ ZOCtND4g Iud12RJSePcyR0U9QatRe7dGP4IRLzW/sWNy2qjWeudt74XCwV1saxi5dMfLrOb+ah7X3G6ao97tV3V93ouTfCG8H0IYrkIHVikRcYx5iZxV49ZdtaUaZLDqUH4RdRKvDEjil2l6MHrSc/Yk45BMjUgIwjmxGxq51gxt0aPNJ3H0ajam46zmw33HdPA3l31Nxezjf86ldfSBle3cu6oO+8aSkJ+lGynDAbd6a046ib9hF9mZfJyftu4Chy9O/lpCibqB7qcvofU49NhON+Rc0tk6nL/ifCq7xC9Nom02YlHIJ7ZtLipgsk6FfYo99NB95x9xuu9SgYpSiJGUuDds1KeH/VibQoDPvtGEyUzDAuFM3TIDJiq76GBb3RUnP24xkLNKS9w0BGoSMI9vMsMa7vgDre7ffeApphRaXYrn2JF9rNh4FKZ8RXhfgQ5ojrS3V8WkrjK3spRWunwSki2psVPDmJD/6roriPFh9Nzeb2sHmZR2rG6tVyQTBgFKTyUhl0KVBGblb0/pGkQKwgbHOTmIquA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004773, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 11:38:14AM +0200, Domenico Cerasuolo wrote: > zswap_writeback_entry() used to be a callback for the backends, which > don't know about struct zswap_entry. > > Now that the only user is the generic zswap LRU reclaimer, it can be > simplified: pass the pinned zswap_entry directly, and consolidate the > refcount management in the shrink function. > > Tested-by: Yosry Ahmed > Signed-off-by: Domenico Cerasuolo Acked-by: Johannes Weiner