From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CB0C7EE25 for ; Mon, 12 Jun 2023 13:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8F896B0072; Mon, 12 Jun 2023 09:34:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C17208E0003; Mon, 12 Jun 2023 09:34:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB7828E0002; Mon, 12 Jun 2023 09:34:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 993176B0072 for ; Mon, 12 Jun 2023 09:34:39 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A5FC1A022A for ; Mon, 12 Jun 2023 13:34:39 +0000 (UTC) X-FDA: 80894190678.27.947BF23 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf05.hostedemail.com (Postfix) with ESMTP id 4A252100010 for ; Mon, 12 Jun 2023 13:34:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="qo/LCq3V"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686576876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aMMaef3Y60326NhZy/qWmHpGv13Bdt3/sfuPwhyQrG8=; b=2aVRv2twP0WBaaT9hzTIaREVJRmWOKekFNyEDPGQQMp1lI33mt2plra8ed969Z3I5S+rCI /a3dfeUHnl5P+rUM/+knH0C3x3ty0F2YEGSR29EYpNI+N+ilZg4/y6P40/XU5Rnco2GOa6 1H2ABOdlOMhHDaanKRFcvlmIBsILFgQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b="qo/LCq3V"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686576876; a=rsa-sha256; cv=none; b=zaoHE1dm7csLpjzy95gjwgcCzHluHDhP+RU/kDvs2A6eOUo9DtKFJG1BbGdyUBK2QMgDO+ L6P2rFng6S8EH7KqBK46UKBdVDmP1DhnZKsUQnO+CVgbdN5xjD/azH0uByaVZN1IA/bBIl tqQWYyNew9Rww6xJZP3ZkF9qWEWvinc= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-565cd2fc9acso45338347b3.0 for ; Mon, 12 Jun 2023 06:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686576875; x=1689168875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aMMaef3Y60326NhZy/qWmHpGv13Bdt3/sfuPwhyQrG8=; b=qo/LCq3V6W9H8ZqcrKE+1BEpRtS3SQziChm1wZYHkNZHswS6VyxdrYu4tsmptGOQZD pLgwNRNsabIqLCE4eZLpgT4LEtvTKlxZ/1NsmA1Ys+hdB6Hx0ZAA/Ozm2kTo3x/GY0q3 ZEi1p6YgnBtST2Jt05FFop2qwmGmbpgZKHVpc8Kyq57jKz2lAlWKYm4uKSql/1A9jpki vepdBAE7Z0CbRmoLiVqqQhLcP6iVxLLI+pzo8E1bAPi5RLgzectmiHI7sG7+A6UQCSDN ahEDASgtklR6wXvn8GoOfOhb87/KfKR50bAny/2xocKDfOz85y8aOx/VFQ0BVg9JaMVE 7KUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686576875; x=1689168875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aMMaef3Y60326NhZy/qWmHpGv13Bdt3/sfuPwhyQrG8=; b=M+A5PV4+/ZCwrFnT5Hs4fGoyC7kHFxaLEpy/lu3fbLHwXJ3KbCUOYNNfdtxJo6x8KH nuxBrQ2k844gmhNhWoL6pNlIfQ2veuL774IkfEJdjBv4B+RSA1iN6Jpd55Jz6G6FGT22 mFgUW7w1o37VG/aiwxmbGcoieqGmCpiNNw49CtcPMFJrQCQYd8cgs6UDdG0ACyO6y4i2 A6jnRQZs8+Z3jSjgvaEDB0ltcdzG63ldX9DhzCbJyaPZSda2OtYVqKglclqA3ZvVqy+1 tFD+mvnvVo1yG6X6fw/Y59NBEt58TjpDLSMbCddTN7btLdMlp181aCIoS7jZmdqSihEq /ZBA== X-Gm-Message-State: AC+VfDwIiWeBdNi6sxfPmwCLEHNh0dXPM36IzfrIbwe0GzIgP4ufMJHf ey/TzzhGEBVQJkhc52Q2CQSKMg== X-Google-Smtp-Source: ACHHUZ66qeBuLiP1Ymc3dOrLiebqS62YEcnWkWx+eDLbUv9eVOBQDzyDmiQAfTijmp2nvlkEZn4RjA== X-Received: by 2002:a81:83c9:0:b0:56c:fe54:4183 with SMTP id t192-20020a8183c9000000b0056cfe544183mr5383352ywf.52.1686576875054; Mon, 12 Jun 2023 06:34:35 -0700 (PDT) Received: from localhost ([2601:58a:8200:2b0::e699]) by smtp.gmail.com with ESMTPSA id o124-20020a0dfe82000000b00555df877a4csm2466149ywf.102.2023.06.12.06.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 06:34:34 -0700 (PDT) Date: Mon, 12 Jun 2023 09:34:33 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v3 1/7] mm: zswap: add pool shrinking mechanism Message-ID: References: <20230612093815.133504-1-cerasuolodomenico@gmail.com> <20230612093815.133504-2-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612093815.133504-2-cerasuolodomenico@gmail.com> X-Rspamd-Queue-Id: 4A252100010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oabqebpbjs848hxosrgi4qgsk89xirm9 X-HE-Tag: 1686576875-544262 X-HE-Meta: U2FsdGVkX1+038vdyrfrcMrnTfBdADGVa/NiQW8xFMSKCc/nYq0T0lvc4/Sg/4klZKdtHRgF/xrjXNDX2dQpkm9xnkD9hjxD1XP9Uy5kf9lMEQy9TBj/c5m2yW1ANout+f+Bkae+Trm/8Y/ygjH7rDJ52CYNBJM1WI1xS3Us1nmvw/XAlIv4bXduRHEuiu0W+brt4Oy1mHOhw/2l3Wl6XIi6DhW2mDhJeCJLcvgwKJCG1CEQOpY7Lq0mXhQxyCybwAquRraH9CeCRYKeD61vJjg+7tAQzKQJCtgw8pBUQc8nxTDBSKRWhMXVlITAW0xAA6MQvvCyELbjHh3jRfMcUFcyGhWIVPAkmr2KD0bmaTc1JFEnh5lEgvKKYBd7JzqS+cpgZcKQrQoHonBTcSSOxdkZ6zUNbZVsn5fdeGtRnCqrJhjozIuWi/tHMuCyytdhEG/008NPuvJDC2o1NURiaqB3ut+Cndu3txdsdhHE6VsZJEtd4Jh8aFF6rnMyH7saJnJwG1oDTtnqXPj36yds52KXtsdbxH3t/XgyB9aLAZUZ3goUHM1BITmlz4oSMk4FiNhX8vA6/OY0kUvWYLHaFuQ6Uu11CKsMk7stR1z9jn6giq+hX/KlbirH9aC80BtHN9uJQcu5/zYI4BcxyePAEKPVuVLPsFpPMYbcRxy8jutx2VdlcW10Y6FJ8Vk+VsoBZ/rNjm4RV42+wCV+Obf5Asw7rfnaW1aDqdw2u7zDox6FrRGc6bc4g7+c818x0xc8OVKlEtZ0939P0IBR4da7B/54y0/FScXULfQFk6wCR0ft/LYfJcJ7zNPR6sLuNv1zV8ElCZVNVwP8f9mWSltlrN531/Os2phDTnhKuQ8COPn2sTlU9CDaAlPdAnH8bE17EqoScw6jcR17oeE8nklkeYm9xVONAJ63QWaG/LsJttvNZGk+Q7AsrcttHXaiYmV4EF5kjNutlK9QIlqtLtq Ur83k7fV zCQ4cOMpalwDBU2quLsuiKrwWpczyZmNyxXVq67Hk46qGHrUbr5mnsbUcSLgCKSyG6DbdiupMGINcZGsZ43KcZm7oBmalYpDe1JvdA7rGs+z+BClFwiQUK4vWCzHXdAAaLKW5nFXCaF2frAl3oPydLcH66uEWFOoL9IvwuPcBtXP37ossdD3nYAH2hx54vIVJdnj+aixTHQC+D6ZXPZON4JUtiuopuTAf2bhjM1j8xORbPq7FZq9U255BayLyS5aNYRJQkCQ8Dld17I6YidoFbgHaSBoruowgN+W3OJ8RrXFS+PBqx8oqq8BhcrhDyTBLWG6oeAH9XSmyIdRVN0F52n84bGHydI11BVZWXV/22dxn+xFSJce5hVu/dxnkQVsz7sd2GWz8s2KnoSTOM2yJWe3dWvwf5DFNBo2LdF+SPvQYMzwwyGMQ4/vWRLtA/y/EyO9OxROxw/C6jBZ6dSn5MLlDKL/a26H9p7bDb+cegpmIaKFUmjODln9ssAkwzZDOkA42piafxPVQxsJYpwhODO/NmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 11:38:09AM +0200, Domenico Cerasuolo wrote: > Each zpool driver (zbud, z3fold and zsmalloc) implements its own shrink > function, which is called from zpool_shrink. However, with this commit, > a unified shrink function is added to zswap. The ultimate goal is to > eliminate the need for zpool_shrink once all zpool implementations have > dropped their shrink code. > > To ensure the functionality of each commit, this change focuses solely > on adding the mechanism itself. No modifications are made to > the backends, meaning that functionally, there are no immediate changes. > The zswap mechanism will only come into effect once the backends have > removed their shrink code. The subsequent commits will address the > modifications needed in the backends. > > Acked-by: Nhat Pham > Tested-by: Yosry Ahmed > Signed-off-by: Domenico Cerasuolo Acked-by: Johannes Weiner