From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0EDC7EE23 for ; Mon, 12 Jun 2023 13:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC8D46B0072; Mon, 12 Jun 2023 09:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D78386B0074; Mon, 12 Jun 2023 09:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C411D6B0075; Mon, 12 Jun 2023 09:28:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B57EA6B0072 for ; Mon, 12 Jun 2023 09:28:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 85B1C140241 for ; Mon, 12 Jun 2023 13:28:50 +0000 (UTC) X-FDA: 80894176020.26.F19F3F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 3FDF41C000D for ; Mon, 12 Jun 2023 13:28:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HUpzMYNg; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686576528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k+Mj9724bLjeW+8pzZ68MfEqHEOG9kuaFzo38byyj80=; b=5S9A/Y9RPaWYSzkoY0w1nytCWuHsVvKsIQDCkJGG4kbolCXE2zoPvgPoSfMFoqKYq8SqBr pH1UBYn+pE0rBNtpjTCuRHEFSkW1WfKutnJOQnp+gv3qB+kCtnt5wj6iQyHPoJiQXy/nnv tPMC8yuAWzazbwRkP3oqekoPX3DWuHE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HUpzMYNg; spf=pass (imf18.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686576528; a=rsa-sha256; cv=none; b=BTIUEBujQBZaEUMVuymTlEVYbJol1QfEsQr9KKKdtXPHC00xBrS6zC0+P/+OTfM+7AlyXW ykUYLOim3pwbyWgn6gjNKwrTeQohOOaXLNeLlAovxqmtuMlwMdMxjE9HfZVqmMNYgYXoLR gUrFMxOzofXfxHVBNgdZ/3cHbwswd90= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686576527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+Mj9724bLjeW+8pzZ68MfEqHEOG9kuaFzo38byyj80=; b=HUpzMYNgjmXP4QgygxA8YLqzFNT2TqIO9rRGOWxAw62mtJGYF3SAq6LcAhc46e20j7E3Zp qxSIOeUErzHQqfZgW2esMlma8kfrhQdkKrcFoCf+S5lRu3PTD+QijDNQsE/nctJyFmE7jz qAN4Q095KqfVRcbzfVwo0FFa41vwsk4= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-H3OCDeZjNEysMDcQcwsySQ-1; Mon, 12 Jun 2023 09:28:26 -0400 X-MC-Unique: H3OCDeZjNEysMDcQcwsySQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-75ec91f26c8so93323885a.1 for ; Mon, 12 Jun 2023 06:28:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686576505; x=1689168505; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k+Mj9724bLjeW+8pzZ68MfEqHEOG9kuaFzo38byyj80=; b=QXCYg/3Yusto9LjhCY63tKCrRV4762lg5xfKEEFUt3KUB/R/LKPaS1NEtPpGG6c/kp yD2FamvDcLW/YgfFlXnO98N1NZyxJF89mf+M1AD8FYTmylWTrVDG2STxcOa8dBQIRCT6 yTXzGPj72Hd9xeXujOHWJt87qtD+2XNFYw3loWGBQYb1FmcNI6KuI/0wnLA9tw4uxFrD 182t2LpN8JIek93nroXyFi3OuJlRrxKRAu+xKuC2FrDtYgKqkWhcxJSP30cVeSzPTay6 tWETkss9r0YS4MPbRVzDmc8F0eYaYHinw+kDri/1qB+NkwEIVHDCRrU/e4oJBccuso1l Sv3Q== X-Gm-Message-State: AC+VfDzqw1+T0U5rcWPGHUaqmrJQyR+zrUAnHIPGtZPvnWWm+acRzqWI NInbim3FQ2bcwAKWav7C2eogIIMUiEIQGvp2Yqop4PlJR/CKVITf17vmRBXJ99R8310P4x8JF7m y4OlZHa5rLnw= X-Received: by 2002:a05:620a:6686:b0:75d:50bb:b179 with SMTP id qh6-20020a05620a668600b0075d50bbb179mr8118286qkn.4.1686576505481; Mon, 12 Jun 2023 06:28:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BprxQFUiFZp6fqJHIUXhahTd9h2hPRLyFeFh/cmjH1Su/G5+8KHXRL0Z/ZalQt8tJ1pQEsQ== X-Received: by 2002:a05:620a:6686:b0:75d:50bb:b179 with SMTP id qh6-20020a05620a668600b0075d50bbb179mr8118253qkn.4.1686576505179; Mon, 12 Jun 2023 06:28:25 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id w9-20020a05620a128900b0075954005b46sm2859308qki.48.2023.06.12.06.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 06:28:24 -0700 (PDT) Date: Mon, 12 Jun 2023 09:28:22 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 4/6] mm: drop VMA lock before waiting for migration Message-ID: References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-5-surenb@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3FDF41C000D X-Rspam-User: X-Stat-Signature: kosmj8sraui9cagqg1uj1cwp6pbmha4u X-Rspamd-Server: rspam01 X-HE-Tag: 1686576528-590325 X-HE-Meta: U2FsdGVkX1/cYOcaFnHaxll+KXSF6KGwKn13e0lRPuRdBHjbgdt2XbRjBy5QDh+0zJo6wNyYD5De1Zo/k5ziRurzOIPmd//NtmnHkNlcs2XYaGkLZQT+xSF1C/OFAy5OzRLjLtYCvd3HnXQ7i2Q63acEfpJwIX+oJg113DSjnse8UyfF5fTNkvVsIVcZNX4CtkP48PXTleqZhGy/XTpZ+4AvaXCHdZ1/Q6qOsUoEmCGMBfRpVl4GTApHotQFX/UCjDKKfmRBCerueuQhc58K1Ww3SKKIdbxDoTte5nl2EB+B7YMfPho6r3AEajgw3JJ/RNCirBjA/g6N1/tf8c2mKi5S/ddOkP06VrTk9dX6KYpE7FOAHmoqte2sj7wQMgeuUTz4DgQ+x+yoM26fdj/5kqnm5n8k+ZAMiUCTls2asO3Djga1M/MGFctEIi9QJQ9xQCqNpcU0RBIuSnwoArL7dEp356RymFKmHmMW2w3BvYEzoutmdVU65OggOvaSMg5ZPY88NyMQbojJEPCgvvd6JyBBZyXQ6jtkR3TVr1U0if5u7+mUbvDbGfY15OmQ/O16cP6214LI3i5dTANJlJ57FhLWZsyS2mdmVnikCkGa4Q4W4Aq5Z9kHNRLw9va6t/ZWYHGrf2umgz5K9wrWAznHG47IzuBMeNrDnmQFyYMFNR1e1kRrK+HjrlZf2vU1VMdQfJ9RoKIPKDViW5eGKKqIJl2aqjd9vS7yZdZl+2zpUM6rqKappQ2TR4D2RgVMB83wnYKPJ/fXCaHsFhY/d9OBXgd1EPQErJRcbNPna8hSOLW0BlXYe+WxbtWHtcGRYT3Znqf2UwIbPxT1jT7Tt2/gjE9I1XkGNsVL2xDz2dhdQshUWB30G55fq7q/jNBo28D3l5TaS4XN0DAzXk1DVbCpVqf6n/fqGvTRVXgXwbGr+JCjYKce2SFapxTi71uN+EHnTgoUFwE9id3WahOB/+j hUcZEtiY TKpJCNf7oII/DwAJMUSiOmHASPE7/oXBz+j/c1BMY0im1VMoxSZIEFzuZVUcJm6ZI4MKRAbhAifKl0d8YVY8V5zzGknQ86OqlymhxVq0zqTcy9eiIjfHUy62shTmplsg7R7a5goZMKGVFzWDsCQvx14Ji94tMd1SfuGvV9CvDpEnIKqEIs+l76jREWm1RVV8ZXKssqePbpEbCWb85zTAOnTtt/gqBVFC2lwvWWB0czyi+ATdL9NsBNsaTe+f7WIc7/26hIQB71IvmHpqg25TN82wTJV9LbydMqmx/D/Q+CCv+s6MZ5WxC3FFnMvWJQVnMwYqSilHmc/Ocdm+vVPqLJTI4lhzd8aIfeMz0dwdw8/JsgVvHEvy2PK4cLk5W7TgLNb/+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000125, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 03:30:10PM -0700, Suren Baghdasaryan wrote: > On Fri, Jun 9, 2023 at 1:42 PM Peter Xu wrote: > > > > On Thu, Jun 08, 2023 at 05:51:56PM -0700, Suren Baghdasaryan wrote: > > > migration_entry_wait does not need VMA lock, therefore it can be dropped > > > before waiting. Introduce VM_FAULT_VMA_UNLOCKED to indicate that VMA > > > lock was dropped while in handle_mm_fault(). > > > Note that once VMA lock is dropped, the VMA reference can't be used as > > > there are no guarantees it was not freed. > > > > Then vma lock behaves differently from mmap read lock, am I right? Can we > > still make them match on behaviors, or there's reason not to do so? > > I think we could match their behavior by also dropping mmap_lock here > when fault is handled under mmap_lock (!(fault->flags & > FAULT_FLAG_VMA_LOCK)). > I missed the fact that VM_FAULT_COMPLETED can be used to skip dropping > mmap_lock in do_page_fault(), so indeed, I might be able to use > VM_FAULT_COMPLETED to skip vma_end_read(vma) for per-vma locks as well > instead of introducing FAULT_FLAG_VMA_LOCK. I think that was your idea > of reusing existing flags? Yes. I'd suggest we move this patch out of the series as it's not really part of it on enabling swap + uffd. It can be a separate patch and hopefully it'll always change both vma+mmap lock cases, and with proper reasonings. Thanks, -- Peter Xu