From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C71FC77B7A for ; Sun, 11 Jun 2023 07:57:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DA8A6B0072; Sun, 11 Jun 2023 03:57:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58AA68E0002; Sun, 11 Jun 2023 03:57:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 451B46B0075; Sun, 11 Jun 2023 03:57:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 34CFA6B0072 for ; Sun, 11 Jun 2023 03:57:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EA46B40117 for ; Sun, 11 Jun 2023 07:57:45 +0000 (UTC) X-FDA: 80889712890.12.1200E62 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 1E93D10000E for ; Sun, 11 Jun 2023 07:57:42 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H2FnJnAU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686470263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yNeQCbj8pV3SB38pUZmjA+ecb2r5qadTlgkidFMl7tU=; b=WGqAiusxvheCT2MJS2x1ZtGkbgAyo7PgNoABwL6Gk7smcqRfMJQ+uxaXOR5v7rqRqo/Te8 NZbEh6y0Pc+qVEyO4TRSB5k6G4S7afYPE78PUZvmhNCfvoV+oI+hioZmom7UXG5HsRwy/j YhQ1te1+M1l+zFU7jLKe8Uww+c2eKSw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H2FnJnAU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686470263; a=rsa-sha256; cv=none; b=2L73Hx5cxuMdyLI/CH9CmVHcQy/9FBHpDuMKvSvJUSsLNCNmli08aHacGATGvr/Bwd4rrW yVtAfbqKo6UuRqjC7ZOircfEMies0QGbUpkBAwEUbdG6cY0iBWUj/ku51rG26ZQ4NQP4V4 PPjQJvKZ4G/fvz6uREveLZC1gfMwcX4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686470262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yNeQCbj8pV3SB38pUZmjA+ecb2r5qadTlgkidFMl7tU=; b=H2FnJnAU6+4BPLgHWFvwz4QxtQX4I6JEbyNH7NqUTKMRYUX/kMp/PikWiHtQcGNAsPsaOG MHvdLMWY8uv6fULeKtynTgFSl4r1wVHJs4FMcu4Vmm3WVMJPdxNsPnJ/c2zQnMMS3p8cHC 00arV1EUCqaoI27EfrVRvjhnTital8o= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-481-DkUqp_jjOe6hP2QQpRYblQ-1; Sun, 11 Jun 2023 03:57:39 -0400 X-MC-Unique: DkUqp_jjOe6hP2QQpRYblQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31B181C06909; Sun, 11 Jun 2023 07:57:38 +0000 (UTC) Received: from localhost (ovpn-12-34.pek2.redhat.com [10.72.12.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C891400E6C9; Sun, 11 Jun 2023 07:57:35 +0000 (UTC) Date: Sun, 11 Jun 2023 15:57:32 +0800 From: Baoquan He To: Mike Rapoport Cc: kernel test robot , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@lst.de, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, deller@gmx.de, Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v6 02/19] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230609075528.9390-3-bhe@redhat.com> <202306091859.NhlW2nny-lkp@intel.com> <20230611054019.GL52412@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230611054019.GL52412@kernel.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Queue-Id: 1E93D10000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ixh19axsrjti9oeefzzttmj3ee658nbo X-HE-Tag: 1686470262-170054 X-HE-Meta: U2FsdGVkX1/rEjiyrM5bk9OdjJ1bhUbVBm+d24/c6AEU1SVQe5SebbF57iuoI8XJwuXk12Fmip8lG3mjAW9KkcrHwmZrPLX2JbVbylm9dj3tuEtmxICbsHMn1iXtJ7D0SjxyeuRsFqDAJ1TxiA9bDjyf4pzQS9W+CQO/VkVHbkig0BOstmliCcFtxOX5H6GaHlFJpZerYdzDDCCx7lMcN6cCVHlq6HkE3TMdgJZwrIWM6UnLIOt000rOPAknj2bcKvOCnrM9oRCkWgWXBfu3C1vy0nZGGtlfgdXLRyY8J0nLsA2lwXzRnW95mvwNjo7hP7T2Vf03w/U/PKFAufGZz2jLEkpruJSnui4vOm8zscSiz/1HujLvCSc7imRzrTGILa3k2F1kiR7ZPggkjSRyKkfSN0NodIBDCt13kweV/fN9YMlOR1xQZ5guxSyxKptA1PlWdWIIz5k6tOpdC9+JReW6PQkMqV0SdaDg/m/v/E1/pu4qnkHXZo1M5Gk17hSBe3wYd5Q9GzS3HqCqgGWIlCNrwyZQJj13U/BnItg2+oKuNVMxavOx+RZ+UbQFVVy/mN/BiCLkK/RP7ijLsRX7mdsLHL58/5K+zeRafw1Ex/getWawB5GVgogXpWCEuk4VC5bnOBzmEk/csgj6bk12oB8HvgjDwdY7f5BjZwh5IlGJhBqLjIK29hbtUkSs4buw2vhrlxvzsc6nPd7t3GrAcFLYviY9RwJ52G5KgcSK7bTH2wPd9Dc/tQhpzRmcvs1tR98SM1E8F7meMFkOi/WXZbZfm6byhVnwYtFCeJ419Fhl6qYtm/i1TcW199J3qe5h0OVdBkZerwsxG94w4OVWFClpQtuaYiQQRNE6yTzKgdjJc09geYDwNvy5UFpJXHDK1/c0+P18LU7vObJUMoZighL/zxFghOW3iogx3XTr3LINl2a/r1bD1auGUIjATuXMdw5IX6mUPOkG7DRJEgu xaS1Fya8 +eBjwHAG2td/WX8GDrLqXfM5Xvb3R+j6mfLXjit9DVP02JE+jmqkhpVYSz8vAtjStRCJ6fhWR+k2AFfERMKSwaCcQHRNqWMfS7UgdFpwMW8tWqOPBftZOAjLHKqsD6qiITQTudfwIn99LnTbp19xygNQ5jBhkuOYq7GIHL829w9uVhaGwjwYRBBZ5Q4WOELbKKrfolcZSpBVzRrHrL7Bp9l7Q48PKoHA/tfT8CePyWyG2K8fDwQpXDktfqf1PvidrE3t1EFSX1RCeebanX4rsuJxW9Ll9ZIe+cLSjwS33nqtI/nWcdNcADVOA/IDH6VEdwcsXB8jZ0+fL9fTFXC0gRvCBaCfO9eZpd/bCJ6020TBK8PszijbM0dfgP39mGGuSWppuc/5craW/gWG1Nzx/nplUjTat82BqvJTfmMil6PJP5GW8gme1Wo/eEYT2bHTGykgUnV/3kPFb7S06SoLGG55Vy3ftSNUICSr3OuBW7xYqK3JbR5FEM0iPMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/11/23 at 08:40am, Mike Rapoport wrote: > Hi Baoquan, > > On Sat, Jun 10, 2023 at 04:26:21PM +0800, Baoquan He wrote: > > On 06/09/23 at 07:09pm, kernel test robot wrote: > > > Hi Baoquan, > > > > > > kernel test robot noticed the following build errors: > > > > > > [auto build test ERROR on akpm-mm/mm-everything] > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/asm-generic-iomap-h-remove-ARCH_HAS_IOREMAP_xx-macros/20230609-160014 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > > patch link: https://lore.kernel.org/r/20230609075528.9390-3-bhe%40redhat.com > > > patch subject: [PATCH v6 02/19] hexagon: mm: Convert to GENERIC_IOREMAP > > > config: hexagon-randconfig-r041-20230608 (https://download.01.org/0day-ci/archive/20230609/202306091859.NhlW2nny-lkp@intel.com/config) > > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > > > reproduce (this is a W=1 build): > > > mkdir -p ~/bin > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > > > git fetch akpm-mm mm-everything > > > git checkout akpm-mm/mm-everything > > > b4 shazam https://lore.kernel.org/r/20230609075528.9390-3-bhe@redhat.com > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon olddefconfig > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon prepare > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202306091859.NhlW2nny-lkp@intel.com/ > > > > Thanks for reporting. I reproduced them on my local machine. Below patch > > can fix them. And by the way, I also saw the clone3 warning, and have to > > made change in scripts/checksyscalls.sh to mute it, wondering how you > > handle it in your testing. > > I think the warning kbuild reported is rather this one: > > >> include/asm-generic/io.h:1078:6: error: conflicting types for 'iounmap' > 1078 | void iounmap(volatile void __iomem *addr); > | ^ This one is reported as error. The old iounmap() declaration has a const, while the standard one doesn't have. So I just remove the old one to use the standard one. Another one is warning about PCI_IOBASE. Because inb/w/l and outb/w/l is redefined in asm-generic/io.h, and it uses PCI_IOBASE which is defniend as NULL in asm-generic/io.h if ARCH doesn't have its own PCI_IOBASE definition. Then the warning is triggered. So I define macro to override the standard inb/w/l and outb/w/l. #ifndef PCI_IOBASE #define PCI_IOBASE ((void __iomem *)0) #endif > > ------ > > stdin>:1520:2: warning: syscall clone3 not implemented [-W#warnings] > > 1520 | #warning syscall clone3 not implemented > > | ^ > > 1 warning generated. > > > > ------ > > diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh > > index 1e5d2eeb726d..3a369b78edb7 100755 > > --- a/scripts/checksyscalls.sh > > +++ b/scripts/checksyscalls.sh > > @@ -148,6 +148,7 @@ cat << EOF > > #define __IGNORE_nanosleep > > #define __IGNORE_io_getevents > > #define __IGNORE_recvmmsg > > +#define __IGNORE_clone3 > > #endif > > > > > > From 6a86f4360a61a2b7b4d71172e5c03be554367553 Mon Sep 17 00:00:00 2001 > > From: root > > Date: Fri, 9 Jun 2023 21:21:36 -0400 > > Subject: [PATCH] hexagon: mm: fix warning in asm/io.h > > Content-type: text/plain > > > > Remove the old iounmap() declaration which is not consistent with the > > standard one in asm-generic/io.h, let's use the standard one. > > > > And also add macro definition of inb/w/l and outb/w/l to override > > the definition of them in asm-generic/io.h. > > > > Reported-by: kernel test robot > > Signed-off-by: Baoquan He > > --- > > arch/hexagon/include/asm/io.h | 8 ++++++-- > > scripts/checksyscalls.sh | 1 + > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h > > index dcd9cbbf5934..efe9cb00ebf8 100644 > > --- a/arch/hexagon/include/asm/io.h > > +++ b/arch/hexagon/include/asm/io.h > > @@ -27,8 +27,6 @@ > > extern int remap_area_pages(unsigned long start, unsigned long phys_addr, > > unsigned long end, unsigned long flags); > > > > -extern void iounmap(const volatile void __iomem *addr); > > - > > /* Defined in lib/io.c, needed for smc91x driver. */ > > extern void __raw_readsw(const void __iomem *addr, void *data, int wordlen); > > extern void __raw_writesw(void __iomem *addr, const void *data, int wordlen); > > @@ -207,16 +205,19 @@ static inline void memset_io(volatile void __iomem *addr, int value, > > * > > * Operates on "I/O bus I/O space" > > */ > > +#define inb inb > > static inline u8 inb(unsigned long port) > > { > > return readb(_IO_BASE + (port & IO_SPACE_LIMIT)); > > } > > > > +#define inw inw > > static inline u16 inw(unsigned long port) > > { > > return readw(_IO_BASE + (port & IO_SPACE_LIMIT)); > > } > > > > +#define inl inl > > static inline u32 inl(unsigned long port) > > { > > return readl(_IO_BASE + (port & IO_SPACE_LIMIT)); > > @@ -227,16 +228,19 @@ static inline u32 inl(unsigned long port) > > * @data: data to write to > > * @addr: address in I/O space > > */ > > +#define outb outb > > static inline void outb(u8 data, unsigned long port) > > { > > writeb(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > } > > > > +#define outw outw > > static inline void outw(u16 data, unsigned long port) > > { > > writew(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > } > > > > +#define outl outl > > static inline void outl(u32 data, unsigned long port) > > { > > writel(data, _IO_BASE + (port & IO_SPACE_LIMIT)); > > > > -- > Sincerely yours, > Mike. >