From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3D4C7EE29 for ; Sat, 10 Jun 2023 01:51:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6356D8E0002; Fri, 9 Jun 2023 21:51:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E4676B0074; Fri, 9 Jun 2023 21:51:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3288E0002; Fri, 9 Jun 2023 21:51:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3DE056B0072 for ; Fri, 9 Jun 2023 21:51:56 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0E7D9C03C0 for ; Sat, 10 Jun 2023 01:51:56 +0000 (UTC) X-FDA: 80885162232.19.CA59A07 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id D1061160003 for ; Sat, 10 Jun 2023 01:51:53 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dkJFJ8ZY; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686361914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rvR6dekxmIrpYjXvV65854iQwAmXJOxjH90USp3ojPU=; b=MmeAODJxU+q6gylfiBJdMoqTMLwHyrddZd+Xup3oPqojdpqZgvJ0tpsBuj9bh7OMGtbZcI ABX7PRqkrI3cVRbTSImTE9mmZaqPHrXxXFqz/FP+jE0sPVQkIMuIx4PadK4C2h4QQLJCka uezG/dFidfZWE6K2sP/dCumOaNCQagE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686361914; a=rsa-sha256; cv=none; b=VZOP1q0USMen/K1gKcBj95hzPYAqRHLknJx5iZnRei7wcggFBMcm0+fHDTwYfD/BB/XPVT Vzicu2ZB+9mUlXmeX8RALhY7xHsZqiViforROHkrer7se2CVlhjTYI+lNgGxlM78LpX07/ i3SfqwuzgbYfXQymWyboqvvpXRbPEp8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dkJFJ8ZY; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rvR6dekxmIrpYjXvV65854iQwAmXJOxjH90USp3ojPU=; b=dkJFJ8ZYNaV+JBxahyxLYGOPcC D0MaV1ccDO7CA8v+voLS6TUWourA/iBtlDzY00iqgT1KwrznvuJ+qbuSaTqnxcYdaNZdVgx0z18oq w/mJVrR6Kpy0V74k2ke/icCzvaiUixHLy8V69u8iwAxnBVklfVLIAgX72mh4703GeLA8137nmVmmt 0eJDTD83WgeQrBXKMzXf/f6CFmzgChGE5Z7NIYUgvutdMQSNZC56Dbjir2TBUM/kLc9kVQrES4Tns rFm1JOZa+i1aU6XX7O7nR2pOelHBxPCkbLqQLzKu6WXea+K3iZrai+ysfUZ0/eNRHH2LzrMZJEINk AD4piwdA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7nlQ-00HMf4-Sc; Sat, 10 Jun 2023 01:51:36 +0000 Date: Sat, 10 Jun 2023 02:51:36 +0100 From: Matthew Wilcox To: Andrew Morton Cc: "zhaoyang.huang" , Suren Baghdasaryan , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com Subject: Re: [PATCHv5] mm: skip CMA pages when they are not available Message-ID: References: <1685501461-19290-1-git-send-email-zhaoyang.huang@unisoc.com> <20230609153519.ff01046ef0faff00a74bd5b0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609153519.ff01046ef0faff00a74bd5b0@linux-foundation.org> X-Rspamd-Queue-Id: D1061160003 X-Rspam-User: X-Stat-Signature: 6kp3ziarb85rwuiazbj6x446mgucec8w X-Rspamd-Server: rspam03 X-HE-Tag: 1686361913-691058 X-HE-Meta: U2FsdGVkX1/1q2VJL947lcCpWBoDPMhMWsO+CkyXh9ZTLzS+v0mFdo2GY02Kjep9UsUviWM72kbekyr1XfDQOB1Kyo/8KoYtX2StLjJKX9OvA3HPZLKl4ojLr0rVqmTOh/GnRe4SFJTf4rDg1n323ctLtwiQ56L8zMqcPKh3XW/xB/9yGzKnYDlt/U7A+AYkxtPZRcAAD8s5QPrsXGylgdX+epCL56g8Wj2A/wRza9qpcGmMt/kiS7F+KjDuLm/yNtEl9SKVYUdAqol4wWYBIquP+wzRJyRVAWWmVj9LQX6TT6JW0c26/50nZUvA3CfduUNJtobOwngQWdAkMnHbuuEIzfQyUXUcLmS60pWkcTGLHq304daltAIyK3WRUeE2f1SuW4XDZtyhZ7rx46r0PB6kR7pjtw9cqqj+7Cw5v2GVwLSQClGeIBN8ZyAyJCQ8n4h3KQUZ+wcYYYGHO6hx7RJ8h2zpd9Iep2cNy2Mt5TCp/E/o/iDGLwe0PDBAaSzOEKiDBDb1koF/mpbZj9/m6mMguKRpJW5uKg6ImlkeIZ08ZERvT0D/UFg+sRmDLjgnyTWXbYpnFNQ4rxXDs1VuYWh9PTlbC3rXOlSejU9ZQ9fdXXftHS+WMRkHittu35zOpcA+FInReW4YVuvMzh/qFC4XYKlJm5gQRGqWqHSvtv8wtqi70SK4Etm2eBBXSuS10jL+ANIJ5rw0OCBLBnF12NsHrh7DCIhEO2BXTmCgZFVBat0AGgmCUl8fSPt1TcpawVHX9FQ/F0JGCyJEUJUZoWZw8yiw9s6dftqWmRrdoLGFz41h2zKW0qNF8LQD3odf9+3JWGwc1P6vNnX1RgPyHGGRdQ3gYhz1QsUGmwEFXc6Bi9vMSeDqs2mWHUIGdA/dTl7N7eX0X6JXshCN5Ntxh+gl75XHJ6AphYKbo54q2Se1rOma5z3L4+TYwpwEzdl2+pai7m2hgsgsqViBGSu Dv6Lcfcv 2nnlp6y3JUpcnBsAYUB2XIyTDPBtzZbhF7LFdg+i4Ry1DTTzHeoM063acTL1s1k/KEB/gfILQv8AJE9zmh1iQdBIVr0JzuSoqTSBjlhqincRQt9KUFqGdiKo3CbJraSpopd/dykDPz3sTN9k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 03:35:19PM -0700, Andrew Morton wrote: > > This patch fixes unproductive reclaiming of CMA pages by skipping them when they > > are not available for current context. It is arise from bellowing OOM issue, which > > caused by large proportion of MIGRATE_CMA pages among free pages. > > We saw plenty of feedback for earlier versions, but now silence. Does > this mean we're all OK with v5? I'm fine with the implementation now. I have no idea if this is the right approach.