From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C49C7EE29 for ; Fri, 9 Jun 2023 20:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98F0B6B0072; Fri, 9 Jun 2023 16:42:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93EAA6B0074; Fri, 9 Jun 2023 16:42:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B89C8E0002; Fri, 9 Jun 2023 16:42:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 69FD06B0072 for ; Fri, 9 Jun 2023 16:42:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2050C120308 for ; Fri, 9 Jun 2023 20:42:08 +0000 (UTC) X-FDA: 80884381536.04.799F6CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 0358C20023 for ; Fri, 9 Jun 2023 20:42:05 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ql1Q2gTL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686343326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+p+efMF1py6pEpvkihdBi8OztSv7Pz8tdWi2Iw9yIU=; b=aShqZdIzrkQuuIYrlGcrNifxH2/COdBYBup1b1u+I0nc1uBqCR9Q02KVr6hXeP6zC7Bxkz Fsv86PX5myPQAyOilmQdtGTfliHrONWe8pVaL88p0kewxUK0W+OngQteyIYrL9iPbUl/l/ 3pKSQ/bFNfop16B1Ju2KEdLpnSAHRKU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ql1Q2gTL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686343326; a=rsa-sha256; cv=none; b=Bg6cFjFUprdI6GJPzjLcBISrz6DK67EmQwYYxFedhyWN62Hrm4dn/owweQOPYebL9emHiG 9zgmzz2dShE9QdE+1s59I57lc5Wl+Rv8FCgNf5/ys/VsX2fxbfLmZlKS/Jt6FA0sWdw/9Q z7ZJmM7gY8CVPqWVGp+tcK6FPnU6csU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686343325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3+p+efMF1py6pEpvkihdBi8OztSv7Pz8tdWi2Iw9yIU=; b=Ql1Q2gTLMWewSfgVXHb+IRl5Q5qpGrj9j/T3OX18cV8NnOwgXYD1LABz/ObqDPxqyIiJhp gvQa1DOZGEgeB1klQE4Q/A/o9qVFqsigyHoyPb16La5XoDl8mMXX0r67Wxmvb5QfF2EF7E EsLVRLLjwR8/PGUzLoTCQPezTCuo+j4= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-5vlsis_1Mk-s-rK0D5S0dw-1; Fri, 09 Jun 2023 16:42:04 -0400 X-MC-Unique: 5vlsis_1Mk-s-rK0D5S0dw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75e681229c5so47431485a.0 for ; Fri, 09 Jun 2023 13:42:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686343323; x=1688935323; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3+p+efMF1py6pEpvkihdBi8OztSv7Pz8tdWi2Iw9yIU=; b=gmbpSZ9rQSXTL7Vp7/3ChZGKfy4x2Yqn+UMVepYTgJMbpl7fOOFA3K2cDhfhriCWO/ TG3m8O6sLPLTKlhJjcYYLLPt/1cVLW2pZFRlczZGRc0hOP9wkM+bWUwen7qkjImia3W4 Jm80ftDgN7g9C4e0EsPZHZz8r7qAautlDMLdWq/zo8kLd/BfJanRrNcj4VEr4BnhjSR0 qR5mvsMS7lbOIZpdS1lqxVWqXEg7M8+cs2T+UzB4OL6Qc2ncGMFXzuIHLGj/5c7a495N YsVIjHS5ye6uEjWqp2T6xU4H6w8KTVInDyofNCXi4pTTwl2OmendZprwJCUqXFt9wvmy 1GqA== X-Gm-Message-State: AC+VfDxtMtLzhdn2z8zIGuEzuix4+VEiP/gHCEfsQogEhDEuOm7+40sV a1ngD7gAk/5vbt4W469SvfYsB+vh3DVLXslGYg2cYllK+A72xr6oApBK7do8I0dp/9cP0r2dXWV zWpsNa1mz9cI= X-Received: by 2002:a05:620a:46a8:b0:75b:23a1:69f0 with SMTP id bq40-20020a05620a46a800b0075b23a169f0mr2844966qkb.7.1686343323576; Fri, 09 Jun 2023 13:42:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5MhYTYYAIL9lllr8F5q12r8SC+qD0eDeSyZp3uUsLxhZSNfrjXGqhTrE3LVMEEYGVFirie1g== X-Received: by 2002:a05:620a:46a8:b0:75b:23a1:69f0 with SMTP id bq40-20020a05620a46a800b0075b23a169f0mr2844938qkb.7.1686343323262; Fri, 09 Jun 2023 13:42:03 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id x14-20020a05620a14ae00b007595614c17bsm1259288qkj.57.2023.06.09.13.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 13:42:02 -0700 (PDT) Date: Fri, 9 Jun 2023 16:42:00 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 4/6] mm: drop VMA lock before waiting for migration Message-ID: References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-5-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230609005158.2421285-5-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0358C20023 X-Stat-Signature: uq5d7x4ywi778mf3tkincgttx58zaais X-HE-Tag: 1686343325-419649 X-HE-Meta: U2FsdGVkX1+uE56M+ttqvfSdRzo0a+aRcGx7Ic8g7NnjKmih/1UYdsDBOa+i9xihpjPC8THAhUEk5I/8W5XE/yJCUVwQhXp9b+8JFUsX+tfeJHRjgkaQrj0tjKsT9Gun9i52rJbPzzFiwOjiXtDNi2E3EQoq/L/J3eF11szTLPQkkzLoB223s6ud/8uTmlGZ21qo5DIsD9oHaUgPT0eaHTg8S88OxQGKfA0Zrxp6d4ZK4Fs1Z8GFuwEs/Pjbmr2unAXEHYCDFhU2YN6pWQCpHJPf9qkyJ2a06eO9UZOe94xYRf8PYkV6mUhCc9T+YQ9TsdEC5me/y4Ztd50vsSM+8FFu7EVDZBw73yPFKSEQkg6xqU9IGXpzmOCt64yJT0/kd+6EvYx9jnQDbvi9S0rOjdHjguzCFZ54i6ZDM49LEn40asbZDNnbAf5XwBaN6avk6/aNv/Pr5zpnIIs7Ke0Z+lm1ooMRjNG+tEqaiG2knfwcwTua4W1wIED4HhsbYcxVdr9txsAvJDJf9T8NFvVE677QSelxY4Bjd0HHRCD9NC434+M7AV9fFejN808MOEBcABLIhVgJrwiMYk7hApZ2Bx8KiwDAEf0xKkqrj4WchDyqnQn96XlGtA2stDbnob5552/HHNCffdCeQy+UsOOE0l+JvYRZHSgySbB51GD+aQ6Cov89SUF6fPcAAiShux/y/2ZQ1vx8hMg9xWGNsI1iOjMvct/M3YlEHO3lBtyk1EIERb1LF4L08WjRdfa87zljGR48uGQfN/W7JviZJjgAVu1lhFGJFFIFcnJp7ejWxWPOVszm0cWQkffHNBPUWNbBMOqjYQHzsKyTCxtzvGcCgjxf8vILAwx9aHXmQleUzT1P9DnWjQXRItHyAAF2eGZXMwLcKUW6V6aYN1/Ku9QqUOUQQP0SGzO0vqWVjAgRX5QC51omjaCSOqcKpuJPIvhmZVqmLWoRmp/UrU/BreP 2Fk1oHKQ jLI2+ju2Fth5ZSQbMTdsu8shoiuAEQArzlVNR7mXVmgp+PuKuqtNyue4Il/Jgbf4upzz2lPO8pjsdn0To58K0z2yoYrmmmTv1lK09Mmm4uu/QH4uTaeRtlq561kKNZjGBqvjBxpIvSwjzOXXBbsx2VJaKPVNrNgoDMAA0Da05Z7xyRoZ8PIMU6/QBGOAJuf6GZMq0O2paQ0U//jV5HYG2jF5HzUw5q/UmP6UCgn0dGkyWmPQ0JNBBrwbBKM4nTkv8Ey1jVXxqDL3IAJgS7pzZZ5jNbRIaZ0Z6pl+Kw2FfwzEe9OuJL87ghyAou4i7xyp62tQC7xSnZ73UZRf8SONuFLJJqcDXHlBucL5bwwLb8YGtmPaUVvjpU7FRRkuj6jfz1o/QmH8nobiojJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 08, 2023 at 05:51:56PM -0700, Suren Baghdasaryan wrote: > migration_entry_wait does not need VMA lock, therefore it can be dropped > before waiting. Introduce VM_FAULT_VMA_UNLOCKED to indicate that VMA > lock was dropped while in handle_mm_fault(). > Note that once VMA lock is dropped, the VMA reference can't be used as > there are no guarantees it was not freed. Then vma lock behaves differently from mmap read lock, am I right? Can we still make them match on behaviors, or there's reason not to do so? One reason is if they match they can reuse existing flags and there'll be less confusing, e.g. this: (fault->flags & FAULT_FLAG_VMA_LOCK) && (vm_fault_ret && (VM_FAULT_RETRY || VM_FAULT_COMPLETE)) can replace the new flag, iiuc. Thanks, -- Peter Xu