From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22E8C7EE2E for ; Fri, 9 Jun 2023 20:10:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79E798E0009; Fri, 9 Jun 2023 16:10:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 727DE8E0002; Fri, 9 Jun 2023 16:10:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C84F8E0009; Fri, 9 Jun 2023 16:10:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 489358E0002 for ; Fri, 9 Jun 2023 16:10:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F07AEC02E1 for ; Fri, 9 Jun 2023 20:10:30 +0000 (UTC) X-FDA: 80884301820.13.600B946 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 3CE6E140024 for ; Fri, 9 Jun 2023 20:10:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vT+xFxto; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686341429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0HXVmnlVKBq0ssRDEmsoSJn11Ep+kO0iOz1cvxDsGzc=; b=DQFQboqN4jxgSyZ5NJD1FjAUMVUlhgyIv2Vvc+Xd2tjekqW9Hsznb1Lo3dIUFZljq06zc1 mXHMtW0lnD30/v8DG2xn+OzHcGx9OxBS9D8otVPinCGCO74mHrbdV2B/WOxT8iirj639bN GoCCU1ISJxiElCVXE9mzVwIZwWAJewA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vT+xFxto; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686341429; a=rsa-sha256; cv=none; b=f+QlSj3yiFa1wEqmfuwzDP5VU6+keDnq4aKSRzwwqW0401YcycXAgmirVmWVWKX8AiG5xr JVuhLFwAOYHY3RBu1SeEspCl3k7XIMU9UaNJ0ZeWuh0S6oRUck+KSfAE8dZcV9GqAigcYa WD1dJvUJzkf78dIVlHkLPC6E6QsmAnY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0HXVmnlVKBq0ssRDEmsoSJn11Ep+kO0iOz1cvxDsGzc=; b=vT+xFxtoVOxsh/JuBcSwVFlLSy r6fZ4SHqauLNA9/u3Aiy1rp8c0czsXItXrtZECi7eXEGWxbUikInvpRcBGgyU3pF7fmsLlVE1qF8D KlTB7x/z/xA408e5tWzxSWZ2SrKK2vlKiiLdgA2/GKBtbGYfrZtOm7PD04m3Twqn8QTvFiUNlxhZl BvVy0nx8n7c+20mtzJtpismK3vaH8HCZ0OvYcGWesw2xcvDU7WeRHU5bsFf2wRS3id+yilq7q4/CL ENMc/K75BorOzls2PQnRBSJCJ6ayKPlsuMWDVDtSHWMqZVcCWh5DQirBp3/rlbrl1m62gpBb/60aS s+7lw45Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7iRD-00Gzss-8m; Fri, 09 Jun 2023 20:10:23 +0000 Date: Fri, 9 Jun 2023 21:10:23 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, david@redhat.com, nphamcs@gmail.com, jthoughton@google.com Subject: Re: [PATCH 2/2] mm/hugetlb: add wrapper functions for interactions with page cache Message-ID: References: <20230609194947.37196-1-sidhartha.kumar@oracle.com> <20230609194947.37196-3-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609194947.37196-3-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 3CE6E140024 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ggmwgecwhx6f1qbyzr6qsd64fnefos41 X-HE-Tag: 1686341428-275890 X-HE-Meta: U2FsdGVkX18ERO+9MQQ1zcm5yGPr7DTRhg4YDffA08eS6wDSZlU9ozfvNhqrvQTva0RpVjazgv6bhPixZIVURMCEYDufPYEgrkNmj5QnDdEBRKdROhadcpDCzxViyvsVbErlvxoUByfFgXxXiO6bhDDEbgNDifmeepfy0+2yeWW4K8GuI44YezW8MoZcHUTs62ZhUKZVWMQKDBur/iDHRIuwp2YS3NvCwzYpbzGpObbiPL6nPbRkwIWUlTt4+SvbKuMl1jwaRjFMFcfqNCMeR9kq56QPAFErSOvwuW3hilrbtPrTHP5Nz36ichjgOl7D6ENxaxww/WEEzKx7vo/TguHH0WHEVmztmC7tXohzU7n2T1bCJ7o1wFX9KapFjsr0kfXBNZdyt2M4xY5EGhujYSEp8GimaI9WZDzESrYuW+aI/rqx88to1ml8AFfZA8jnXrIFxf0qKjIVeLsFSXHEb8hntRh8z4NrNAmIekTIWFf+UzeNYT3Y8aTqgZMbbaeTUhGOPhf3Kiz2Wd2bvRUKrjgDnzYthjXv1WWZv4zjDwMMAxB601Mw5hX99cPbSfMbiHt+HnvAreeGqBVu7sHNUN8R3g5dipP9vG+7vjQM9BQm/kpdeL6pKJGEoYMTdXYV1T4DYJrBORYmOw9TOrM41DOzd0sOtYIwgIrK4R6EAx4BRytqHt88E8B36toGqfmRVmz5t6gzEFvKqsPbxcjtQdrY6we2Q3U13MWJ+2Io22J+opCsi2fT1jmTIeMWNRc0xF8RjC/lCgnszvzkC4qIEiazhxfULOXow+Ck5yUSrvys2KtVCGCsuD8QrDAG7asEZxepGiTjgTJ+I6w73snkB5/lMKkMOzg0xN2zJ0uihv4EQzIYcDcoxfRIGdjQYELTzZcaJvuol/c18oWBHIM5R4JEyAk+VHPHZcJegEsRAt+N5KhnBJENVSLtbk1eRqTLWuvQy4Y4TVfY22hOjx3 AH/q84uv up4IVXoqQgx0eLMJINGghKLfdydwtMJ8L1DCt0pPFLfcw4cDQ81LxtDlSuX4JtDvcE67Z5tOgRMWQ9Vxh8o5CQCXL+BCIqWi06To+fQTg1OUYG2AtQTz6iLk9WJWrSjOpMUfcBujpHe0paUA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 12:49:47PM -0700, Sidhartha Kumar wrote: > +++ b/fs/hugetlbfs/inode.c > @@ -617,20 +617,19 @@ static void remove_inode_hugepages(struct inode *inode, loff_t lstart, > struct hstate *h = hstate_inode(inode); > struct address_space *mapping = &inode->i_data; > const pgoff_t start = lstart >> huge_page_shift(h); > - const pgoff_t end = lend >> huge_page_shift(h); > struct folio_batch fbatch; > pgoff_t next, index; > int i, freed = 0; > bool truncate_op = (lend == LLONG_MAX); > > folio_batch_init(&fbatch); > - next = start; > - while (filemap_get_folios(mapping, &next, end - 1, &fbatch)) { > + next = lstart; That's suspicious. Surely it should be next = lstart / PAGE_SIZE; > + while (filemap_get_folios(mapping, &next, lend - 1, &fbatch)) { and 'end' is supposed to be a pgoff_t, so lend - 1 is also suspicious. > - index = folio->index; > + index = (folio->index) >> huge_page_shift(h); You don't need to use brackets here. While C's operator precedence is legendarily confusing, the arrow operator binds far tighter than the shift operator.