From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29B5C7EE29 for ; Fri, 9 Jun 2023 20:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3821D8E0007; Fri, 9 Jun 2023 16:05:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 331F48E0002; Fri, 9 Jun 2023 16:05:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F9FF8E0007; Fri, 9 Jun 2023 16:05:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0C47C8E0002 for ; Fri, 9 Jun 2023 16:05:12 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C79D5C02DA for ; Fri, 9 Jun 2023 20:05:11 +0000 (UTC) X-FDA: 80884288422.25.0DDA3EF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 1BE9C40020 for ; Fri, 9 Jun 2023 20:05:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NcFvBnyu; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686341110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nwADDUrKoquslbkQhilAcI+nBT8U0StudfpI3E0X6k8=; b=5k+OYrOoFH1Xj6piSvacFYGO+A/ZcV2BqN7vXdaZcovsTGshrdasuPvIkpOY81/ex89cUs fEOr/p/L2rUM5tpL27cvRNt1tubuIbSswMB59IwF60Z5xX7wxjk1SYJnt7pdZ37MP7uL3b IKBDesrRkLY0tM75uGomyfycj6GbOTQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NcFvBnyu; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686341110; a=rsa-sha256; cv=none; b=Z3F+hmfDzBHLix/+7qh+rSsz3vd+Uttk4/bK+E/ed5KbXyzEG/dPuoAXgt6+Vyy79qaQrz Pq5VNItYKrWC3tTnax7hCTgZbAYkRyr8gV02RRZaLh7HOEkqYfE6uHEXr73/kbG7Q0mYl7 bbdl5jOvwyVzHFl0XcXq8X5f4xphNp4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nwADDUrKoquslbkQhilAcI+nBT8U0StudfpI3E0X6k8=; b=NcFvBnyuPerSHYDFtTbTbpgMsl g29ZmA3RI2PklhvWfbuDIjYArmenw63kB1c4h3R7IJ5WYGozbl2yDcicNZan1fQvtiPI2Aro0vj2z GXO6r1S92+FtqshiFEKtM5Csem4PHw7apj8CZQlNA9Qj9OGILc/8aUJpXq9TshOfJ9gZbXtZVBLyY P3GEHk7pPVHsJfHPp+hPzEDQe4DbUG+vvA8Rx0q3SXe0ojfDVoEWyIpUxs+eP1R5S7lRau1+OToLd wjqcEIazR+UfTFxG3K7LBtqYhaR/akVAOdgqXAF9WWWa3HovqZqIlcGmmmYm7W3nV1CjIEBWPSBec cl8XCwgw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7iM2-00GzYo-7p; Fri, 09 Jun 2023 20:05:02 +0000 Date: Fri, 9 Jun 2023 21:05:02 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, david@redhat.com, nphamcs@gmail.com, jthoughton@google.com Subject: Re: [PATCH 1/2] mm/filemap: remove hugetlb special casing in filemap.c Message-ID: References: <20230609194947.37196-1-sidhartha.kumar@oracle.com> <20230609194947.37196-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609194947.37196-2-sidhartha.kumar@oracle.com> X-Rspam-User: X-Stat-Signature: i7z351hd9n7cfxpz9gy9rkaho95qj5xj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1BE9C40020 X-HE-Tag: 1686341109-650882 X-HE-Meta: U2FsdGVkX18NZ2rb+lPhOGn7KqO1Ucj4sF8W4uu6NGacELoZlXGRgy/rpBmZMwftm/lYUpMUgPABowLziZ1Ru5zF/TMZL1sn/IsFIyQq3LIuVbZfyXnUQ/sEDT4KYey2THHdHzLNkgWELM5o8H4NMbQz9dVLh4Y4vjz9fc0wGd+hLV3F9PKIa2b6uSNiMsvo+RatjkHpPcvYPPvO2Jzxb7SQUyFht1gHBykOYQGDl86jlAULv2H9EfsQG4p8cAnJwPrw/6YUE3ZWSiJ4madD+9PH4MULqA5Ft2oL5Q+frkGrR8NEqpq4JKp8eG+tjN8SBovNHIS9ZLwtefYqR+sgXehYLqjtWAQBSJ8XVa5ZbKxibYwTwl5PhrIt8POXD3BKXU5WeYeVgn4BAS0q99/HXLlqVQR988O3G2C5nHSsFW87Y7a9BmRsPge3DYfO0RuZlxbxMwoGhPB/L7hCMnS1gNOsZeaqB8CZPsrSR+74U1uLDzWisLgBf+g1m3I5VsvrsSRMB6J+HEuGOIYCkCn/eLv95l2LPbhg1ihM0iclfckTsIrBmi17c1JD2tUYsMHb1Rc08GrNOdv/IU8oe/uHmHi47mFbrJMxCsb1qPpuClciIqesLavZq6gK8MU/3yRp6mqOexWDlndH07HT9ilHeKzozlRGQ9uccfOACkB8ipr25AN7jjT5zDXAENLWEfE9xfI54435ASm7jr6Nju8CIZ3pJdpFltvFCSBzOyRTa+dBAJQloMnuijYa061KIS0EFOrw6tOv5yWBDF45hWZo93zRwhkR+EezwfdWzgyUVvi6w5g4SV/zvZzQ/CaE6nYOBS9We1RV00ysnWA8YvaDLGAaPRC9RaygBI9yJCVB+goavN0hBLWzHMUgsv1SM3EaTC8eftwcBqq7Fi/yUAB8FobeU65byBm7R4y1qRI3lO7OLtRc8cixFk3x7sqatj7YlDomIXkRPmWgcygOuHx mH3sg35X WyzA6jwYEjAOZjdySyNt/LyibrCf7N2svMVp0HrFWo/SX295QyDhiOBmQYI7V4qss85zJL/S8woEaN5KtuHQgkfL3L78Fbqo+6X25yYqzFlUvKNfGzGE62dCJ7apEYlUyPwrdoDL9mGVi+W8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 12:49:46PM -0700, Sidhartha Kumar wrote: > @@ -850,12 +847,9 @@ static inline loff_t folio_file_pos(struct folio *folio) > > /* > * Get the offset in PAGE_SIZE (even for hugetlb folios). > - * (TODO: hugetlb folios should have ->index in PAGE_SIZE) > */ > static inline pgoff_t folio_pgoff(struct folio *folio) > { > - if (unlikely(folio_test_hugetlb(folio))) > - return hugetlb_basepage_index(&folio->page); > return folio->index; > } > Unfortunately, you can't split the patches like this. If somebody's running a git bisect for an entirely different problem and lands on the boundary between these two patches, they'll have a non-functional kernel (at least if they're using hugetlbfs). So these two patches have to be combined. Maybe there's another way to split up the patches, but I don't immediately see it. Maybe after I read more of them.