From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E23C7EE29 for ; Fri, 9 Jun 2023 17:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CF5C6B0072; Fri, 9 Jun 2023 13:18:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6801B8E0003; Fri, 9 Jun 2023 13:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56DE88E0002; Fri, 9 Jun 2023 13:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D3736B0072 for ; Fri, 9 Jun 2023 13:18:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 291EBC035F for ; Fri, 9 Jun 2023 17:18:48 +0000 (UTC) X-FDA: 80883869136.14.60E4B9A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id B9C3940018 for ; Fri, 9 Jun 2023 17:18:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q4VE+vp9; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686331126; a=rsa-sha256; cv=none; b=A49W0jxY4xsf36qC0rGZGjx9E1781imGS9IAWuhgZNKff0gGM2ljDLVz+dfJqxXl0SB8z0 IprMeEjG3/S0XHlH1tOA15m/YL4gsj5nvP2N+KaZr0UAoNw197FARo9dcoVybzdWsT01oR qY9h+C8S8tirdA276HaNpjzSfZDd894= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q4VE+vp9; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686331126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=61PEQyEyFh/a5EC3ccv24KEyOK2K+luT3/KMWI7QFEY=; b=cpU1ZHVTt+TaMHva7Wip8AHLhIOBJGflXqfcbUFZM/95EvQRSdOu6EBV5m9ed0+9R8Rd80 HeauKJ14zgrSI1pr94miWd20haufW3ry4up/qsSuJVagNjcfEh7VzoRIuAyZFZTed4GZI/ kOA/l2877+E4aZuQozHqlD6gARP+Ds4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=61PEQyEyFh/a5EC3ccv24KEyOK2K+luT3/KMWI7QFEY=; b=Q4VE+vp9G/IbsNK847JEcED+ef xWL+lEiEcw3sxhZ9GKTxFTc2Zb7pGHkyvRB7p17c+PLAdha2q3jgdPyWuSmn+XY4zhN0azNN/X2Js Bzztd4bvKls4LcyQCokC9Th/5D6Fzd9qs/2fEwsVES3mgosmIaV8sSfLgTQHdhk9XlxeIvtSYFWCi DZvbNkdUOk8+byjrln4D4eTKMiRgg/qBQ+GSmPjHwMP3oW8NjQgsJ+HXEQMR57rkTOA+l4f2muWHk LZbwOkqDDsT8xbsArWDoFirq2T/ACediM/GaH6PbNIfYVvgVfyerFBLxLbE3BPmT6AalcygHtlggm Q4sYZoeQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q7fl1-00Gpjq-BV; Fri, 09 Jun 2023 17:18:39 +0000 Date: Fri, 9 Jun 2023 18:18:39 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill [add|del]_page_to_lru_list() Message-ID: References: <20230609013901.79250-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609013901.79250-1-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B9C3940018 X-Stat-Signature: smfehn19ww7cf4shoz35738w6wqqrsw8 X-HE-Tag: 1686331125-71577 X-HE-Meta: U2FsdGVkX184s7qEoi9LbfI8YAISjXVbsOZh+WvIZJ1to2S9/+wJSp81rBCAVBRzZ78+2OaEnr5vd99TcleXqhsacHaqdsf+QhbT4xbt4nMFh9Vb1AZl9OKnh9renAiAL+cBD0Wf7ljOKOOdFTYqnBv253DHlWfQOG/uzc30mpwl3VfQrS93Y9Fkluy/n+PM1CRYJfFQc5ihmS2fXFVx2+F3Ou/e8UdkfyFOolq3yoKQe0HemXdcm+mc9pdj2yKkwuRBf0qPfJb7mbfmDaaI31OnYQ3hSv+miZvyCqqlqeaT/xoUnCpx3i1Ndpsft6GFzZanc5+ALyRUjdpG039LRnUqFIvjE9ivvUq9Q1u8el1vbobLgcl5h/r13bsKz0La2LCqFpP0/iD+mxBIpY7r0Q8+1sJpB1gwzXq7MafxQb/K3Nru1GVXMfOkjVxXg9xVOZIixf9o+zZMIweBdZaA8gfyeDJzqqRYXg8AsI/sP3ciaN+9gPvAY31KXsayGDxS6th3EPme3JkrMHzP9mskCLf0pnekbmGwp3RY3qxEksspL7HvlN9AKoTZ8QTFhVhddQ7BqIEHbSTVcIN+EBECjICHnfSo1MY9FlrMk+gG8YqdK51DJdc2qKmXXFlc3ryXfk6GVqfZWezSI3tDb4/UkdQ5x5fNZsxeuauEIVtlG2nJsA95FrePFvRgnBEeoBjhD2/02CIiNjsU3QLuHpO1RDH3ouWIXntym67Zn/Q3wLCi3SSAzYiM7eHCcQW6UFrobTdkceO81xkFmcaxpVPuC7gP2LlBI/LPesd+omnfUZo+D9roryq8Bv1GzR/vFRhLZXTSwwWsgQGJZnmDZapwr2eBeNjs+hCU3a3+gSsy1OK8rqYQ2pgrrhDfQ+Olk/XqkexxU23bgfkTDCnAOFvDv0b+8++PQw6pyWCH+++P/BNBNhsHcZIMyWgQRrmWik6jfq3448JUwKe442n65SJ 4DLvouVt rfsnjpbvb0v9UfzxaXc13j/hNaSlXnM+S7XrCgbp6uSw4sm4fMVmTIE4msf6DZqRR5Bs8sUuylQJCWC0wPCABRjxzojBKhp4WMlAGToApikdles8q+DfmybP6/V78RXXkxvGzhPPzYctoZvl5Fqss/ioQIWI36iRSMp2AntRoifAcPWBGBJWDyReWgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000961, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 09:39:01AM +0800, Kefeng Wang wrote: > Directly call lruvec_del_folio(), and drop unused page interfaces. Convert isolate_migratepages_block() to actually use folios and then we can kill the interfaces. > +++ b/mm/compaction.c > @@ -1145,7 +1145,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > low_pfn += compound_nr(page) - 1; > > /* Successfully isolated */ > - del_page_from_lru_list(page, lruvec); > + lruvec_del_folio(lruvec, page_folio(page)); This kind of thing is not encouraged. It's just churn and gets in the way of actual conversions.