From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E2EEC7EE37 for ; Fri, 9 Jun 2023 10:07:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2CFE8E0002; Fri, 9 Jun 2023 06:07:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DDC48E0001; Fri, 9 Jun 2023 06:07:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A4AB8E0002; Fri, 9 Jun 2023 06:07:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7B2898E0001 for ; Fri, 9 Jun 2023 06:07:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A3D71A01B7 for ; Fri, 9 Jun 2023 10:07:19 +0000 (UTC) X-FDA: 80882781798.26.D63B7D4 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf04.hostedemail.com (Postfix) with ESMTP id 532E140003 for ; Fri, 9 Jun 2023 10:07:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=G8k8tP1d; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686305236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZsXlyZxQYx0ra+Pn6hnVbja5cmTXlxt076zWMBWb7Bg=; b=p//aiv4DmmxlBbBeVeUXceYhlPiMitXkw/Gva41xcChHe+XfvvG3rCgnyd2+tIKw4IYoFP 0NB3GyB48pPCPJd8ibocQK6FOw5MGlbMdv4o1gdJs26EHv2xCpvZAl1FxaejbyE24OKYUe LKzvCPInPBp1uA9C7d2cNjNu8GtVEf4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=G8k8tP1d; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686305236; a=rsa-sha256; cv=none; b=ru9gKvFpgL6MPiVjE7vVfcTUbHM8MTWCJqO0AdOfPTBH4wheu3nqhxAEL16IK3KPhSbi1I L/ZEn6K7IYQt8O1M35hT9YSbv9/Aj8DhV/IQGc2ofFh+A0YZoRuWDz7Fy+0IvUgNzX739U S+RpE62la/BFS6v4itxWYueAWphNIdU= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2b1adf27823so17347001fa.2 for ; Fri, 09 Jun 2023 03:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686305234; x=1688897234; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ZsXlyZxQYx0ra+Pn6hnVbja5cmTXlxt076zWMBWb7Bg=; b=G8k8tP1defmJv6D0Ppt6lXhRm2WLO5Y6XIYQjgDlD9s8jq4XOOd9+W4DDvzAqXzJMH sR86W0eERAjU+F1zYFVVyHJPTuvnvGJcXFgHMmC+IC9XoHOcLf8uiBYM4c1oy6GDLGBA 5G6WLctxMP2gQja2xn0gr7og+/QMemap3kmcrEcOPR0Xdle4TCtP+WLUNbfyAIVMbjxJ xSgfNsCxedAw5vrNbYlcmWoGafcrit//kqQnYnbJomqL+C8zSrvpgDg8W/lHRIzKpVHy VD2TfznkgEeddSxfult2qtxd7A1EZGv8cgYfmdoNDRCpFR3RxwCAIaw4/h9oI/fOus0o vX+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686305234; x=1688897234; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZsXlyZxQYx0ra+Pn6hnVbja5cmTXlxt076zWMBWb7Bg=; b=E9wYXPBnfkVKoeYoeRGWTRYyMi++N8QWsa00L+mjv3Po0vfhkvlA6peI6MKBXm1L6b bSTM0WszqdSMEUcdDkDc2tjSeoRLtFEfUvAKw1waVcQ/+36isrr6tPpc+SY+QibZJMV+ V0obvZHOd7n++siGgD4F8ivy7nvccq7cIWf3dBg3gXWFHh3zIlC7zadBzUiOYgLzSbS/ dDdpHzfHMX4Rb7IirWKAlmp2QpmjGeRQbtELe6zCn78q2IdxjS3sWSB4boHr8YWN0ZpE 2p2iQuAIQIGOPFS6LjcDwFLLAeCHa0bgaj/sMQVCl+0Usqam22z2GyHaTyr3AwlRZGHt vwwg== X-Gm-Message-State: AC+VfDx9IH/3bAygg8lmMcG1ucoHn+SVNldTIvPqsOc4VZAdaQ2byCm5 38oulaLqtETeeDrEmQiS2OA= X-Google-Smtp-Source: ACHHUZ49mbAXgGnaMDByCCCngrCB+EBS57uYdTSfOC2GVbS+t7KmqU4drp6GD6yHmjlqIZp4F21hvw== X-Received: by 2002:a2e:3314:0:b0:2af:2231:94ba with SMTP id d20-20020a2e3314000000b002af223194bamr856221ljc.3.1686305234077; Fri, 09 Jun 2023 03:07:14 -0700 (PDT) Received: from pc636 (host-90-233-211-151.mobileonline.telia.com. [90.233.211.151]) by smtp.gmail.com with ESMTPSA id z4-20020a2e9b84000000b002a929484fa0sm320230lji.68.2023.06.09.03.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 03:07:13 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 9 Jun 2023 12:07:09 +0200 To: Lu Hongfei Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , "open list:VMALLOC" , open list , opensource.kernel@vivo.com Subject: Re: [PATCH v2] mm/vmalloc: Replace the ternary conditional operator with min() Message-ID: References: <20230609092602.26412-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609092602.26412-1-luhongfei@vivo.com> X-Rspamd-Queue-Id: 532E140003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: i6mwb6gmyt8wc4s9p6zprs3xndjdwgfj X-HE-Tag: 1686305236-640362 X-HE-Meta: U2FsdGVkX18YJg9cypqEsQMSIZxJf3iowzKl2AVtGAT91JQqOvpBpVpTKmMjICOp35auVGFSP/lU+TkZguMMot7wAQVJYjqAS5JP6mGzdi/I2eIfl0hHMTAFw8zI09oucdsHvEy/lo8SjZLRwsLY4C3ArZk9puR+WQsKLo9A4Ju4mGMtQUmEfwfGrrMsEU4rWInAFDssfmEli6zDcGfVJAYxgKK+354al2Wwvxa1rXki8yXmiF1QCKLvW4SQzBkZRYt4tgBT5PgmVEonFu9zZVxd5f0tkrjZIiJNGL05laZ96wyFE/vloipkNy8SY0D7Lzc3o3ilmxJ7xWeSSWiXi1xnaBmMnw7YJlYPF3uDsrSuNCBKR4XLXsKsWCxq1Ki4YXZkIz+0U52EJdCmcqYNOeEatO59GpsAxoxpcx6YDi/IZxW4ZoWFGh+DOdmjqPeAj4s/fUuE+DEFMt+PZsGakFi6bI7auF1FIPvTEedixVr/variCZqc8CiZveCb29iOG3haC6ADa99N2CdNT8pNV5YXQtjsCiClUKx+Wqr2/m4ZH9l1nzihPbYXq2lna1fU3G+ifEzjjiXsflEyGqArzECPBTzDt1hZYFoB8ccSaJNE5s3uBzT2F6CBItk9ffjpvj5SXoeuyZoU4XJ0nWWZM2Weq96TJ7dSULDbEeRXHebMGErEeKx6pK3cZOtaY6vhPjwBkzFRxH0nu7PGWlzWz9RSVR0/V5I8VF3DVdN7pT4QWgR5nuAQ0NZhrtPOAYGRYDZSSlSH1riBq00z3703y59RZpK58l/m9V3s8Csjcod677+jvzd2+sv6oPQuV14HUFNiJPmldBty8gFr2pbAfsy0RsCbdrWLBAayAerSzTC7EB5GL6t2PXRzH72M1UhNWFnfkEXqeljRbPU7vQGAj+sQdAGd4EGFVk+X2FSi+wI3JpMfVUXtPIZCvQdsqhHxoZiPK9/qFmQyiEEPBkd 8oij5s4+ LIHGL0u7mQDZeY6AACenZyHxVUk3rcex3vEZ0NIzVwjXerSQnf22HR31mBVLmSvGogEJElStncOYYR/4W8tEy8r6J3xK9uHt6ei96R/11t4D7XnoIUS3oJo4EFW1xUQtpmGDS2lk+H2cik8iV0wuoH5xyIjVo8YzGyP3XTKUQVvzayPfmwkr8FicXDMpGC/z/dbtV8vsWNGstq+8+3AtKy1cj0ng3jisLSKKEEPMxDUcmB5KCaIlrkffBMkuUjgjx9upfXroNFVF7YcMytzcg485vI5RsGYipTxAmdEjBRqF73GPkRHJvFCWkwevcRVWfI7atb+AUi38ATySd213PyurDWR1ghF+C5WKdsHFT1fCdCp8qD1q0/ULM9x2PD5qHDUTkAwzmel4Fly0ekaMF1bzTAgP7mqwdctfqxaditCVXCL5IXA87rpktWSuhMl31O3yN04v9ZcWDUvkP/tbnDJzZzEYZNDSX5i0X6j4UQqlRV43UNm/+RLtxrQmN/MzrSQeP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > It would be better to replace the traditional ternary conditional > operator with min() in zero_iter > > Signed-off-by: Lu Hongfei > Reviewed-by: Lorenzo Stoakes > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 29077d61ff81..6125ed506895 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count) > while (remains > 0) { > size_t num, copied; > > - num = remains < PAGE_SIZE ? remains : PAGE_SIZE; > + num = min_t(size_t, remains, PAGE_SIZE); > copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter); > remains -= copied; > > -- > 2.39.0 > I saw a complain from the robot. Indeed the min_t() variant is better: Reviewed-by: Uladzislau Rezki (Sony)