From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55C6C7EE23 for ; Thu, 8 Jun 2023 09:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D46F18E0001; Thu, 8 Jun 2023 05:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF6D76B0074; Thu, 8 Jun 2023 05:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBE7F8E0001; Thu, 8 Jun 2023 05:18:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A99FC6B0072 for ; Thu, 8 Jun 2023 05:18:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7BDF01C73EA for ; Thu, 8 Jun 2023 09:18:06 +0000 (UTC) X-FDA: 80879028972.04.2F5BD1F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 8498B120015 for ; Thu, 8 Jun 2023 09:18:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WE72ZnGf; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686215884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sq4jU/k60jCVqjA4NKdWPht6bOFZJdg9eSAA9JH9D08=; b=6uZUUDSDS/L7E7C4otnpl5kdXeMDjSJgxfa6c9Wu5IIvCBSZyOcQFdGl2M6tpgglnnkFZ8 YtG7zkB2G4VacSIbfm2Z5LZkB3KccqkCQjSMwc6SESVfIvcIRXmUgyBzVOPNKHP02Fmg98 8DM34dkReHj2TOx4IUnh2LZgEouu0jI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=WE72ZnGf; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686215884; a=rsa-sha256; cv=none; b=K434WmBfzo6/KV1t7BtHBqQMf574VeJ3ZDg6JPF0wAxiqhVZz/WWKK7iNMn1jz+Aa5dNpM 0UIDZRyqra22myKrH7WK4TNqYKAyZUtCmcO5YI69ljv1T4WzK1EhUWzZkdASomCWAOT4Fi IrwaYMD17M6/sWlDZl7Swph18LJbhYs= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DE61921A16; Thu, 8 Jun 2023 09:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686215882; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sq4jU/k60jCVqjA4NKdWPht6bOFZJdg9eSAA9JH9D08=; b=WE72ZnGf7+kpC2HvEMTxu2ZJfE7PGl7iLN4T4mqtpy+KHCCrXMLvisvtuPdYf7zDGFcO+r yj4BAm5v/9BdILYpN00MAHS+gAgLe6dh86XxAFFelzaXFUxFB6LMzonmAiWNAHtkLAboKY XqfMsvEyrFmHTHE6wYUsE46lnKk5pKI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C323113480; Thu, 8 Jun 2023 09:18:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yuNTLcqcgWTRaQAAMHmgww (envelope-from ); Thu, 08 Jun 2023 09:18:02 +0000 Date: Thu, 8 Jun 2023 11:18:02 +0200 From: Michal Hocko To: Haifeng Xu Cc: David Hildenbrand , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone Message-ID: References: <20230607090734.1259-1-haifeng.xu@shopee.com> <34f32148-24c3-09a3-8bec-9515139e15b1@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34f32148-24c3-09a3-8bec-9515139e15b1@shopee.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8498B120015 X-Stat-Signature: hjw4z1r9pxxi9447y7hmzf4aaw8rxcpj X-HE-Tag: 1686215884-34027 X-HE-Meta: U2FsdGVkX1+iE35vIjHhYjdCiWE3aO6re+9Rhth+lySlqNScdTqIF4G8wp7zA4GjPRq7VEm+HnHYdqTpEGbSrz/IY0gfvEUmfxSCpmGp2KYh6JOUrIE35rFvnIHpuTcOC8nxMch04vvt/fOhiCPs0J1d3PecSKdgDzKvD97G3EsL4TVGyUjSeI0tZlUThukSpQ3MbGzX+TVx5kBKqFqQBR1QdE92dYTKgrz8MdL1y8bwgu1Hlpm0VU/ho9PIL/ni2db2fASysdtfEUPHvOV34kxWmBh9KjQCaP/y2jAdqYdMXo8HHOfhQdfazS23ZlPQgYFgcLpx56EZ//AN4cmE3fwHIEZFxkKIGd10sCgRMoHHmvzDD8PZ87s0e4XuDeV8tlWQTeah4iCXSLWxXSQ8TsGyuz7AZP+Q6d+HuG+gRgFga1ZXCjj6IwEoBgbai4JNRZ+hRse9U/4iXeYkkNIh+WY2ePV5FQwTPuXzrW2uTHyvdTgvEh6itlIQMAcI8Xpe4iVnRMFpk7NV4BA8SgJBmk0fR57wK1NXGihJDr9Rp+tCj845HoIVVw2Ow+WZ4qr22UfZH6HZgN+zY1NutS1SUa+ab9dODPUJLPVg3QnbScGKhJJIGMTB+KVpP3Ejh0jkrdVPvMQgJ3pNnIbZAxOlXgK25l9kkaLAw4p6dpLhT5BZIlZuuqkYKy7mHJLEZ5NHxiIjv/ZPrhGsY6Uc/lddYGv/UmkMyqiVpX2tSckeR0flyliqhslzWblCUfK8BaJnt/QKuWGzvzujH0wzL182rjUKlVcIpBxL5PuOhCRFwJQgD/1CIxjK6qpp/2+byTKG0WhJ82mYnmoYi9qjjqY9LNhvv9AK5CLpX6BkB9SxW439xqfBpTTYZA1jaop0F4zj+ifaIPYnyAzYyezT9o6Xf7U/5Q8OjrlUoe0X7NMSqw4gRhcNrkxgz9TQcEaRkAyrpSy7AMg/bN06SzoVn+I mI6B0Jj0 rPVzayg3oy81yw6LflGz7uRJNg/8tcnR/hru3HSQtUgE/FZdHimLQ6a3sZSIFgWI/LzmE+iijHv3DUlXaDff/RtDkx2UYbnD1RHMERe882biq6sUCaq4Fpl9Q4RRq8e956YQzYA83iI1ARqTnq2Zi6BkYzcyK+hhk17qJy2lyNR6d7DjUg3BaGEsGgv//heRnV5xXXp1ojjRpYEAcvFOP00ml4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 08-06-23 15:38:48, Haifeng Xu wrote: > > > On 2023/6/7 18:22, David Hildenbrand wrote: > > On 07.06.23 12:16, Michal Hocko wrote: > >> On Wed 07-06-23 09:07:34, Haifeng Xu wrote: > >>> If freesize is less than dma_reserve, print warning message to report > >>> this case. > >> > >> Why? > > > > I'd like to second that question, and add > > > > a) Did you run into that scenario? > > b) What can an admin do in that case with that error messages? > > In theory，dma_reserve shouldn't exceed freesize, so the error messages can remind us > to verify whether the configuration of reserved memory is correct. I am not really convinced this is worth touching the code TBH. -- Michal Hocko SUSE Labs