From: Michal Hocko <mhocko@suse.com>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: David Hildenbrand <david@redhat.com>,
rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone
Date: Thu, 8 Jun 2023 11:18:02 +0200 [thread overview]
Message-ID: <ZIGcyku+DN5IHtwp@dhcp22.suse.cz> (raw)
In-Reply-To: <34f32148-24c3-09a3-8bec-9515139e15b1@shopee.com>
On Thu 08-06-23 15:38:48, Haifeng Xu wrote:
>
>
> On 2023/6/7 18:22, David Hildenbrand wrote:
> > On 07.06.23 12:16, Michal Hocko wrote:
> >> On Wed 07-06-23 09:07:34, Haifeng Xu wrote:
> >>> If freesize is less than dma_reserve, print warning message to report
> >>> this case.
> >>
> >> Why?
> >
> > I'd like to second that question, and add
> >
> > a) Did you run into that scenario?
> > b) What can an admin do in that case with that error messages?
>
> In theory，dma_reserve shouldn't exceed freesize, so the error messages can remind us
> to verify whether the configuration of reserved memory is correct.
I am not really convinced this is worth touching the code TBH.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-06-08 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 9:07 Haifeng Xu
2023-06-07 10:16 ` Michal Hocko
2023-06-07 10:22 ` David Hildenbrand
2023-06-08 3:43 ` Haifeng Xu
2023-06-08 7:38 ` Haifeng Xu
2023-06-08 9:18 ` Michal Hocko [this message]
2023-06-08 10:13 ` Mike Rapoport
2023-06-08 10:51 ` Haifeng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIGcyku+DN5IHtwp@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=haifeng.xu@shopee.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox