From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EA9C7EE2F for ; Wed, 7 Jun 2023 16:21:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9D9E8E0001; Wed, 7 Jun 2023 12:21:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4E6E6B0074; Wed, 7 Jun 2023 12:21:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D16038E0001; Wed, 7 Jun 2023 12:21:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C0E196B0072 for ; Wed, 7 Jun 2023 12:21:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8071A1403A3 for ; Wed, 7 Jun 2023 16:21:44 +0000 (UTC) X-FDA: 80876467728.19.4995E6C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 5C01D40021 for ; Wed, 7 Jun 2023 16:21:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GN8qXRGp; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686154902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mHrnG9R4s+c+iNcyk6zQ7fxgQTkZTZ0gNQsPom+d5G0=; b=pKnUgVwuHbAFEzzALG4QrC5J5Z681SJuGmZ8d8bzX4Zgb3OyhROABeleQxl86b8KZ6QKTa NRg+MSdcwcQjoqix54nr7ckaCYxIyfW2bb7nlt6PM9H8BreaT4CLH8GlPkOxMYZ3ETuzaH Ogsmtw0KwgbgMX8uBLc7g4UbLnWfFE4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686154902; a=rsa-sha256; cv=none; b=HjAdohxTZm0AsSlqSQt/EIRqES1jt0CyfS3zEhmO5cs9nqz8uws8AUBpViwWK7XYrbn0fe LahkXj+PsMLqNMwATqDAzMntqNme3oWiDEhPEGQga7P9j9rwz2jAywCA31uiN5dt2Ux8N1 0KKCvsPuWsmxx6OBlPivuWWAPYms01I= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GN8qXRGp; spf=pass (imf11.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686154901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mHrnG9R4s+c+iNcyk6zQ7fxgQTkZTZ0gNQsPom+d5G0=; b=GN8qXRGplb9MFbyS42wI4/EAFFNJMRckbKEmkS+7+Lw+bGZ0jLknXKNyvK395zpj179+fy /X51cNV3XJ6FWgivtQWc/Qw7iVktlYo9K7XGy1YcvAnBMsWnMgBHK32MCvjpOaS95smpIv ynj0p/qErUSdopClruYHvTZMDMbdLII= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-LacE30u5N3ifwORdofxSdg-1; Wed, 07 Jun 2023 12:21:40 -0400 X-MC-Unique: LacE30u5N3ifwORdofxSdg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75ec325d255so47047985a.0 for ; Wed, 07 Jun 2023 09:21:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686154900; x=1688746900; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mHrnG9R4s+c+iNcyk6zQ7fxgQTkZTZ0gNQsPom+d5G0=; b=R9Fh3LYEVKklvh3jjP4rgjuECf24GLx1LAVV5+Q4r2JKmped15/v0AvxO+W30b9PBZ EPB9zvr2mH/V6KtTnmj/F8yIJNfeVuLTOT9FwAnZ/fdjM5PysRUta3sQrgpmxzVQBGwj JBHP8+HOSdH+mkO6oUCDLFu4ZIRU/iKGmnzwSXQjUddfBkcU8oGGOMEINo7/bkzw4vCa B/NzFXIvENMkqUo8l0CK5v80b7PudTdmOxtTmVlRoX5cE6CLEnqHeSJxySl5JOusuV6C SVYjM2hfBcKpIqbKLBT40L+wDAbL06yxAMKjQpdrJzRhZY/mNL0kYQ5Asrn8eFgiISeE xzQQ== X-Gm-Message-State: AC+VfDxbt9iKYsAIyTCrLjhrDF1O+ifD7RjAp612KLNkkwFU2aGN8XoY Z07uguyHvuD6DnXA1/wkOnt247pAbTVaT/b4n8l1h7MakoHfMpXl3i+17I9iiC05hTW1jVQf84q HiNz406lFBtE= X-Received: by 2002:a05:6214:300e:b0:61b:2111:c2e2 with SMTP id ke14-20020a056214300e00b0061b2111c2e2mr6663398qvb.2.1686154899898; Wed, 07 Jun 2023 09:21:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/yoyuPYJ0hyJgINcPPC5ifERAaVNoHqfAgbxEJrcaY9uJmpbkD79W2qQpl/pg/cbL/CEUGQ== X-Received: by 2002:a05:6214:300e:b0:61b:2111:c2e2 with SMTP id ke14-20020a056214300e00b0061b2111c2e2mr6663374qvb.2.1686154899613; Wed, 07 Jun 2023 09:21:39 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id da10-20020a05621408ca00b006238b6bd191sm6148082qvb.145.2023.06.07.09.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 09:21:39 -0700 (PDT) Date: Wed, 7 Jun 2023 12:21:37 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alistair Popple , Andrew Morton , Andrea Arcangeli , "Kirill A . Shutemov" , Johannes Weiner , John Hubbard , Naoya Horiguchi , Muhammad Usama Anjum , Hugh Dickins , Mike Rapoport Subject: Re: [PATCH 0/4] mm: Fix pmd_trans_unstable() call sites on retry Message-ID: References: <20230602230552.350731-1-peterx@redhat.com> <97b5657d-e09d-b3a9-c09d-eaff9fb7929d@redhat.com> MIME-Version: 1.0 In-Reply-To: <97b5657d-e09d-b3a9-c09d-eaff9fb7929d@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 5C01D40021 X-Rspam-User: X-Stat-Signature: gi4oamj5ajaxgdh79mrenp6j9e7g8bmj X-Rspamd-Server: rspam03 X-HE-Tag: 1686154902-196911 X-HE-Meta: U2FsdGVkX1/hg79M9J9CYf/yYeM5PZldGigd6T5z7QSd0sr8vw3ufQiQr9BeP1oqi4B1cwOBLnd5UT81qOPMFinMxd5W0zK33isYmW05MWglwE2gHRZ6UPVjE/opG+GUiTFa8Lu0VXo9mMk2aTvmPSEO0uXSrfST5JQmz0D0c6Iru1PeTaRS2vUvnJaRNTofRE13N+WEW8nhe+igIn2KIXtZMB5+Zramc7VR0/Opoo/O29kFfXvlKzUXBykI+yxgBbR/FE61ItAYUbDS1R6y8b8cyyzl2RAvcShiOr9MXcGWEXYYvFUGaJQnB/jI2IwTrio555fn2eUjv044Pyq+eo23X8PsiX4aX+aUH4zLuecU94XwMHI2g6UJ6xbnUITrYy/cyWaSLLaH4nzh+yhcMh8kS4lje8lCtN6y7TYI71y8eZS/pPl5WiZKs7OSD4Dtaoob9f8dNeKcRsfk4FQicnbYBh5cMQarRQGHxAh27drOn2KN8b5RAqqS8608ER3/vcUKo6kTzbtajCy3tnH7BgwiOK0srqmgziH6s3NEPzrS5BHCbUEtstvmDossznlRUICdwPJN7G1gv/kBJdDc04kMUv0MoBRTr6dsLjPSXsRdvFutKG5NPFZCZ7rRN35UHVGI0HzG2j7duIbRHBssiTnZ2ldJiOxy8Sf0D97dZUQIjGG7kTkG8j46L1g5rS3v2Qd/538oul8ZDS/e8RJhEGy8PcCb+ou0pJRlsQpQ3+j2jQVUTQGc7/UgnNu+T5MgMV5Wr1WOpiSIwCqPCJq/ahEvkF40KRyRz9/5If9X7s63/ik2mwPik+tQ+Cm3JkEd5FpWBXJ6xS5O/SsH+eFgBZnE7cVTT+owonGyLY1BDSYIkbE01uxLqJQNrMizlJNOn6YJkMz+Aj9HQiaWsPSpEnvoA8G0m+DkkVOXEI4msrytT26SIgE7yVpppoIiScXIqbIiTBQGz+BZODv1r7S AZTzpZuZ VZ+1F/AdNaOZE1TGI3X2qLD2f0uZOtzZ/PNk8Tupr9Mcj8QlbXyMUUthVLd6azXgIY57Zx4T4edTNzuMD6wE18ti/TRJssFqtEbhWuDKgfqAcFR//U02ZJPQKVQO9W+SqTdztavaau3K5BJRWO/2Jssr4l1U+EhVCukA/YOR5RMs4qcX2XPvTelCIPQPZNVd67lbR97WFp2ZSgWurBSetMTsNJK8HkZl4Tn7KwBl0FiA1om90FkSrAXnU77S1/sgUQjEZ2MVGtlcOmb78vC9ZCZ2l5hFdYAN8A0WCH1i8DQv6oN/0/u8NuMEvzRQMJ2jeL46ZZ2y7T8TK/pgV0oUrDRnQc5c5nHXuGW3JL13eJDTPX9emPy4sGLrBlSu4PKOImXhlGTrkM4AKHpOZ6RzTiWK/AxbW3qU4Umzd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 07, 2023 at 05:45:28PM +0200, David Hildenbrand wrote: > On 07.06.23 15:49, Peter Xu wrote: > > On Fri, Jun 02, 2023 at 07:05:48PM -0400, Peter Xu wrote: > > > Please have a look, thanks. > > > > Hello, all, > > > > This one seems to have more or less conflict with Hugh's rework on pmd > > collapse. Please hold off review or merging until I prepare another one > > (probably based on Hugh's, after I have a closer read). > > > > Sorry for the noise. > > > > [did not have time to look yet] > > Are there any fixes buried in there that we'd like to have in earlier? I > skimmed over the patches and all read like "cleanup" + "consistency", > correct? There are bug fixes when unluckily hitting unstable pmd I think, these ones worth mentioning: - pagemap can be broken, causing read to be shifted over to the next (wrong data read) - memcg wrong accounting, e.g., moving one task from memcg1 to memcg2, we can skip an unstable pmd while it could quickly contain something that can belong to memcg1, I think. This one needs some eyes from memcg developers. I don't rush on having them because these are all theoretical and no bug report I saw, no reproducer I wrote, only observed by my eyes. At least the pagemap issue should have been there for 10+ years without being noticed even if rightfully spot this time. Meanwhile this seems to have conflict with Hugh's series which should have been posted earlier - I still need to check on how that will affect this series, but not yet. Said that, let me know if any of you hit any (potential) issue with above or think that we should to move this in earlier. Thanks, -- Peter Xu