linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: David Rientjes <rientjes@google.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	James Houghton <jthoughton@google.com>,
	Naoya Horiguchi <naoya.horiguchi@nec.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	lsf-pc@lists.linux-foundation.org, linux-mm@kvack.org,
	Peter Xu <peterx@redhat.com>, Michal Hocko <mhocko@suse.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Jiaqi Yan <jiaqiyan@google.com>
Subject: Re: [LSF/MM/BPF TOPIC] HGM for hugetlbfs
Date: Wed, 7 Jun 2023 15:40:11 +0100	[thread overview]
Message-ID: <ZICWyy0TfSrUbW1n@casper.infradead.org> (raw)
In-Reply-To: <7c42a738-d082-3338-dfb5-fd28f75edc58@redhat.com>

On Wed, Jun 07, 2023 at 09:38:35AM +0200, David Hildenbrand wrote:
> I don't want to get too involved in this discussion (busy), but I absolutely
> agree on the points that were raised at LSF/MM that
> 
> (A) hugetlb is complicated and very special (many things not integrated with
> core-mm, so we need special-casing all over the place). [example: what is a
> pte?]

This is somethign that absolutely does need to get fixed.  It's one of
the big sources of complexity and confusion around code that is supposed
to work with both hugetlb & THP.  I understand why hugetlb originally
said "everything is a pte", but THP went a different route, and I think
hugetlb now needs to follow.

Fixing pagewalk.h to not be complete garbage would be a good start.
I can elaborate more along these lines if someone's actually going to
put in the work to do it.

> (B) We added a bunch of complexity in the past that some people considered
> very important (and it was not feature frozen, right? ;) ). Looking back, we
> might just not have done some of that, or done it differently/cleaner --
> better integrated in the core. (PMD sharing, MAP_PRIVATE, a reservation
> mechanism that still requires preallocation because it fails with NUMA/fork,
> ...)

It'd be nice if people engaged seriously with the efforts to move that
functionality into the core.  eg mshare.  Saying "Oh just share the
hugetlb implementation" is not serious engagement, it's an indication
you haven't been paying attention to what the needs are.

I haven't looked at the hugetlb reservation mechanism in enough detail to
be able to understand why people use it, what they actually want, and how
it could be done better in the core.  Maybe somebody else could do that.


      parent reply	other threads:[~2023-06-07 14:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 19:19 Mike Kravetz
2023-03-14 15:37 ` James Houghton
2023-04-12  1:44   ` David Rientjes
2023-05-24 20:26 ` James Houghton
2023-05-26  3:00   ` David Rientjes
     [not found]     ` <20230602172723.GA3941@monkey>
2023-06-06 22:40       ` David Rientjes
2023-06-07  7:38         ` David Hildenbrand
2023-06-07  7:51           ` Yosry Ahmed
2023-06-07  8:13             ` David Hildenbrand
2023-06-07 22:06               ` Mike Kravetz
2023-06-08  0:02                 ` David Rientjes
2023-06-08  6:34                   ` David Hildenbrand
2023-06-08 18:50                     ` Yang Shi
2023-06-08 21:23                       ` Mike Kravetz
2023-06-09  1:57                         ` Zi Yan
2023-06-09 15:17                           ` Pasha Tatashin
2023-06-09 19:04                             ` Ankur Arora
2023-06-09 19:57                           ` Matthew Wilcox
2023-06-08 20:10                     ` Matthew Wilcox
2023-06-09  2:59                       ` David Rientjes
2023-06-13 14:59                       ` Jason Gunthorpe
2023-06-13 15:15                         ` David Hildenbrand
2023-06-13 15:45                           ` Peter Xu
2023-06-08 21:54                 ` [Lsf-pc] " Dan Williams
2023-06-08 22:35                   ` Mike Kravetz
2023-06-09  3:36                     ` Dan Williams
2023-06-09 20:20                       ` James Houghton
2023-06-13 15:17                         ` Jason Gunthorpe
2023-06-07 14:40           ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZICWyy0TfSrUbW1n@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=axelrasmussen@google.com \
    --cc=david@redhat.com \
    --cc=jiaqiyan@google.com \
    --cc=jthoughton@google.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@nec.com \
    --cc=peterx@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox