From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F72C7EE25 for ; Wed, 7 Jun 2023 14:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076636B0071; Wed, 7 Jun 2023 10:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026558E0002; Wed, 7 Jun 2023 10:10:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57238E0001; Wed, 7 Jun 2023 10:10:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D6EFE6B0071 for ; Wed, 7 Jun 2023 10:10:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A4D7AEB86 for ; Wed, 7 Jun 2023 14:10:25 +0000 (UTC) X-FDA: 80876136810.13.34AEBAC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 7852D4001F for ; Wed, 7 Jun 2023 14:10:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=upW37M0Y; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+e57f13fd7911cf5fc1b0+7227+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e57f13fd7911cf5fc1b0+7227+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686147022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eo410/mvVPKIDvL65SAibhxBxSngpZMHxmIM5A6ESGs=; b=ET2w7OKUOZO4tww0iS27nIakY/npXQ5DkAMCzGWDUYjFiD4n9FOhRM8gvvWRM2UYzge3jS 48YCu3Yui6Q0P8e9nopMyftHQ2ZxgNGjpLfw0c6NMWZ6CbCTyPCkzP6to7k3At2VF8Kqec 7mt81fPb5Ad9sm2BHjnLmJX1cda8fbc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=upW37M0Y; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+e57f13fd7911cf5fc1b0+7227+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e57f13fd7911cf5fc1b0+7227+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686147022; a=rsa-sha256; cv=none; b=WoY/AQFBATNXNd5UzdvbwjC76mb1AVfn2i5bNRiFWbc+M/sdRRcBJAWx8GNNHnAtWiGYQe XZM0e/uo+fXKbJDqGG2ph5V0LKSjo+w70J7k3TuXDaxPsDCz6l4SsYUhpDGyHqAlGm1upy 9+2wnGD7rgejUa9PgzIW39yf/+gZ1wg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=Eo410/mvVPKIDvL65SAibhxBxSngpZMHxmIM5A6ESGs=; b=upW37M0YmfRVSPlDuO8CFVotIn Z4AGgoHeL5plEiHj6ShVSCIvOzV2JPcwdG3VOtqwgF4TGg3Dal6vOGvJXbQmFsJ2BjTlURdjAj6O3 fZseSWZ5uMKFeeSGelXQMndDUnE+WiesPQGM7tvDndeyCRD5rqtTcKZjEpcCJL/JNDTJjPh+OYOtw 0zzJ2CHq7AdUJrJ6xVuLZuRqeRXb7sKo3iUSlwv8ZjL5w3IYQlm2aIzfcIcM3HBfZG54fWcrZDaA4 NHwyNkb+OcMAQgZhw1t2uYcQ6odJkJK27AZGLDhN0jZH13HqtmnbCaL9AXldk7/v7n4Vo7DlooGL5 NrBGNkVQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q6trb-006D93-1v; Wed, 07 Jun 2023 14:10:15 +0000 Date: Wed, 7 Jun 2023 07:10:15 -0700 From: Christoph Hellwig To: mpenttil@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alistair Popple , John Hubbard , Ralph Campbell , "Huang, Ying" Subject: Re: [PATCH v3] mm/migrate_device: Try to handle swapcache pages Message-ID: References: <20230606050149.25699-1-mpenttil@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230606050149.25699-1-mpenttil@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: u4znjz4n65o3dctuxxxmkzqncr7fj6qn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7852D4001F X-HE-Tag: 1686147022-86494 X-HE-Meta: U2FsdGVkX1/mtvZsGPWuipbvOxrYeuXmp7tkMrVTawg3uf5pBE1SWnYMHCf9rgf5mOteyW6VyrvnJTuJbDNEhBd526Gky1xn2Rp0P00js44e+ydbledcxLDFhW2rSE22ve0ZFAc+dh2DjWpT2ZxoR9SZpADEnGXfsNOeFOgEZ1lTR1WlExzYvlYR6pIgm8jNB0Hg/2cvj7K+2fyFyyVan7kdU0bn4Jn41+f0F4HydqC9ioGrUsRamWt4TO4y/cKNGVKuKgtlULMlDyFLdO9+Y84nwjZc48YC9znXxWjM/QFKHgoYuOOkDHvQnD/pI4OJ7Vhgn0YUCwUKRLYQMsVErMq5h4eEwKIV6i5WRZPnQsQJD8yOJ8IBqZu8iGHHe3MZ9jC0WVqjx9DlCum6ZSWmcRUcjPp568W2G+kgiBZjy9pTnJrWxNk7d/W72CBLwLip2ZcQ70Vg3NfUhaAtw/G0DEasZjNpzx0iADmnjRN2GosbA5kf84qLdxHmBpUTW75Ei4dT44DtXXZycYphwO5veLOlgU4rkjMcyRkeqWG54UCSGhG2r4gpcI0OBDdikpqtTaO7IjPbiOF9Dg9uAFmxcif2u51S3dRCDK+OiTNnR53VOXGtBs72puJyvLYjMYB8hLlNEMBc19JLSssq8OMLS7ZSU7D/5DbjotYcKnso2aOaqUCl5fIuWpjZOl4WvsUY3cTDXauTw/XEgkBXXhrb+w0tK0B2s3yXmgPhl02v7eosBODTCqnIRR/+kk6fCuY9a5l1kOnjOm9kEIiChkCRTqu0uUBY4+pWuYV7R4olh3opdby1JpHjav07fZaaF4kecfQ6EHEjjM7vg2jFwaAggt62gi0HgQdTbEHyXM61qSZQvIEL0lXQwIqVBhS/VqeOnrKQ0UxTbsSDY28pmZfX5yeElu2A6LdX9ZkG4EIpFdfFN5mO6fG/vYpvkn8aW96JNtAjpoPK7XAsC2qreZf TEDj0p3h Ur2h3mfT/u9g2wrSZ6wAeo/A66aGyv91k/kQZy9b32mez4DZJ+1VQLIEITfxQfZFAcloGTDEAcqDjuQBlNV0vCwJkx4zKRkLS04R6ifMeKf79Dt35Uuj9gifb0EIg0bX+odvGhCNd3BnZyX4wUe61tEBlKbVwn8Ue0pfeIQuBcYJbxOR8/mUgP1HmjPJUw+hac887EPqAodlURe03ELyWRKuuWDpOhv6rU1Swg4MNNxGWl4kaayRpP0nbTgQ5jipTtY2p7+0simRwIv7SS5Y/goR4QqDmLaCr4OeHmtnpxBC9AHrL061uzss477k90bXHWzemcWCDfQkdzoC1L/bNjOXy9G0IoY1RLXCVhz1CiUR7kPZLDiN/+1JbZWevENCk5JEjq56sSCnfu5OBAeikaoLVNQO+p3EAg9UU2oDbk6twhm6u5YHQciLY7QoyTaZKYU6/Bs4SD0OFaLA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 06, 2023 at 08:01:49AM +0300, mpenttil@redhat.com wrote: > From: Mika Penttilä > > Migrating file pages and swapcache pages into device memory is not supported. > The decision is done based on page_mapping(). For now, swapcache pages are not migrated. Please fix the commit log formatting, it should not exceed 7 lines. > if (is_device_private_page(newpage) || > is_device_coherent_page(newpage)) { > - /* > - * For now only support anonymous memory migrating to > - * device private or coherent memory. > - */ > + > if (mapping) { Very nitpicky, but this empty line looks odd. Also isn't the comment still (mostly) correct given that file backed memory is still not supported? > + /* > + * For now only support anonymous memory migrating to > + * device private or coherent memory. > + * > + * Try to get rid of swap cache if possible. > + * > + */ > + if (!folio_test_anon(folio) || !folio_free_swap(folio)) { Please avoid the overly long lines.