From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B39C7EE23 for ; Wed, 7 Jun 2023 10:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C14C38E0001; Wed, 7 Jun 2023 06:27:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4C86B0072; Wed, 7 Jun 2023 06:27:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8CB28E0001; Wed, 7 Jun 2023 06:27:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 97A326B0071 for ; Wed, 7 Jun 2023 06:27:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E5171C7427 for ; Wed, 7 Jun 2023 10:27:33 +0000 (UTC) X-FDA: 80875575186.26.4F161B8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id 58B21180017 for ; Wed, 7 Jun 2023 10:27:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="rAi77/t9"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686133651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RcOzZrJWhoRnq3UjVu8IiEmZ1f/byTB2AbKHvJfMDX0=; b=SErs063nfcW1I12520aRRUqU+5bshtcxTDVoU3QqYLbYkvhXbQb7nemINsnofK0SDXsN7o a/BWoHRH0E70ADSAxFvaUANiBn8TrD7nBxJR3Y2S9946qAEnl/Vd1eQeBSOjTmeXT1TE4E d2nNXTRh8Z1bM1gaV0sBnA+pLf583tA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="rAi77/t9"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686133651; a=rsa-sha256; cv=none; b=zZVyFbouclevb1IYnNwQ/IgR+5E3WK2L8FaUQfBAwJzgYfa75z+ErUz1I169X/oLlxTtUC IU2S0nlnZXWjmaXsfUEc8KaSnvwgwJi8QUnOdhpSdgvnbL5HZRPJUHKwun3XWVzbS/o7MD 0swmHA11fcE1gfCwZPzposp9CpdMkGM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E6AFD219BF; Wed, 7 Jun 2023 10:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686133649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RcOzZrJWhoRnq3UjVu8IiEmZ1f/byTB2AbKHvJfMDX0=; b=rAi77/t94BXnu7pScTCKfbW5WjP5hkGGTuIgJrP2zFYfjopIP0nkfdiWlea1f4JBZQQyRx 1VNxxfeR/0xx4ssCCkop5/XaNvdXf58l5X3Qa4Ykr9kT2UNZhyjNhuPAIWet+G7efEAxpP +nK331TAkSdzV8e6WjToYtIoEMzEVVE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D4D171346D; Wed, 7 Jun 2023 10:27:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JMHNMpFbgGTafwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 10:27:29 +0000 Date: Wed, 7 Jun 2023 12:27:29 +0200 From: Michal Hocko To: Haifeng Xu Cc: david@redhat.com, rppt@kernel.org, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init_pgdat() Message-ID: References: <20230607024548.1240-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607024548.1240-1-haifeng.xu@shopee.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 58B21180017 X-Stat-Signature: cdrh3gd9bnaemtruykj358bgi18saph6 X-HE-Tag: 1686133651-341936 X-HE-Meta: U2FsdGVkX18b7GMI6FdzU6UQlS1Wo79lsBLmaQqWu6CE4BTNRz7QF0V5QIC11tYZycTk2a3xGbh+Q/PpUIWmm2naYAEv5veo6N19kcsHqjxnrmmZVZmQVd67/g+hRmHi0/paModtWaAgAKYwDEf3bzK7clfHsoH2P+HFh3otaJUdDJItLUWEGNbduVEV3gzUCP6bne/CnkKK1DxwGAM8uhjl8gKpB1ehvpbQ/6JiqvPMmJcWCTS1PKM3wFuffa6JUuZg4dAnnu+oQuts9mlTLSijuRbyE1yFdd6gI8KSPKwoH4jK1kBsbYwUPIuqPANKqhKUjVATXCPS4iC5nrbe9Il4BOYFdd1FyzEsDrD9vnrnUTEFzxW+ZLNKZRwlFUjr8GcaLMnEo8TOC1k0gRRgQCdxGjDyGvPSmlKsrnY0m9udo5vsKeM1Bl0490msQa3GJn2jFhJuLBTDK/bqJywXXNwqkU+VQuDsao1TF2QzHZFBcmgM/ji4/gRLs07u1bUdmuEGgZYXH66J8splR6aEktEy48+5Rh9vu4URSP7+8B4ZiSwAgFySValI2nOXXXpuub873uQqkf+F0dFPk4UXpzeB0xtsdhBJO0htBaDpHYYTxdcE6W3culjROBax1NMAOGZqU8RGf/Dv7Gpi9aEIoZ8dv8C/7SCXHrswn6z87hTitjvv6dXG1Pi8L60y/4yXmne4g8V9soQNSM1L8XlQgPigH9kYKFEdtRAzVpy0Aa1wfF0+Zwp/aNV1lAib7HsiriFZmsE1V/bN1RxNdD9i+7KROdIuEPZaTgnY37UnE9opTTcpOv/rE9jlP77XLKkftniE0dIe/o/Eq/P4mvhsuwL4wOHz7f4NQ7cGJyN3q5nqGBkPs+mo4m/mrJAqMoF03isw/pilj806UPVeA+LQ+HPFCSrv3tNDKfu4zoxD30RZTA/bMw8RycPZ+VLEt3JTvnYA85lIp9Lstd9uEky 5dkKaT2f Fx1VOQizkkyHoj0URtv3sWRcFqQ7pB7Pkp4EfSL/1b2hRtvQ/YoK7QcCP/Pv7nVkT3XUmhTcQJd+bksNoFrED/v6MIl5Ej2l7Kd2Q/rHhDhW2o/+Hc9+CQyfYNOHuo/Jv+b7v+TE0+EqLr2t0YPu7vmeagFVnulCWAMplVy3KKB4fg2kIcVybV9RadexKKgeKsjg7k3oKjvwHw/+biYiM0Mxvdai1jYja5a+U8kNJPCMj2uuCfNOFDjp7PTRRHzu/NB3nNep8RhrFHDfnB9k6JPGBiSxE+cMEd5XAAiA+0jXG/2l113erbJR6/4Q2uztnDZtuptGdIBlIT0rznuNfu2aCpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 07-06-23 02:45:48, Haifeng Xu wrote: > managed pages has already been set to 0 in free_area_init_core_hotplug(), > via zone_init_internals() on each zone. It's pointless to reset again. > > Furthermore, reset_node_managed_pages() no longer needs to be exposed > outside of mm/memblock.c. Remove declaration in include/linux/memblock.h > and define it as static. > > In addtion to this, the only caller of reset_node_managed_pages() is > reset_all_zones_managed_pages(), which is annotated with __init, so it > should be safe to also mark reset_node_managed_pages() as __init. > > Signed-off-by: Haifeng Xu > Suggested-by: David Hildenbrand Acked-by: Michal Hocko > --- > v2: > - unexport reset_node_managed_pages() > - mark reset_node_managed_pages() as __init > - update commit message > --- > include/linux/memblock.h | 1 - > mm/memblock.c | 2 +- > mm/memory_hotplug.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f82ee3fac1cd..f71ff9f0ec81 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -128,7 +128,6 @@ int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); > > void memblock_free_all(void); > void memblock_free(void *ptr, size_t size); > -void reset_node_managed_pages(pg_data_t *pgdat); > void reset_all_zones_managed_pages(void); > > /* Low level functions */ > diff --git a/mm/memblock.c b/mm/memblock.c > index 3feafea06ab2..da4264528e1e 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2122,7 +2122,7 @@ static unsigned long __init free_low_memory_core_early(void) > > static int reset_managed_pages_done __initdata; > > -void reset_node_managed_pages(pg_data_t *pgdat) > +static void __init reset_node_managed_pages(pg_data_t *pgdat) > { > struct zone *z; > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..65e385f34679 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid) > * online_pages() and offline_pages(). > * TODO: should be in free_area_init_core_hotplug? > */ > - reset_node_managed_pages(pgdat); > reset_node_present_pages(pgdat); > > return pgdat; > -- > 2.25.1 -- Michal Hocko SUSE Labs