From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56152C7EE29 for ; Wed, 7 Jun 2023 10:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 513FD6B0071; Wed, 7 Jun 2023 06:16:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C4716B0072; Wed, 7 Jun 2023 06:16:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38BCA8E0001; Wed, 7 Jun 2023 06:16:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 26CAE6B0071 for ; Wed, 7 Jun 2023 06:16:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E6DD6401D4 for ; Wed, 7 Jun 2023 10:16:10 +0000 (UTC) X-FDA: 80875546500.10.460745A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 0F57F4001D for ; Wed, 7 Jun 2023 10:16:08 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=UldiIttJ; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686132969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OtOZgD95z/IBl7SqKk0BG6TOYMfHhxxJyQnJ1HGyzbM=; b=W+4vllw/i9gK93Phnz1/Ubh9KkqE3Hm3fd2nV7AMDXplpm59TfxZwX8GypXPsZqwEg/xKy CCcDKCADFG98/2plinFYWTwN0RzB9in6GUEuLCe4U9zmI4I64cEd8Br64DaCC517OjTajn oVoeJ7ggVito1pdfZFpOj3EefCZF8+g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686132969; a=rsa-sha256; cv=none; b=WApJcwCP/6mxSbsYLWpCsQPkss2muM1ueSeiA1Z+6f3vW9J20uv3MPztuF4myTGF7iOH3C OW10va2HJsAaCPHy8sHgVxcgpqXrZUgz8xb64NHckn5tu25PEEjaHtKQj4Xhw2EqW1b/FX bpIWZdsV3KEN8ECmtnVy/HwG4nkWx9M= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=UldiIttJ; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4BC0B1FDAE; Wed, 7 Jun 2023 10:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686132967; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OtOZgD95z/IBl7SqKk0BG6TOYMfHhxxJyQnJ1HGyzbM=; b=UldiIttJJHN/rLQo5Q+nk5SR9MQ1ebiuV5HR+bfplwSBDy3eEkESROO/aI426UWBykaMW/ 77G9jOiMKjIxVIVc+EDuXjrq943SMpFUMjQxMceAkyrN8eO6EF6LWVwLEZiF8S01JoAOmS iHaCxXxZb3oyxZW/4XDnafFP+JdFIqM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C99713776; Wed, 7 Jun 2023 10:16:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +uohDudYgGTTeQAAMHmgww (envelope-from ); Wed, 07 Jun 2023 10:16:07 +0000 Date: Wed, 7 Jun 2023 12:16:06 +0200 From: Michal Hocko To: Haifeng Xu Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone Message-ID: References: <20230607090734.1259-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607090734.1259-1-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: 0F57F4001D X-Rspam-User: X-Stat-Signature: hw6xpmb4n8rfiu7f1yzoxei54exafh5t X-Rspamd-Server: rspam03 X-HE-Tag: 1686132968-456889 X-HE-Meta: U2FsdGVkX1/ioc6VX054AE0Nx4dbZZDsjX6RfsGF/SaxmBV1H8KSMC8N1f9QAP5UA4fzl02nGxrDn9EgV3bg16bC8dVkBhQV9BPdFHhDIphIIv031kDIsfUI0Wix6a5qSKub/X+bAH4IyPZ1PQHI6ZstCYeV27e+/Ae0GGIfo4luxXX/nv7F6rhCeMGxAJNytbGGtz7N3rAeCJDa03DEnnx2vJNqAKT1dvjaGJpHMs9Z3HOg0fXHRPGC8HfD4y3f9kUydUvYwwlTnMbMqy/Ilqsfcgv5aR7Jn3hbZElXNuU5tj80ypFmzas6KwrIA7RLfTlMT8/X/6cU3rB5BENXpvFDOksP1hv47ZEXo34NEasf7XbglfVV9VdRVd0zR7FD2K6PjlBvkfwz1kkBFucOkzxlfI7FVa4iCFyBoR2MowZNgsOKjFNa3dWFgFj3JLpNYKHR5HpRJ36Do7NZYfTJpZba5l5SyoWwbffFszZj7rpeKFZhFU0o8cQh+Dc+knbvuB49OZ/b2W7mV5YtExJWCeTTpKfjnhFeTpzi/5WN+G1vdJqAbe693KkfMhtTtIeb7hKJ3SXYUJKKP6CpOIi759ZZnyda7F3A3k404RtJVZbBokznA4axB4FaJ8al9TeFxyPVx4qFyr/zuOaX0vE7c5Bw+APr1nrqw1weMTeA5t37VXBDpk7zX5haUgXlkRWPyPHlZsf22ilX2M5kK8phnJY6HUc386R7/zd3KJVQ9XWsHssGVG6U+MkQvzOM7DGF8LDQUTT7gQZMOpViCR0JAC3hKom8pAHQ8/5N9MujY59WrP3vMqbjB65tM8e3FqY7X7xc0zqyg3hSmeFidK5bewpXWDzxfE882EKHU3T7H+4mHywLclQjz5cp98g2Q+rWOzGljqnj2GM8PSYm4Lf4Uh8ABWeXpULB3Tb+d96NQjBw7Kg07igQ+qqOn6/kvc6rY4L0tQLtjNQ+DxLlcMz LVvmLgHN MxMbm/JHMBuAiKLiY0HwX0F4q6CcQ7kt7b5PmetjkNvRwKGJu+O1EMPQm/08jGQu4c0pCNQzf18C3f4JR3G7umx9yWnj8nNEY+UGiK52wvc8qarWJCvS6c7pGUG5abZNwisHfXnOL4gXFJZH93y7ZGrNuSZgAeMK1/B13az9ITubRXepTQAY5ISXj9remuKkrFPtn1ixFVINFug9gWDZxequOtkRs1XRPcMZOc8IIORd31IuX2sEj4ZXIVffOBfb8nauR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 07-06-23 09:07:34, Haifeng Xu wrote: > If freesize is less than dma_reserve, print warning message to report > this case. Why? > Signed-off-by: Haifeng Xu > --- > mm/mm_init.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 232efac9a929..9a9d6a52471c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1561,9 +1561,14 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > } > > /* Account for reserved pages */ > - if (j == 0 && freesize > dma_reserve) { > - freesize -= dma_reserve; > - pr_debug(" %s zone: %lu pages reserved\n", zone_names[0], dma_reserve); > + if (j == 0) { > + if (freesize >= dma_reserve) { > + freesize -= dma_reserve; > + pr_debug(" %s zone: %lu pages reserved\n", > + zone_names[0], dma_reserve); > + } else > + pr_warn(" %s zone: %lu reserved pages exceeds freesize %lu\n", > + zone_names[0], dma_reserve, freesize); > } > > if (!is_highmem_idx(j)) > -- > 2.25.1 -- Michal Hocko SUSE Labs