From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FAEC83003 for ; Wed, 7 Jun 2023 08:41:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44CEE6B0071; Wed, 7 Jun 2023 04:41:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FD306B0072; Wed, 7 Jun 2023 04:41:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C4A78E0001; Wed, 7 Jun 2023 04:41:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 19F626B0071 for ; Wed, 7 Jun 2023 04:41:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D099D160185 for ; Wed, 7 Jun 2023 08:41:10 +0000 (UTC) X-FDA: 80875307100.08.2AE8776 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by imf26.hostedemail.com (Postfix) with ESMTP id 83C0A14001D for ; Wed, 7 Jun 2023 08:41:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of herbert@gondor.apana.org.au designates 167.179.156.38 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686127269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AgF7Nf7XvVlI+9gtCxrJKyAbFzhNzMJ3/y4DzrxtxaE=; b=vPms5NtYDj6tAE2fV3Qe6ldkGxR49ybNmWwhpfIiHFEM4INGBF3Xyqq/6SPsJZVRuteZ0S ZtXdCR4SDxkLP2E7ikOETDRbbQ8M+3Cww4p4p29bjbjuGCiq6m+jmkqMo/VC2OFfMImFib zh36J0rYu+TK4OuJVBYwN2pbgyb67HA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of herbert@gondor.apana.org.au designates 167.179.156.38 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686127269; a=rsa-sha256; cv=none; b=THRpSKbb5CIGtGgWL3OjZSkQ5ABhfcNB0w28gFbr+J7E7mC8mzKPq303QBgRdmHMUuuFJ5 lGHPciG8wqc+XuUeOeSk9HBnxs+njmDUB5WOqcqWS8OEgDutPDpMcAUGkKj0rcoptv0xcC jj7Ivi7ZKbY9NQoeC3lUp20C9kZYYjo= Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1q6oia-00075p-Kc; Wed, 07 Jun 2023 16:40:37 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 07 Jun 2023 16:40:36 +0800 Date: Wed, 7 Jun 2023 16:40:36 +0800 From: Herbert Xu To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 05/10] crypto: af_alg: Pin pages rather than ref'ing if appropriate Message-ID: References: <20230606130856.1970660-1-dhowells@redhat.com> <20230606130856.1970660-6-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606130856.1970660-6-dhowells@redhat.com> X-Rspamd-Queue-Id: 83C0A14001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kij788mwguonok74kq84u8q66b6x8gpp X-HE-Tag: 1686127264-640542 X-HE-Meta: U2FsdGVkX1/qzsXN606IIFKu5SNOZPPiiBEXPgLqKx8MoDw+8DY53UN0J3TY4T4Jskb2ErdLuDKYlfDl3i+PvEeAhMW5OTGWBs15nROMfULpl45ubEAngntyfEBYw2HC/RbhgE4ldP5aObullrWs97uLQiZD7wwiqi24Y3mbeVSmpIiDd5NzRx1cSjIAzdZsbzFW8e0m7y90PNk2j4tTBPvOPRZTLhASeUUb64MlmqSK7AFdJx2+dSV6QkMP9P/H2N45MnbzELgh9L/bZyA6w/0FPo+EYjIKJqiLCE06USxU3zpUwVTVw5PfaP2vVppDflkIcs8LppbJiZ2P8WN6/zmc4FBjm6Zh01y1cvhGQOfp7N0I/sQgIJJ2S5a5i0MMPreAPvmepwHZPWIMpdcteaGbc8MDilmRpQ1NRBoUWWpU1qvgmzsSdvM/5HRcu2eGxcu1wsC+x9sGeJQLwvVcUxWxieA1lQpbYajFgsfLjLNdZA2uTQl+hzcc6c/UuAoMDhZ2QKdbAqfyWBFpTSy+tbbL4EkWknlRY00+8OZMTFm98elJdMkZZxn4j5HigWEaZS6r6wRveP82Z+HB242GIi5m4XeKTRu2CpUnF8qK0BdOgRuJJTUE7dEyjCYm6i6b4awR0Ww3Cnb1aUu6oif+7koA8YQXKXaBta/RuuKxpfNa1UtTuGaKXVAnB7FQXQHp7k77z38lG71ic0atbWzPugFX0rNZly/gjJG8Y2dru5/H0J4TuceOhxvdqVu8U+t+r8rw6ayghqrbCPhzdTqfhx2tx+wx8l8ueybvVu4JT2aCnWIbkPbOaRbLI6hGhZ11sFCKRxspxcici8AO5QD/306mikNdpieiFA30Jv9l+x6+dOREmQhxVPhXddow+imdXiwivlGa1hlzBDe9oWHFrZWtNllsih8UanPEKQSNicHtpDHyhyZia9A9Tlg6LnJGvsePxI6cGaxZvF3ugMP 0IYLyk/2 2oj4fRjAjWuTAEy1fP27IobYt2H2nz7Ob7WO9zFFoatxZ9vLI9d9FYG7o4U0tLmJKhQ6bdQbpXsm0FfoQJ7naS0Z0s88vxIyS6d0UAIJsSiD+0nT4wr6H1BaEAy+Nvsk3XfuzlzW4XITZk4wg/i9XGEGpAgNZkmczJx5cAWr6GKzLyynL71Lb3uTadS+HdF3qIdns6p/0ZrTXnhMPFVTJl6lqsW8HfqV39crFCgfjBp9paQjiDYiSGrkG7DbzeVpG1OV1Q5Pea55c/jMlE7vahqIT0KVBLk9rWujPG5glSnXKPBPrgVvJe7PNAt4N7oZ67PWZvTBZTDvUOVxDUOkHHLfnL82ZSDpn8hefbyS6uQDcwV/RVmFbNVfoXiUpQLVpuoCUFur6yRHdZSfuog4ElCwzt6xe8Ci4NeIM/RCDCVDP2Z6T29gZTlmoUFc7e500XmTcCDWKzobKru211bBUJbWGfOq8pyOhgXQoDXEplM6BQ/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 06, 2023 at 02:08:51PM +0100, David Howells wrote: > Convert AF_ALG to use iov_iter_extract_pages() instead of > iov_iter_get_pages(). This will pin pages or leave them unaltered rather > than getting a ref on them as appropriate to the iterator. > > The pages need to be pinned for DIO-read rather than having refs taken on > them to prevent VM copy-on-write from malfunctioning during a concurrent > fork() (the result of the I/O would otherwise end up only visible to the > child process and not the parent). > > Signed-off-by: David Howells > cc: Herbert Xu > cc: "David S. Miller" > cc: Eric Dumazet > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Jens Axboe > cc: Matthew Wilcox > cc: linux-crypto@vger.kernel.org > cc: netdev@vger.kernel.org > --- > crypto/af_alg.c | 10 +++++++--- > include/crypto/if_alg.h | 1 + > 2 files changed, 8 insertions(+), 3 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt