From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C08EC7EE23 for ; Wed, 7 Jun 2023 06:58:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3BC68E0001; Wed, 7 Jun 2023 02:58:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEC266B0072; Wed, 7 Jun 2023 02:58:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB3878E0001; Wed, 7 Jun 2023 02:58:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9BC566B0071 for ; Wed, 7 Jun 2023 02:58:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6485F1C70E0 for ; Wed, 7 Jun 2023 06:58:49 +0000 (UTC) X-FDA: 80875049178.11.7CD34F6 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 7304B80002 for ; Wed, 7 Jun 2023 06:58:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="ci3FU/8Y"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686121127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=82Mu8QU4HigZydZK6DfsxJpMaVzvXeGB338dtPOY7lc=; b=G3cbbJDg+ZpQ8Pa4eAfmj35NrQ68lDmNon/ZCQugcs8kkMBPiZGTE8n4b3WFi8JvTOxIIt XpjIUxsYu+LQkX3BU3kRuncDDvNB0kxz3gc9PFrDvzkmJUfMb0A46NS/qS8hQ2Z89W0U6R LRrUTSNWO352L8lN41WCwXN87/XZsG4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="ci3FU/8Y"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686121127; a=rsa-sha256; cv=none; b=PBP3UpXAvUl7kg2LGAFrUm487M6PnQa3wcA9j0EvIzTIsu3fBuiw9U9NLHm5mRVeNwI+zi 3KP3QQ+MSfP1KEXbLzaf1Qo5pmaRkAxPc3OeSeqtCFDBKVBIQXaqHMp9bYiiGSWplDzfhA Nx1aYFFFPjtgd9fM1HC8o6WCsNWbCck= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2b1bdfe51f8so3333141fa.0 for ; Tue, 06 Jun 2023 23:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686121125; x=1688713125; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=82Mu8QU4HigZydZK6DfsxJpMaVzvXeGB338dtPOY7lc=; b=ci3FU/8Ywn3sJORB9+b8BmfaGsKCl5pt/0UliRmgmvFvOY8lecCDd6qiEFFrJkog39 e4Ti+y49/WlBtP7CARqhfDuVITEYKcv35NBmt7nkKU63tU2dSrGr+ir5G3q6b7sEoPfy 76wwyY+cOcCFZA+klvxrfQTHlk2kAWNxoondLl331cRz2g07xiYqrzcXuCj0rgf8hesA aZhDE4CIHNqdkITdqdIe/KEqEoWtx5YgyT1/au1fh5SJBH5O67jIIoiTLrmCsipIgH9z l8As81tUBAlzKfkwFxJ7vmgJjR9dqQv8H54QywLscqH+Yd7IOf97Hkce2XzhJQejWcyf 3VCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686121125; x=1688713125; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=82Mu8QU4HigZydZK6DfsxJpMaVzvXeGB338dtPOY7lc=; b=Z5kFt53QSAMd5vLBRwBJkLDe9PRgHCfquIbeHVBDI+eL7pxyC9TSYyMjk4cD4Qpx0M 8omXukRo2eaCdKXf1zVg2vsrCwu+z7j3nr5CmgF1bqfGSEopgFWb/1dzr2I8b8m5z+UD 06BKzgLR2N8OnUbEcbkZc/JVg+8DR/7B3yYF+p5l14nNGobBu8l1DcocrlkMtLPrZwgo kjP8nZaIEksszEfxSG32US65BZPwxqqHEQ/UAwOc2rd220kr/OwqBD5m6IbdIkKOMNuv 9Vk4N1Pj4nXZ28E2zgnS6fqU1nhB1NF+BtNLgXMt+W/Cw8zz6oS/OSWZk4XmHRo/Gd9a +UKA== X-Gm-Message-State: AC+VfDyIpIQuOlStu6lN1Ixrj326GaFnNGf7t6HqqXeS0rGUFDMAMoVw Q09gPrSB2Z9znDHZi6B2EgY= X-Google-Smtp-Source: ACHHUZ5B2RdpfLHe8NDMciXzpd9hXBiT9WzxU7nqW7jVGDhWqel12HsOpeMGr/WkkkljEJcjMoA5oQ== X-Received: by 2002:a2e:2d02:0:b0:2ac:6f6d:aee4 with SMTP id t2-20020a2e2d02000000b002ac6f6daee4mr1635329ljt.6.1686121125258; Tue, 06 Jun 2023 23:58:45 -0700 (PDT) Received: from pc636 (host-90-233-211-151.mobileonline.telia.com. [90.233.211.151]) by smtp.gmail.com with ESMTPSA id t17-20020a2e9c51000000b002ac7a25c001sm2109931ljj.24.2023.06.06.23.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 23:58:44 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 7 Jun 2023 08:58:42 +0200 To: Baoquan He Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH 8/9] mm: vmalloc: Offload free_vmap_area_lock global lock Message-ID: References: <20230522110849.2921-1-urezki@gmail.com> <20230522110849.2921-9-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7304B80002 X-Stat-Signature: w1zib5moqdw3iifbqg4yx8w6dyt6o9y5 X-Rspam-User: X-HE-Tag: 1686121127-512497 X-HE-Meta: U2FsdGVkX18adIM0j6BkfPsYdNAmKurCW8D1BFwj+bab8Eb/4r/YlDnw4YGVLC2h0jUi9tislTNi2IPTgJTcW+q4GqPaDjYYo1CE+bLAn4QihEKs2hykp6ucVd5AQTkvQkC7akH4W3r/r4zFXKzLLcCH5RJwuqnRR89mqmKKxa955D08LlXeYe9y+H209rDJQ+CLUGWqMQWcIB201sQiwGHjIze1koaH8Wt5HP5rzmtHZ010LcBg/E4PUumMvC6kUURP7xERVzpn2TMCqHOLRR9Jk8nqcwJ9gGQEMJUpj937kXTEMNqCbZth7oNqWDLdUEuV8EEMF8g/hsA/bd4wPkAZETrTPVBnjeL83R+6qCn1I+7KDdkVgdX1F+TVNhYof7fcx4dcHNUu8dF9J2lP1fSO+JElRJnQguLrro+rGZn/6acAuT9cAnvi70xoQc8/Qx+6FPG33cCqfZ1YZnn9+i7UlDHBCsnxAj6JMgikHbWKEpjMsQC8yVE8xRIYD+TmQ9nhun6SoBwK08OOyvC7pgnpCNuQ9mA/ctIPYu1O3rxSnkQLSfvpiSXHpZ7gNPMqLkTjfNqah2zbo76WKOtXYPHoeebNFzF3OAzQgLLyj7ZGbidVC+Jp+Q/PbGLFNiQFITAUMDDHSckGng4P+oqo9hXLhME5PGj6t1fhpPzM8Ld9etbJI6A4SjgTqVlZC3F6dOE2ZHn2JbNeJkyaJbUN88+7NiEfrAk9if8JKBvadrbsJNok+nhyCmFHURaZz/iNhY7aJincgHLgogyeLgZ5k1eRhX3FUxdCnulhNizq1sGYPm72XV1D76wuQwutHXGQHRoWR1kpHUzJ5SHIwN1el5jht5wHgDL38bnli2d7h7QuZDLudnBIaUYr3iZbxTal8COOxQ4GXNr2xPCbQkd42saLtsVqCcWVvCyvL19B0J6wNyNrZzqqws4C7ZuhXBoiNCI/TWqMmff4UmQ6V65 lcFmfaqt RK1RudNDn0oQFNn27GXnAO1zacRjt4NDni9rEZEMMjryMjFpClnNqpISeWq9WcxmQlPk4BT313YRDz0+h5kCU5amvfzUHmKB1n4BdP9IxBh+DrAUSEYMeH7ESCXEI5h57EkDsZSmBoHFqC4JhARrFFIjrpT0b+TvlV68slodPyNHDnVpgQVh7KgrKnwezS07iR+iEsp7+SVD3fxJyMKw+YkmHSRpwMyCIDf5RxdeZGDVeJ/guCM/8eBHMZcxVfrglKuf48jatAHHYO9AgX8bn+b0NUSYeJFNRlhdC+tx3FFC4RT8uf6X+OLYlrOzl+icnfwGmHh+QKsRm9hOrQqGiDl7QPuDzKRbeo5FSmmB7IUzJ0uw5rxpci1cI5zwYHU/By0hOYyafgairgV1PhOh/Z1dG7S1zJSK8j3xUzNw/t8BTnUEC31lRJ+IhZu2SnOWDfsU8LqA6WcRA3JPa9CKtCgpY31e7myzmbrGg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 06, 2023 at 08:11:04PM +0800, Baoquan He wrote: > On 06/06/23 at 11:01am, Uladzislau Rezki wrote: > > On Mon, Jun 05, 2023 at 08:43:39AM +0800, Baoquan He wrote: > > > On 05/22/23 at 01:08pm, Uladzislau Rezki (Sony) wrote: > > > ...... > > > > +static unsigned long > > > > +this_cpu_zone_alloc_fill(struct cpu_vmap_zone *z, > > > > + unsigned long size, unsigned long align, > > > > + gfp_t gfp_mask, int node) > > > > +{ > > > > + unsigned long addr = VMALLOC_END; > > > > + struct vmap_area *va; > > > > + > > > > + /* > > > > + * It still can race. One task sets a progress to > > > > + * 1 a second one gets preempted on entry, the first > > > > + * zeroed the progress flag and second proceed with > > > > + * an extra prefetch. > > > > + */ > > > > + if (atomic_xchg(&z->fill_in_progress, 1)) > > > > + return addr; > > > > + > > > > + va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); > > > > + if (unlikely(!va)) > > > > + goto out; > > > > + > > > > + spin_lock(&free_vmap_area_lock); > > > > + addr = __alloc_vmap_area(&free_vmap_area_root, &free_vmap_area_list, > > > > + cvz_size, 1, VMALLOC_START, VMALLOC_END); > > > > + spin_unlock(&free_vmap_area_lock); > > > > > > The 'z' is passed in from this_cpu_zone_alloc(), and it's got with > > > raw_cpu_ptr(&cpu_vmap_zone). Here when we try to get chunk of cvz_size > > > from free_vmap_area_root/free_vmap_area_list, how can we guarantee it > > > must belong to the 'z' zone? With my understanding, __alloc_vmap_area() > > > will get efficient address range sequentially bottom up from > > > free_vmap_area_root. Please correct me if I am wrong. > > > > > We do not guarantee that and it does not worth it. The most important is: > > > > If we search a zone that exactly match a CPU-id the usage of a global > > vmap space becomes more wider, i.e. toward a high address space. This is > > not good because we can affect other users which allocate within a specific > > range. On a big system it might be a problem. Therefore a pre-fetch is done > > sequentially on demand. > > > > Secondly, i do not see much difference in performance if we follow > > exactly CPU-zone-id. > > Ah, I see, the allocated range will be put into appropriate zone's > busy tree by calculating its zone via addr_to_cvz(va->va_start). The > cvz->free tree is only a percpu pre-fetch cache. This is smart, thanks a > lot for explanation. > Yes. The busy/lazy are placed per-cpu zone(using addr_to_cvz(addr)) whereas the allocated chunk on a current CPU. Thanks! -- Uladzislau Rezki